| Message ID | 20221005-mt6357-support-v5-7-8210d955dd3d@baylibre.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Add MediaTek MT6357 PMIC support | expand |
On 16/11/2022 13:33, Alexandre Mergnat wrote: > - Change the node name from "mt6358" to "pmic" to be consistent > with mediatek,pwrap.yaml documentation. > > - Change the node name from "mt6358rtc" to "rtc" to be consistent > with mediatek,mt6397-rtc.yaml documentation. > > - Change the node name from "mt6358keys" to "keys" to be consistent > with mediatek,pmic-keys.yaml documentation. > I think the node names should be changed anyway. So I'd advise to update the commit message and I can take some right away. Regards, Matthias > Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> > --- > arch/arm64/boot/dts/mediatek/mt6358.dtsi | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/mediatek/mt6358.dtsi b/arch/arm64/boot/dts/mediatek/mt6358.dtsi > index 98f3b0e0c9f6..b605313bed99 100644 > --- a/arch/arm64/boot/dts/mediatek/mt6358.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt6358.dtsi > @@ -5,7 +5,7 @@ > #include <dt-bindings/input/input.h> > > &pwrap { > - pmic: mt6358 { > + pmic: pmic { > compatible = "mediatek,mt6358"; > interrupt-controller; > interrupt-parent = <&pio>; > @@ -355,11 +355,11 @@ mt6358_vsim2_reg: ldo_vsim2 { > }; > }; > > - mt6358rtc: mt6358rtc { > + mt6358rtc: rtc { > compatible = "mediatek,mt6358-rtc"; > }; > > - mt6358keys: mt6358keys { > + mt6358keys: keys { > compatible = "mediatek,mt6358-keys"; > power { > linux,keycodes = <KEY_POWER>; >
diff --git a/arch/arm64/boot/dts/mediatek/mt6358.dtsi b/arch/arm64/boot/dts/mediatek/mt6358.dtsi index 98f3b0e0c9f6..b605313bed99 100644 --- a/arch/arm64/boot/dts/mediatek/mt6358.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt6358.dtsi @@ -5,7 +5,7 @@ #include <dt-bindings/input/input.h> &pwrap { - pmic: mt6358 { + pmic: pmic { compatible = "mediatek,mt6358"; interrupt-controller; interrupt-parent = <&pio>; @@ -355,11 +355,11 @@ mt6358_vsim2_reg: ldo_vsim2 { }; }; - mt6358rtc: mt6358rtc { + mt6358rtc: rtc { compatible = "mediatek,mt6358-rtc"; }; - mt6358keys: mt6358keys { + mt6358keys: keys { compatible = "mediatek,mt6358-keys"; power { linux,keycodes = <KEY_POWER>;
- Change the node name from "mt6358" to "pmic" to be consistent with mediatek,pwrap.yaml documentation. - Change the node name from "mt6358rtc" to "rtc" to be consistent with mediatek,mt6397-rtc.yaml documentation. - Change the node name from "mt6358keys" to "keys" to be consistent with mediatek,pmic-keys.yaml documentation. Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> --- arch/arm64/boot/dts/mediatek/mt6358.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)