| Message ID | 20220915013304.213917-1-linyujun809@huawei.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [-next,v2] rtc: stmp3xxx: Add failure handling for stmp3xxx_wdt_register() | expand |
On Thu, Sep 15, 2022 at 09:33:04AM +0800, Lin Yujun wrote: > Use platform_device_put() to free platform device before print > error message when platform_device_add() fails to run. Add dev_err() > to report error in case of alloc memory to wdt_pdev fail. The second part of the commit message is now obsolete.
OK, I'll remove the second part of the commit message and send a v3 patch. 在 2022/9/15 14:31, Wolfram Sang 写道: > On Thu, Sep 15, 2022 at 09:33:04AM +0800, Lin Yujun wrote: >> Use platform_device_put() to free platform device before print >> error message when platform_device_add() fails to run. Add dev_err() >> to report error in case of alloc memory to wdt_pdev fail. > The second part of the commit message is now obsolete. >
diff --git a/drivers/rtc/rtc-stmp3xxx.c b/drivers/rtc/rtc-stmp3xxx.c index 40c0f7ed36e0..aae40d20d086 100644 --- a/drivers/rtc/rtc-stmp3xxx.c +++ b/drivers/rtc/rtc-stmp3xxx.c @@ -107,6 +107,8 @@ static void stmp3xxx_wdt_register(struct platform_device *rtc_pdev) wdt_pdev->dev.parent = &rtc_pdev->dev; wdt_pdev->dev.platform_data = &wdt_pdata; rc = platform_device_add(wdt_pdev); + if (rc) + platform_device_put(wdt_pdev); } if (rc)
Use platform_device_put() to free platform device before print error message when platform_device_add() fails to run. Add dev_err() to report error in case of alloc memory to wdt_pdev fail. Fixes: 1a71fb84fda6 ("rtc: stmp3xxx: add wdt-accessor function") Signed-off-by: Lin Yujun <linyujun809@huawei.com> --- drivers/rtc/rtc-stmp3xxx.c | 2 ++ 1 file changed, 2 insertions(+)