| Message ID | 20220624120203.2817457-1-srinivas.neeli@xilinx.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [V9,1/3] dt-bindings: rtc: zynqmp: Add clock information | expand |
On Fri, 24 Jun 2022 17:32:01 +0530, Srinivas Neeli wrote: > Added clock information and deprecated calibration support. > > Signed-off-by: Srinivas Neeli <srinivas.neeli@xilinx.com> > Reviewed-by: Rob Herring <robh@kernel.org> > --- > Changes in V9: > -Updated clock information in clock-names. > Changes in V8: > -None > Changes in V7: > -None > Changes in V6: > -Removed dtc warnings. > Changes in V5: > -Removed quotes and _clk suffix from clocknames. > Changes in V4: > - Deprecated calibrtion support > Changes in V3: > - New patch > --- > .../devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.example.dtb: rtc@ffa60000: clock-names:0: 'rtc' was expected From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On 24/06/2022 14:02, Srinivas Neeli wrote: > Added clock information and deprecated calibration support. > > Signed-off-by: Srinivas Neeli <srinivas.neeli@xilinx.com> > Reviewed-by: Rob Herring <robh@kernel.org> > --- > Changes in V9: > -Updated clock information in clock-names. > Changes in V8: > -None > Changes in V7: > -None > Changes in V6: > -Removed dtc warnings. > Changes in V5: > -Removed quotes and _clk suffix from clocknames. > Changes in V4: > - Deprecated calibrtion support > Changes in V3: > - New patch > --- > .../devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml b/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml > index bdb72d3ddf2a..9dfe2cc5966a 100644 > --- a/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml > +++ b/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml > @@ -23,8 +23,15 @@ properties: > reg: > maxItems: 1 > > + clocks: > + maxItems: 1 > + > + clock-names: > + items: > + - const: rtc > + > interrupts: > - minItems: 2 > + maxItems: 2 > > interrupt-names: > items: > @@ -39,6 +46,7 @@ properties: > minimum: 0x1 > maximum: 0x1FFFFF > default: 0x198233 > + deprecated: true > > required: > - compatible > @@ -61,5 +69,7 @@ examples: > interrupts = <0 26 4>, <0 27 4>; > interrupt-names = "alarm", "sec"; > calibration = <0x198233>; > + clock-names = "rtc_clk"; > + clocks = <&rtc_clk>; Please test your bindings with `make dt_binding_check` before sending. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml b/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml index bdb72d3ddf2a..9dfe2cc5966a 100644 --- a/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml +++ b/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml @@ -23,8 +23,15 @@ properties: reg: maxItems: 1 + clocks: + maxItems: 1 + + clock-names: + items: + - const: rtc + interrupts: - minItems: 2 + maxItems: 2 interrupt-names: items: @@ -39,6 +46,7 @@ properties: minimum: 0x1 maximum: 0x1FFFFF default: 0x198233 + deprecated: true required: - compatible @@ -61,5 +69,7 @@ examples: interrupts = <0 26 4>, <0 27 4>; interrupt-names = "alarm", "sec"; calibration = <0x198233>; + clock-names = "rtc_clk"; + clocks = <&rtc_clk>; }; };