| Message ID | 20220505022314.59822-1-chi.minghao@zte.com.cn |
|---|---|
| State | Accepted |
| Headers | show |
| Series | rtc: simplify the return expression of rx8025_set_offset() | expand |
Hi, 2022年5月5日(木) 11:23 <cgel.zte@gmail.com>: > > From: Minghao Chi <chi.minghao@zte.com.cn> > > Simplify the return expression. > > Reported-by: Zeal Robot <zealci@zte.com.cn> > Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn> > --- > drivers/rtc/rtc-rx8025.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) Reviewed-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org> Best regards, Nobuhiro
On Thu, 5 May 2022 02:23:14 +0000, cgel.zte@gmail.com wrote: > From: Minghao Chi <chi.minghao@zte.com.cn> > > Simplify the return expression. > > Applied, thanks! [1/1] rtc: simplify the return expression of rx8025_set_offset() commit: bce7a01ada6456d00c69cd816357ded268ad780c Best regards,
diff --git a/drivers/rtc/rtc-rx8025.c b/drivers/rtc/rtc-rx8025.c index 5bfdd34a72ff..b32117ccd74b 100644 --- a/drivers/rtc/rtc-rx8025.c +++ b/drivers/rtc/rtc-rx8025.c @@ -436,7 +436,6 @@ static int rx8025_set_offset(struct device *dev, long offset) { struct i2c_client *client = to_i2c_client(dev); u8 digoff; - int err; offset /= RX8025_ADJ_RESOLUTION; if (offset > RX8025_ADJ_DATA_MAX) @@ -449,11 +448,7 @@ static int rx8025_set_offset(struct device *dev, long offset) offset += 128; digoff = offset; - err = rx8025_write_reg(client, RX8025_REG_DIGOFF, digoff); - if (err) - return err; - - return 0; + return rx8025_write_reg(client, RX8025_REG_DIGOFF, digoff); } static const struct rtc_class_ops rx8025_rtc_ops = {