| Message ID | 20211130055541.2789-1-srinivas.neeli@xilinx.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [V3,1/2] dt-bindings: rtc: zynqmp: Add clock information | expand |
> -----Original Message----- > From: Srinivas Neeli <srinivas.neeli@xilinx.com> > Sent: Tuesday, November 30, 2021 11:26 AM > To: a.zummo@towertech.it; alexandre.belloni@bootlin.com; Michal Simek > <michals@xilinx.com>; Srinivas Goud <sgoud@xilinx.com>; Shubhrajyoti Datta > <shubhraj@xilinx.com>; Radhey Shyam Pandey <radheys@xilinx.com> > Cc: linux-rtc@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > kernel@vger.kernel.org; git <git@xilinx.com>; Srinivas Neeli > <sneeli@xilinx.com> > Subject: [PATCH V3 1/2] dt-bindings: rtc: zynqmp: Add clock information > > Added clock information and deprecated calibration support. Better to also add some background for this change. > > Signed-off-by: Srinivas Neeli <srinivas.neeli@xilinx.com> Please add Rob and DT mailing list. ./scripts/get_maintainer.pl <.patch> > --- > Changes in V3: > -New patch > --- > .../bindings/rtc/xlnx,zynqmp-rtc.yaml | 20 +++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml > b/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml > index bdb72d3ddf2a..7e87bc1ef9df 100644 > --- a/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml > +++ b/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml > @@ -26,20 +26,19 @@ properties: > interrupts: > minItems: 2 > > + clocks: > + items: > + - description: rtc_clk is the operating frequency of crystal. > + > + clock-names: > + items: > + - const: "rtc_clk" > + > interrupt-names: > items: > - const: alarm > - const: sec > > - calibration: What about existing users for this property? > - description: | > - calibration value for 1 sec period which will > - be programmed directly to calibration register. > - $ref: /schemas/types.yaml#/definitions/uint32 > - minimum: 0x1 > - maximum: 0x1FFFFF > - default: 0x198233 > - > required: > - compatible > - reg > @@ -60,6 +59,7 @@ examples: > interrupt-parent = <&gic>; > interrupts = <0 26 4>, <0 27 4>; > interrupt-names = "alarm", "sec"; > - calibration = <0x198233>; > + clock-names = "rtc_clk"; > + clocks = <&rtc_clk>; > }; > }; > -- > 2.17.1
Hello Srinivas, On 30/11/2021 06:37:45+0000, Radhey Shyam Pandey wrote: > > -----Original Message----- > > From: Srinivas Neeli <srinivas.neeli@xilinx.com> > > Sent: Tuesday, November 30, 2021 11:26 AM > > To: a.zummo@towertech.it; alexandre.belloni@bootlin.com; Michal Simek > > <michals@xilinx.com>; Srinivas Goud <sgoud@xilinx.com>; Shubhrajyoti Datta > > <shubhraj@xilinx.com>; Radhey Shyam Pandey <radheys@xilinx.com> > > Cc: linux-rtc@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > > kernel@vger.kernel.org; git <git@xilinx.com>; Srinivas Neeli > > <sneeli@xilinx.com> > > Subject: [PATCH V3 1/2] dt-bindings: rtc: zynqmp: Add clock information > > > > Added clock information and deprecated calibration support. > > Better to also add some background for this change. > > > > Signed-off-by: Srinivas Neeli <srinivas.neeli@xilinx.com> > > Please add Rob and DT mailing list. > I'm indeed waiting on Rob's review... > ./scripts/get_maintainer.pl <.patch> > > --- > > Changes in V3: > > -New patch > > --- > > .../bindings/rtc/xlnx,zynqmp-rtc.yaml | 20 +++++++++---------- > > 1 file changed, 10 insertions(+), 10 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml > > b/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml > > index bdb72d3ddf2a..7e87bc1ef9df 100644 > > --- a/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml > > +++ b/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml > > @@ -26,20 +26,19 @@ properties: > > interrupts: > > minItems: 2 > > > > + clocks: > > + items: > > + - description: rtc_clk is the operating frequency of crystal. > > + > > + clock-names: > > + items: > > + - const: "rtc_clk" > > + > > interrupt-names: > > items: > > - const: alarm > > - const: sec > > > > - calibration: > > What about existing users for this property? > > - description: | > > - calibration value for 1 sec period which will > > - be programmed directly to calibration register. > > - $ref: /schemas/types.yaml#/definitions/uint32 > > - minimum: 0x1 > > - maximum: 0x1FFFFF > > - default: 0x198233 > > - I think this needs to stay to mark it as deprecated. > > required: > > - compatible > > - reg > > @@ -60,6 +59,7 @@ examples: > > interrupt-parent = <&gic>; > > interrupts = <0 26 4>, <0 27 4>; > > interrupt-names = "alarm", "sec"; > > - calibration = <0x198233>; > > + clock-names = "rtc_clk"; > > + clocks = <&rtc_clk>; > > }; > > }; > > -- > > 2.17.1 >
diff --git a/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml b/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml index bdb72d3ddf2a..7e87bc1ef9df 100644 --- a/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml +++ b/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml @@ -26,20 +26,19 @@ properties: interrupts: minItems: 2 + clocks: + items: + - description: rtc_clk is the operating frequency of crystal. + + clock-names: + items: + - const: "rtc_clk" + interrupt-names: items: - const: alarm - const: sec - calibration: - description: | - calibration value for 1 sec period which will - be programmed directly to calibration register. - $ref: /schemas/types.yaml#/definitions/uint32 - minimum: 0x1 - maximum: 0x1FFFFF - default: 0x198233 - required: - compatible - reg @@ -60,6 +59,7 @@ examples: interrupt-parent = <&gic>; interrupts = <0 26 4>, <0 27 4>; interrupt-names = "alarm", "sec"; - calibration = <0x198233>; + clock-names = "rtc_clk"; + clocks = <&rtc_clk>; }; };
Added clock information and deprecated calibration support. Signed-off-by: Srinivas Neeli <srinivas.neeli@xilinx.com> --- Changes in V3: -New patch --- .../bindings/rtc/xlnx,zynqmp-rtc.yaml | 20 +++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-)