diff mbox series

rtc: m41t80: return NULL rather than a plain 0 integer

Message ID 20210925223441.182673-1-colin.king@canonical.com
State Accepted
Headers show
Series rtc: m41t80: return NULL rather than a plain 0 integer | expand

Commit Message

Colin Ian King Sept. 25, 2021, 10:34 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

Function m41t80_sqw_register_clk returns a pointer to struct clk,
so returning a plain 0 integer isn't good practice. Fix this by
returning a NULL instead.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/rtc/rtc-m41t80.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Alexandre Belloni Oct. 1, 2021, 9:42 p.m. UTC | #1 
On Sat, 25 Sep 2021 23:34:41 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Function m41t80_sqw_register_clk returns a pointer to struct clk,
> so returning a plain 0 integer isn't good practice. Fix this by
> returning a NULL instead.
> 
> 
> [...]

Applied, thanks!

[1/1] rtc: m41t80: return NULL rather than a plain 0 integer
      commit: 7caadcfa8a7c6f8e754d982b99d959a222e7f863

Best regards,
diff mbox series

Patch

diff --git a/drivers/rtc/rtc-m41t80.c b/drivers/rtc/rtc-m41t80.c
index f736f8c22e96..6d383b629d20 100644
--- a/drivers/rtc/rtc-m41t80.c
+++ b/drivers/rtc/rtc-m41t80.c
@@ -557,7 +557,7 @@  static struct clk *m41t80_sqw_register_clk(struct m41t80_data *m41t80)
 		 * registered automatically when being referenced.
 		 */
 		of_node_put(fixed_clock);
-		return 0;
+		return NULL;
 	}
 
 	/* First disable the clock */