diff mbox series

[v2,1/3] dt-bindings: rtc: add trickle-voltage-millivolt

Message ID 20201007220506.360469-1-alexandre.belloni@bootlin.com
State Superseded
Headers show
Series [v2,1/3] dt-bindings: rtc: add trickle-voltage-millivolt | expand

Commit Message

Alexandre Belloni Oct. 7, 2020, 10:05 p.m. UTC
Some RTCs have a trickle charge that is able to output different voltages
depending on the type of the connected auxiliary power (battery, supercap,
...). Add a property allowing to specify the necessary voltage.

Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
---

Changes in v2:
 - use millivolt suffix instead of mV

 Documentation/devicetree/bindings/rtc/rtc.yaml | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Rob Herring (Arm) Oct. 13, 2020, 1:38 p.m. UTC | #1
On Thu, Oct 08, 2020 at 12:05:04AM +0200, Alexandre Belloni wrote:
> Some RTCs have a trickle charge that is able to output different voltages
> depending on the type of the connected auxiliary power (battery, supercap,
> ...). Add a property allowing to specify the necessary voltage.
> 
> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> ---
> 
> Changes in v2:
>  - use millivolt suffix instead of mV

Try again...

> 
>  Documentation/devicetree/bindings/rtc/rtc.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/rtc/rtc.yaml b/Documentation/devicetree/bindings/rtc/rtc.yaml
> index ee237b2ed66a..93f04d5e5307 100644
> --- a/Documentation/devicetree/bindings/rtc/rtc.yaml
> +++ b/Documentation/devicetree/bindings/rtc/rtc.yaml
> @@ -42,6 +42,13 @@ properties:
>        Selected resistor for trickle charger. Should be given
>        if trickle charger should be enabled.
>  
> +  trickle-voltage-mV:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description:
> +      Selected voltage for trickle charger. Should be given
> +      if trickle charger should be enabled and the trickle voltage is different
> +      from the RTC main power supply.
> +
>    wakeup-source:
>      $ref: /schemas/types.yaml#/definitions/flag
>      description:
> -- 
> 2.26.2
>
Alexandre Belloni Oct. 13, 2020, 2:42 p.m. UTC | #2
On 13/10/2020 08:38:55-0500, Rob Herring wrote:
> On Thu, Oct 08, 2020 at 12:05:04AM +0200, Alexandre Belloni wrote:
> > Some RTCs have a trickle charge that is able to output different voltages
> > depending on the type of the connected auxiliary power (battery, supercap,
> > ...). Add a property allowing to specify the necessary voltage.
> > 
> > Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> > ---
> > 
> > Changes in v2:
> >  - use millivolt suffix instead of mV
> 
> Try again...

Sorry, the change was wrongly squashed in patch 2/3, I've sent v3.

> 
> > 
> >  Documentation/devicetree/bindings/rtc/rtc.yaml | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/rtc/rtc.yaml b/Documentation/devicetree/bindings/rtc/rtc.yaml
> > index ee237b2ed66a..93f04d5e5307 100644
> > --- a/Documentation/devicetree/bindings/rtc/rtc.yaml
> > +++ b/Documentation/devicetree/bindings/rtc/rtc.yaml
> > @@ -42,6 +42,13 @@ properties:
> >        Selected resistor for trickle charger. Should be given
> >        if trickle charger should be enabled.
> >  
> > +  trickle-voltage-mV:
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +    description:
> > +      Selected voltage for trickle charger. Should be given
> > +      if trickle charger should be enabled and the trickle voltage is different
> > +      from the RTC main power supply.
> > +
> >    wakeup-source:
> >      $ref: /schemas/types.yaml#/definitions/flag
> >      description:
> > -- 
> > 2.26.2
> >
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/rtc/rtc.yaml b/Documentation/devicetree/bindings/rtc/rtc.yaml
index ee237b2ed66a..93f04d5e5307 100644
--- a/Documentation/devicetree/bindings/rtc/rtc.yaml
+++ b/Documentation/devicetree/bindings/rtc/rtc.yaml
@@ -42,6 +42,13 @@  properties:
       Selected resistor for trickle charger. Should be given
       if trickle charger should be enabled.
 
+  trickle-voltage-mV:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description:
+      Selected voltage for trickle charger. Should be given
+      if trickle charger should be enabled and the trickle voltage is different
+      from the RTC main power supply.
+
   wakeup-source:
     $ref: /schemas/types.yaml#/definitions/flag
     description: