diff mbox series

[1/5] rtc: pcf2127: fix a bug when not specify interrupts property

Message ID 20200915073213.12779-1-biwen.li@oss.nxp.com
State Accepted
Headers show
Series [1/5] rtc: pcf2127: fix a bug when not specify interrupts property | expand

Commit Message

Biwen Li (OSS) Sept. 15, 2020, 7:32 a.m. UTC
From: Biwen Li <biwen.li@nxp.com>

Fix a bug when not specify interrupts property in dts
as follows,
    rtc-pcf2127-i2c 1-0051: failed to request alarm irq
    rtc-pcf2127-i2c: probe of 1-0051 failed with error -22

Signed-off-by: Biwen Li <biwen.li@nxp.com>
---
 drivers/rtc/rtc-pcf2127.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Alexandre Belloni Sept. 15, 2020, 10:26 a.m. UTC | #1
On Tue, 15 Sep 2020 15:32:09 +0800, Biwen Li wrote:
> Fix a bug when not specify interrupts property in dts
> as follows,
>     rtc-pcf2127-i2c 1-0051: failed to request alarm irq
>     rtc-pcf2127-i2c: probe of 1-0051 failed with error -22

Applied, thanks!

[1/1] rtc: pcf2127: fix a bug when not specify interrupts property
      commit: 35425bafc772ee189e3c3790d7c672b80ba65909

Best regards,
diff mbox series

Patch

diff --git a/drivers/rtc/rtc-pcf2127.c b/drivers/rtc/rtc-pcf2127.c
index ed6316992cbb..07a5630ec841 100644
--- a/drivers/rtc/rtc-pcf2127.c
+++ b/drivers/rtc/rtc-pcf2127.c
@@ -559,7 +559,7 @@  static int pcf2127_probe(struct device *dev, struct regmap *regmap,
 	pcf2127->rtc->set_start_time = true; /* Sets actual start to 1970 */
 	pcf2127->rtc->uie_unsupported = 1;
 
-	if (alarm_irq >= 0) {
+	if (alarm_irq > 0) {
 		ret = devm_request_threaded_irq(dev, alarm_irq, NULL,
 						pcf2127_rtc_irq,
 						IRQF_TRIGGER_LOW | IRQF_ONESHOT,
@@ -570,7 +570,7 @@  static int pcf2127_probe(struct device *dev, struct regmap *regmap,
 		}
 	}
 
-	if (alarm_irq >= 0 || device_property_read_bool(dev, "wakeup-source")) {
+	if (alarm_irq > 0 || device_property_read_bool(dev, "wakeup-source")) {
 		device_init_wakeup(dev, true);
 		pcf2127->rtc->ops = &pcf2127_rtc_alrm_ops;
 	}