| Message ID | 20200905133230.1014581-8-j.neuschaefer@gmx.net |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Netronix embedded controller driver for Kobo and Tolino ebook readers | expand |
On 05/09/2020 15:32:27+0200, Jonathan Neuschäfer wrote: > Some RTCs store the year as an 8-bit number relative to the year 2000. > This results in a maximum timestamp of 2255-12-31 23:59:59. > > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net> > --- > > v2: > - New patch > --- > include/linux/rtc.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/rtc.h b/include/linux/rtc.h > index 22d1575e4991b..fcc086084a603 100644 > --- a/include/linux/rtc.h > +++ b/include/linux/rtc.h > @@ -154,6 +154,7 @@ struct rtc_device { > #define RTC_TIMESTAMP_END_2079 3471292799LL /* 2079-12-31 23:59:59 */ > #define RTC_TIMESTAMP_END_2099 4102444799LL /* 2099-12-31 23:59:59 */ > #define RTC_TIMESTAMP_END_2199 7258118399LL /* 2199-12-31 23:59:59 */ > +#define RTC_TIMESTAMP_END_2255 9025257599LL /* 2255-12-31 23:59:59 */ Honestly, I wouldn't bother adding that one unless you have examples of other RTCs endng at the same date, I'm fine having the value and comment directly in the probe function. > #define RTC_TIMESTAMP_END_9999 253402300799LL /* 9999-12-31 23:59:59 */ > > extern struct rtc_device *devm_rtc_device_register(struct device *dev, > -- > 2.28.0 >
On Tue, Sep 08, 2020 at 11:39:46AM +0200, Alexandre Belloni wrote: > On 05/09/2020 15:32:27+0200, Jonathan Neuschäfer wrote: [...] > > #define RTC_TIMESTAMP_END_2079 3471292799LL /* 2079-12-31 23:59:59 */ > > #define RTC_TIMESTAMP_END_2099 4102444799LL /* 2099-12-31 23:59:59 */ > > #define RTC_TIMESTAMP_END_2199 7258118399LL /* 2199-12-31 23:59:59 */ > > +#define RTC_TIMESTAMP_END_2255 9025257599LL /* 2255-12-31 23:59:59 */ > > Honestly, I wouldn't bother adding that one unless you have examples of > other RTCs endng at the same date, I'm fine having the value and comment > directly in the probe function. Indeed, it's the only RTC I know with this end date. I'll fold it into the driver. Thanks, Jonathan Neuschäfer
diff --git a/include/linux/rtc.h b/include/linux/rtc.h index 22d1575e4991b..fcc086084a603 100644 --- a/include/linux/rtc.h +++ b/include/linux/rtc.h @@ -154,6 +154,7 @@ struct rtc_device { #define RTC_TIMESTAMP_END_2079 3471292799LL /* 2079-12-31 23:59:59 */ #define RTC_TIMESTAMP_END_2099 4102444799LL /* 2099-12-31 23:59:59 */ #define RTC_TIMESTAMP_END_2199 7258118399LL /* 2199-12-31 23:59:59 */ +#define RTC_TIMESTAMP_END_2255 9025257599LL /* 2255-12-31 23:59:59 */ #define RTC_TIMESTAMP_END_9999 253402300799LL /* 9999-12-31 23:59:59 */ extern struct rtc_device *devm_rtc_device_register(struct device *dev,
Some RTCs store the year as an 8-bit number relative to the year 2000. This results in a maximum timestamp of 2255-12-31 23:59:59. Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net> --- v2: - New patch --- include/linux/rtc.h | 1 + 1 file changed, 1 insertion(+) -- 2.28.0