diff mbox series

[-next] rtc: fsl-ftm-alarm: remove set but not used variable 'np'

Message ID 20200324070336.59972-1-yuehaibing@huawei.com
State Not Applicable
Headers show
Series [-next] rtc: fsl-ftm-alarm: remove set but not used variable 'np' | expand

Commit Message

Yuehaibing March 24, 2020, 7:03 a.m. UTC
drivers/rtc/rtc-fsl-ftm-alarm.c: In function 'ftm_rtc_probe':
drivers/rtc/rtc-fsl-ftm-alarm.c:246:22: warning: unused variable 'np' [-Wunused-variable]
  struct device_node *np = pdev->dev.of_node;
                      ^~
commit cd49b579e705 ("rtc: fsl-ftm-alarm: enable acpi support")
left behind this, remove it.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/rtc/rtc-fsl-ftm-alarm.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Peng Ma March 25, 2020, 1:50 a.m. UTC | #1
>-----Original Message-----
>From: YueHaibing <yuehaibing@huawei.com>
>Sent: 2020年3月24日 15:04
>To: a.zummo@towertech.it; alexandre.belloni@bootlin.com
>Cc: linux-rtc@vger.kernel.org; linux-kernel@vger.kernel.org; Peng Ma
><peng.ma@nxp.com>; YueHaibing <yuehaibing@huawei.com>
>Subject: [PATCH -next] rtc: fsl-ftm-alarm: remove set but not used variable 'np'
>
>drivers/rtc/rtc-fsl-ftm-alarm.c: In function 'ftm_rtc_probe':
>drivers/rtc/rtc-fsl-ftm-alarm.c:246:22: warning: unused variable 'np'
>[-Wunused-variable]
>  struct device_node *np = pdev->dev.of_node;
>                      ^~
>commit cd49b579e705 ("rtc: fsl-ftm-alarm: enable acpi support") left behind
>this, remove it.
>
>Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>---
> drivers/rtc/rtc-fsl-ftm-alarm.c | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/drivers/rtc/rtc-fsl-ftm-alarm.c b/drivers/rtc/rtc-fsl-ftm-alarm.c index
>c572044ff06e..0f4142b35f38 100644
>--- a/drivers/rtc/rtc-fsl-ftm-alarm.c
>+++ b/drivers/rtc/rtc-fsl-ftm-alarm.c
>@@ -243,7 +243,6 @@ static const struct rtc_class_ops ftm_rtc_ops = {
>
> static int ftm_rtc_probe(struct platform_device *pdev)  {
>-	struct device_node *np = pdev->dev.of_node;
[Peng Ma] Hi, HaiBing,

Thanks for your patch, this patch has already in upstream(https://lore.kernel.org/patchwork/patch/1214014/)

Best Regards,
Peng
> 	int irq;
> 	int ret;
> 	struct ftm_rtc *rtc;
>--
>2.17.1
>
diff mbox series

Patch

diff --git a/drivers/rtc/rtc-fsl-ftm-alarm.c b/drivers/rtc/rtc-fsl-ftm-alarm.c
index c572044ff06e..0f4142b35f38 100644
--- a/drivers/rtc/rtc-fsl-ftm-alarm.c
+++ b/drivers/rtc/rtc-fsl-ftm-alarm.c
@@ -243,7 +243,6 @@  static const struct rtc_class_ops ftm_rtc_ops = {
 
 static int ftm_rtc_probe(struct platform_device *pdev)
 {
-	struct device_node *np = pdev->dev.of_node;
 	int irq;
 	int ret;
 	struct ftm_rtc *rtc;