diff mbox series

[17/28] dt-bindings: mmc: Fix up clk-phase-sd-hs in an example

Message ID 20200317093922.20785-18-lkundrak@v3.sk
State Not Applicable
Headers show
Series DT: Improve validation for Marvell SoCs | expand

Commit Message

Lubomir Rintel March 17, 2020, 9:39 a.m. UTC
This way the validator can know that the two cells constitute a singlej
pair of clock phase degrees value, not separate items Otherwise it is
unhappy:

  mmc-controller.example.dt.yaml: mmc@ab000000: clk-phase-sd-hs:0:
      [63] is too short
  mmc-controller.example.dt.yaml: mmc@ab000000: clk-phase-sd-hs:1:
      [72] is too short

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
---
 Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Sergei Shtylyov March 17, 2020, 10:04 a.m. UTC | #1
Hello!

On 17.03.2020 12:39, Lubomir Rintel wrote:

> This way the validator can know that the two cells constitute a singlej

    Single?

> pair of clock phase degrees value, not separate items Otherwise it is

    Forgot a period after "items"?

> unhappy:
> 
>    mmc-controller.example.dt.yaml: mmc@ab000000: clk-phase-sd-hs:0:
>        [63] is too short
>    mmc-controller.example.dt.yaml: mmc@ab000000: clk-phase-sd-hs:1:
>        [72] is too short
> 
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
[...]

MBR, Sergei
Rob Herring March 27, 2020, 7:08 p.m. UTC | #2
On Tue, Mar 17, 2020 at 10:39:11AM +0100, Lubomir Rintel wrote:
> This way the validator can know that the two cells constitute a singlej
> pair of clock phase degrees value, not separate items Otherwise it is
> unhappy:
> 
>   mmc-controller.example.dt.yaml: mmc@ab000000: clk-phase-sd-hs:0:
>       [63] is too short
>   mmc-controller.example.dt.yaml: mmc@ab000000: clk-phase-sd-hs:1:
>       [72] is too short

I'm going to fix this in the tools to allow either form. 

> 
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> ---
>  Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> index 8fded83c519ad..c9384ed685b8f 100644
> --- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> @@ -363,7 +363,7 @@ examples:
>          keep-power-in-suspend;
>          wakeup-source;
>          mmc-pwrseq = <&sdhci0_pwrseq>;
> -        clk-phase-sd-hs = <63>, <72>;
> +        clk-phase-sd-hs = <63 72>;
>      };
>  
>    - |
> -- 
> 2.25.1
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
index 8fded83c519ad..c9384ed685b8f 100644
--- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
+++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
@@ -363,7 +363,7 @@  examples:
         keep-power-in-suspend;
         wakeup-source;
         mmc-pwrseq = <&sdhci0_pwrseq>;
-        clk-phase-sd-hs = <63>, <72>;
+        clk-phase-sd-hs = <63 72>;
     };
 
   - |