| Message ID | 20190704085542.48180-1-yuehaibing@huawei.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | rtc: pcf2123: Fix build error | expand |
On 04/07/2019 16:55:42+0800, YueHaibing wrote: > If REGMAP_SPI is m and RTC_DRV_PCF2123 is y, > > drivers/rtc/rtc-pcf2123.o: In function `pcf2123_probe': > rtc-pcf2123.c:(.text+0xb2b): undefined reference to `__devm_regmap_init_spi' > > Select REGMAP_SPI as RTC_DRV_DS1347 driver does. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Fixes: 790d033933b8 ("rtc: pcf2123: port to regmap") > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > drivers/rtc/Kconfig | 1 + > 1 file changed, 1 insertion(+) > Applied, thanks.
diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig index 3bfc04a..e72f65b 100644 --- a/drivers/rtc/Kconfig +++ b/drivers/rtc/Kconfig @@ -820,6 +820,7 @@ config RTC_DRV_MAX6902 config RTC_DRV_PCF2123 tristate "NXP PCF2123" + select REGMAP_SPI help If you say yes here you get support for the NXP PCF2123 RTC chip.
If REGMAP_SPI is m and RTC_DRV_PCF2123 is y, drivers/rtc/rtc-pcf2123.o: In function `pcf2123_probe': rtc-pcf2123.c:(.text+0xb2b): undefined reference to `__devm_regmap_init_spi' Select REGMAP_SPI as RTC_DRV_DS1347 driver does. Reported-by: Hulk Robot <hulkci@huawei.com> Fixes: 790d033933b8 ("rtc: pcf2123: port to regmap") Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/rtc/Kconfig | 1 + 1 file changed, 1 insertion(+)