From patchwork Mon May 28 07:50:32 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 921354 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-rtc-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="UJhebia9"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40vTYf2HdRz9s0q for ; Mon, 28 May 2018 17:50:46 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753952AbeE1Hup (ORCPT ); Mon, 28 May 2018 03:50:45 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:44151 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753734AbeE1Huo (ORCPT ); Mon, 28 May 2018 03:50:44 -0400 Received: by mail-pf0-f196.google.com with SMTP id q22-v6so5460311pff.11 for ; Mon, 28 May 2018 00:50:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id; bh=9uGGnFPdQiF6CA4+TGlo75hdFg/j0fdlpBsU4TVW7RA=; b=UJhebia9CyPbKhQzYIqBRrRfCi1djgtFM7G5Df6MW31wHBtP3lJ9jnqe7aSByUix+o vT8laeqvq5d1nAep1ReUqFZFNxqOTyHdzcORkWGh8caRcna3xDyKNJuBsYzq65DPb2iE 4fYSJ5ntkNXAJLzKS93CjTIFxCzV3qpC2c24U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=9uGGnFPdQiF6CA4+TGlo75hdFg/j0fdlpBsU4TVW7RA=; b=ZnGG0ON7JEDRMdZ/GLJrA8SQ8MSY6tPoj6hVRlwa2soVn2AhX+dpfaPhLsCS3FPZ7p Y0q0H/5mxjlCwqY2bEiFj7tjJW8OAb4lgbgvXCS/sYB9cRLxcdQMEgdwEUVjYz7fKlPG W3OP7gBe/4Lt6fY1f3pmeU/k7ktkN9yxk4iv6c70xakXbWpVuK7vw3kohAcPdduHfVbE PeqJNmgAB9QwEosCt9VEl9jPYahZTufBXZaUVm/MPUMYWKNwitbDjYumnNDRoCooenAK fab3h8KaP6l+or2NlLiRIT/uj2m5Z6xcQGur8FKq7Q9stQ1HlORUHA0xaEnW73ubEj6o q8gQ== X-Gm-Message-State: ALKqPwd2PkZF4+f6whGdPa0Ek+1LEcl/RKvKH6LG5uIfk9dB2eqhUCEi Gi8rtFfP6pxn7iV8RCYYPL0n9w== X-Google-Smtp-Source: AB8JxZo9wZz1QSqFUhw8Fpff5iTc6ucVIO/CV3ZbOQtaS38XcBsW2iTGerYATcqp9p4P1gczcRNXrQ== X-Received: by 2002:a62:cd45:: with SMTP id o66-v6mr12473928pfg.250.1527493843584; Mon, 28 May 2018 00:50:43 -0700 (PDT) Received: from localhost.localdomain ([183.82.229.215]) by smtp.gmail.com with ESMTPSA id 65-v6sm58128058pgj.22.2018.05.28.00.50.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 28 May 2018 00:50:43 -0700 (PDT) From: Jagan Teki To: Maxime Ripard , Alessandro Zummo , Alexandre Belloni , Chen-Yu Tsai , Michael Trimarchi Cc: linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, Jagan Teki Subject: [PATCH] rtc: sun6i: Fix bit_idx value for clk_register_gate Date: Mon, 28 May 2018 13:20:32 +0530 Message-Id: <20180528075032.6769-1-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.14.3 Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org From: Michael Trimarchi clk-gate core will take bit_idx through clk_register_gate and then do clk_gate_ops by using BIT(bit_idx), but rtc-sun6i is passing bit_idx as BIT(bit_idx) it becomes BIT(BIT(bit_idx) which is wrong and eventually external gate clock is not enabling. This patch fixed by passing bit index and the original change introduced from below commit. "rtc: sun6i: Add support for the external oscillator gate" (sha1: 17ecd246414b3a0fe0cb248c86977a8bda465b7b) Signed-off-by: Michael Trimarchi Signed-off-by: Jagan Teki --- drivers/rtc/rtc-sun6i.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-sun6i.c b/drivers/rtc/rtc-sun6i.c index 2e6fb275acc8..a66f40c96582 100644 --- a/drivers/rtc/rtc-sun6i.c +++ b/drivers/rtc/rtc-sun6i.c @@ -74,7 +74,7 @@ #define SUN6I_ALARM_CONFIG_WAKEUP BIT(0) #define SUN6I_LOSC_OUT_GATING 0x0060 -#define SUN6I_LOSC_OUT_GATING_EN BIT(0) +#define SUN6I_LOSC_OUT_GATING_EN 0 /* * Get date values