| Message ID | 20180123121801.4214-3-m.grzeschik@pengutronix.de |
|---|---|
| State | Rejected |
| Headers | show |
| Series | rtc: isl1208: fixes, documentation and isl1219 support | expand |
On Tue, Jan 23, 2018 at 01:17:59PM +0100, Michael Grzeschik wrote: > From: Denis Osterland <Denis.Osterland@diehl.com> > > Wrote documentation for ISL1208, ISL1218 device tree > binding with short examples. > > Signed-off-by: Denis Osterland <Denis.Osterland@diehl.com> > Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de> > --- > .../devicetree/bindings/rtc/intersil,isl1208.txt | 35 ++++++++++++++++++++++ > 1 file changed, 35 insertions(+) > create mode 100644 Documentation/devicetree/bindings/rtc/intersil,isl1208.txt A couple of nits, otherwise: Reviewed-by: Rob Herring <robh@kernel.org> > > diff --git a/Documentation/devicetree/bindings/rtc/intersil,isl1208.txt b/Documentation/devicetree/bindings/rtc/intersil,isl1208.txt > new file mode 100644 > index 0000000000000..a54e99feae1ca > --- /dev/null > +++ b/Documentation/devicetree/bindings/rtc/intersil,isl1208.txt > @@ -0,0 +1,35 @@ > +Intersil ISL1208, ISL1218 I2C RTC/Alarm chip > + > +ISL1208 is a trivial I2C device (it has simple device tree bindings, > +consisting of a compatible field, an address and possibly an interrupt > +line). > + > +Required properties supported by the device: > + > + - "compatible": must be one of > + "isil,isl1208" > + "isil,isl1218" > + - "reg": I2C bus address of the device > + > +Optional properties: > + > + - "interrupt-parent", "interrupts", "interrupts-extended": > + for passing the interrupt line of the SoC connected to #IRQ pin > + of the RTC chip. > + > + > +Example isl1208 node without #IRQ pin connected: > + > + isl1208: isl1208@68 { rtc@68 > + compatible = "isil,isl1208"; > + reg = <0x68>; > + }; > + > +Example isl1208 node with #IRQ pin connected to SoC gpio1 pin 12: > + > + isl1208: isl1208@68 { rtc@68 > + compatible = "isil,isl1208"; > + reg = <0x68>; > + interrupt-parent = <&gpio1>; > + interrupts = <12 IRQ_TYPE_EDGE_FALLING>; > + }; > -- > 2.11.0 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On 23/01/2018 at 13:17:59 +0100, Michael Grzeschik wrote: > From: Denis Osterland <Denis.Osterland@diehl.com> > > Wrote documentation for ISL1208, ISL1218 device tree > binding with short examples. > This binding is already in Documentation/devicetree/bindings/trivial-devices.txt, no need to duplicate. > Signed-off-by: Denis Osterland <Denis.Osterland@diehl.com> > Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de> > --- > .../devicetree/bindings/rtc/intersil,isl1208.txt | 35 ++++++++++++++++++++++ > 1 file changed, 35 insertions(+) > create mode 100644 Documentation/devicetree/bindings/rtc/intersil,isl1208.txt > > diff --git a/Documentation/devicetree/bindings/rtc/intersil,isl1208.txt b/Documentation/devicetree/bindings/rtc/intersil,isl1208.txt > new file mode 100644 > index 0000000000000..a54e99feae1ca > --- /dev/null > +++ b/Documentation/devicetree/bindings/rtc/intersil,isl1208.txt > @@ -0,0 +1,35 @@ > +Intersil ISL1208, ISL1218 I2C RTC/Alarm chip > + > +ISL1208 is a trivial I2C device (it has simple device tree bindings, > +consisting of a compatible field, an address and possibly an interrupt > +line). > + > +Required properties supported by the device: > + > + - "compatible": must be one of > + "isil,isl1208" > + "isil,isl1218" > + - "reg": I2C bus address of the device > + > +Optional properties: > + > + - "interrupt-parent", "interrupts", "interrupts-extended": > + for passing the interrupt line of the SoC connected to #IRQ pin > + of the RTC chip. > + > + > +Example isl1208 node without #IRQ pin connected: > + > + isl1208: isl1208@68 { > + compatible = "isil,isl1208"; > + reg = <0x68>; > + }; > + > +Example isl1208 node with #IRQ pin connected to SoC gpio1 pin 12: > + > + isl1208: isl1208@68 { > + compatible = "isil,isl1208"; > + reg = <0x68>; > + interrupt-parent = <&gpio1>; > + interrupts = <12 IRQ_TYPE_EDGE_FALLING>; > + }; > -- > 2.11.0 >
diff --git a/Documentation/devicetree/bindings/rtc/intersil,isl1208.txt b/Documentation/devicetree/bindings/rtc/intersil,isl1208.txt new file mode 100644 index 0000000000000..a54e99feae1ca --- /dev/null +++ b/Documentation/devicetree/bindings/rtc/intersil,isl1208.txt @@ -0,0 +1,35 @@ +Intersil ISL1208, ISL1218 I2C RTC/Alarm chip + +ISL1208 is a trivial I2C device (it has simple device tree bindings, +consisting of a compatible field, an address and possibly an interrupt +line). + +Required properties supported by the device: + + - "compatible": must be one of + "isil,isl1208" + "isil,isl1218" + - "reg": I2C bus address of the device + +Optional properties: + + - "interrupt-parent", "interrupts", "interrupts-extended": + for passing the interrupt line of the SoC connected to #IRQ pin + of the RTC chip. + + +Example isl1208 node without #IRQ pin connected: + + isl1208: isl1208@68 { + compatible = "isil,isl1208"; + reg = <0x68>; + }; + +Example isl1208 node with #IRQ pin connected to SoC gpio1 pin 12: + + isl1208: isl1208@68 { + compatible = "isil,isl1208"; + reg = <0x68>; + interrupt-parent = <&gpio1>; + interrupts = <12 IRQ_TYPE_EDGE_FALLING>; + };