From patchwork Tue Mar 1 14:55:58 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thierry Reding X-Patchwork-Id: 590561 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-lf0-x237.google.com (mail-lf0-x237.google.com [IPv6:2a00:1450:4010:c07::237]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 5EC41140BB7 for ; Wed, 2 Mar 2016 01:56:04 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.b=cbdUwIvj; dkim-atps=neutral Received: by mail-lf0-x237.google.com with SMTP id o68sf23254125lfe.1 for ; Tue, 01 Mar 2016 06:56:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:x-spam-checked-in-group:list-post:list-help:list-archive :sender:list-subscribe:list-unsubscribe; bh=haR2dshLsyWzXqhZtK5X/hinbf92wc5WKLBKmnd0yrA=; b=cbdUwIvjGWI3RDNs50XsmhWBcCecWIWxQn0svFThMyKboEOxgIze2H4FIuD9EZRyHx KvEls9qyqvp8z+fVKm2Rg9TiMjr/KmP0ipdJmyCEG36xjdcuDMuuP84OoShUkaMxSyIb Txr5EICvhYz8HOP9z8n8Z9ATHN9D2BTJn/kWU4Mz2ydJuJkeSdUF6UEr3fyhA+63Ngev HnE4FSBvG6vCR3/qUlCQhQNpbptPjHjsFiuDyz9TDePJfM0WFeiD8Z0YwykV9YwAQdtG 3opOeqOLlsaO6ou02GYO40S3D3dhC83kFWDzDERw9WPieKclfoEaR+JDHlTwanEisBUf Zk9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:x-spam-checked-in-group:list-post :list-help:list-archive:sender:list-subscribe:list-unsubscribe; bh=haR2dshLsyWzXqhZtK5X/hinbf92wc5WKLBKmnd0yrA=; b=H3ofEpD1lkBEghpn9CEZRAlWnTQUmnWIlP4/1CwOUWyOwLIu1ucmT+hHLlPXa779hN pqQQ4G65S38/hRQDoHuUAHAEA3PRiq/u7Rzu4RbpsWEAO0FBq5mKV1+875xk24zw6zKp 4+fQNg4LjTCMHlp1E/whZ9FCEpcCsKTNpVgU1QxBZDTh1+ktHCSRHPvK1hqN5h/Snvzs JAIaXUDC/E4UBZxXc+GAAgOY2Ba4gTmKS+mqbeCa4VXDj4JlOm693lFTkEFkgImtXN6a cEgMeRpYjB+z0LuiGLgkbeb7X/RjY83nPEmzncj9YkCzeSmQWAXOj039DYFRIzQQ2ZWO EZYQ== X-Gm-Message-State: AD7BkJKAZEWoFcVa0RF9XpeAvpTrLkgjg7ktBCMgyij1jit5RlUmIF/Hb8XMQ4YS7g7ZIQ== X-Received: by 10.28.7.21 with SMTP id 21mr12735wmh.5.1456844161398; Tue, 01 Mar 2016 06:56:01 -0800 (PST) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.28.176.4 with SMTP id z4ls173931wme.12.canary; Tue, 01 Mar 2016 06:56:00 -0800 (PST) X-Received: by 10.28.225.8 with SMTP id y8mr548044wmg.7.1456844160972; Tue, 01 Mar 2016 06:56:00 -0800 (PST) Received: from mail-wm0-x233.google.com (mail-wm0-x233.google.com. [2a00:1450:400c:c09::233]) by gmr-mx.google.com with ESMTPS id s141si15609wmd.1.2016.03.01.06.56.00 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Mar 2016 06:56:00 -0800 (PST) Received-SPF: pass (google.com: domain of thierry.reding@gmail.com designates 2a00:1450:400c:c09::233 as permitted sender) client-ip=2a00:1450:400c:c09::233; Received: by mail-wm0-x233.google.com with SMTP id p65so37123239wmp.0 for ; Tue, 01 Mar 2016 06:56:00 -0800 (PST) X-Received: by 10.28.143.9 with SMTP id r9mr4044770wmd.37.1456844160801; Tue, 01 Mar 2016 06:56:00 -0800 (PST) Received: from localhost (port-9484.pppoe.wtnet.de. [84.46.37.49]) by smtp.gmail.com with ESMTPSA id o16sm21229900wjr.9.2016.03.01.06.55.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Mar 2016 06:55:59 -0800 (PST) Date: Tue, 1 Mar 2016 15:55:58 +0100 From: Thierry Reding To: Sudip Mukherjee Cc: Alessandro Zummo , Alexandre Belloni , linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com Subject: [rtc-linux] Re: [PATCH] rtc: rtc-vr41xx: remove unused function Message-ID: <20160301145558.GC26201@ulmo> References: <1456836981-30999-1-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1456836981-30999-1-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Original-Sender: thierry.reding@gmail.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of thierry.reding@gmail.com designates 2a00:1450:400c:c09::233 as permitted sender) smtp.mailfrom=thierry.reding@gmail.com; dkim=pass header.i=@gmail.com; dmarc=pass (p=NONE dis=NONE) header.from=gmail.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: rtc-linux@googlegroups.com X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On Tue, Mar 01, 2016 at 06:26:21PM +0530, Sudip Mukherjee wrote: > We were getting build warning about: > drivers/rtc/rtc-vr41xx.c:228:12: warning: ‘vr41xx_rtc_alarm_irq_enable’ > defined but not used > > The function vr41xx_rtc_alarm_irq_enable() was not used anywhere. > > Signed-off-by: Sudip Mukherjee > --- > > build log is at: > https://travis-ci.org/sudipm-mukherjee/parport/jobs/112780206 > > drivers/rtc/rtc-vr41xx.c | 18 ------------------ > 1 file changed, 18 deletions(-) > > diff --git a/drivers/rtc/rtc-vr41xx.c b/drivers/rtc/rtc-vr41xx.c > index f64c282..68cb63e 100644 > --- a/drivers/rtc/rtc-vr41xx.c > +++ b/drivers/rtc/rtc-vr41xx.c > @@ -225,24 +225,6 @@ static int vr41xx_rtc_ioctl(struct device *dev, unsigned int cmd, unsigned long > return 0; > } > > -static int vr41xx_rtc_alarm_irq_enable(struct device *dev, unsigned int enabled) > -{ > - spin_lock_irq(&rtc_lock); > - if (enabled) { > - if (!alarm_enabled) { > - enable_irq(aie_irq); > - alarm_enabled = 1; > - } > - } else { > - if (alarm_enabled) { > - disable_irq(aie_irq); > - alarm_enabled = 0; > - } > - } > - spin_unlock_irq(&rtc_lock); > - return 0; > -} > - I don't think it's supposed to be unused, rather back at the time it simply wasn't hooked up to the rtc_class_ops. Here's what I used. Thierry --- >8 --- From 91c39e61b10551f8fbdb55cadbc29a104071bea2 Mon Sep 17 00:00:00 2001 From: Thierry Reding Date: Tue, 1 Mar 2016 15:50:25 +0100 Subject: [PATCH] rtc: vr41xx: Hook up ->alarm_irq_enable() The vr41xx_rtc_alarm_irq_enable() function was extracted in commit 16380c153a69 ("RTC: Convert rtc drivers to use the alarm_irq_enable method") from a more generic IOCTL handler. However the function was never hooked up to the struct rtc_class_ops to which a new callback had earlier been added for this purpose in commit 099e657625e8 ("rtc: add alarm/update irq interfaces"). Signed-off-by: Thierry Reding --- drivers/rtc/rtc-vr41xx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/rtc/rtc-vr41xx.c b/drivers/rtc/rtc-vr41xx.c index f64c282275b3..898fdd03668d 100644 --- a/drivers/rtc/rtc-vr41xx.c +++ b/drivers/rtc/rtc-vr41xx.c @@ -278,6 +278,7 @@ static const struct rtc_class_ops vr41xx_rtc_ops = { .set_time = vr41xx_rtc_set_time, .read_alarm = vr41xx_rtc_read_alarm, .set_alarm = vr41xx_rtc_set_alarm, + .alarm_irq_enable = vr41xx_rtc_alarm_irq_enable, }; static int rtc_probe(struct platform_device *pdev)