From patchwork Fri Aug 14 18:44:02 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bibek Basu X-Patchwork-Id: 507557 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-lb0-x23e.google.com (mail-lb0-x23e.google.com [IPv6:2a00:1450:4010:c04::23e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 8EF20140187 for ; Sat, 15 Aug 2015 04:46:53 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.b=C/sxZpDP; dkim-atps=neutral Received: by lbck9 with SMTP id k9sf19896829lbc.1 for ; Fri, 14 Aug 2015 11:46:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:in-reply-to:user-agent:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:x-spam-checked-in-group:list-post:list-help:list-archive :sender:list-subscribe:list-unsubscribe; bh=LHC143fkRHj8iqcLdqnYnQdOaqeSKA+uL9IsGxOcR0g=; b=C/sxZpDPAVnlNd9Bw+SGLn6JDaGtp4C4GhfGuxmXZa1Sg8wSzzeUDGGL1fJ7/Tkjv3 U28SdvSpKplDMOa849pzbfy5eP2cMCUB5QSa83mlIocgYrsM+lF/UOl0DQnLBltcOSUv gtAQFf/pSrQYKRgCjYRrEMgu7MaIsU3mKxvrAm9J/bMJohi1xdFUGweIzGZ4moJzuDa3 pg38PHy9wDfiStczflj8aJ+bUntetdrotwHfdytfSjr6Fl0b3HedhgkZJvPLJjAlfwu2 ZXyWXeGetkTfGC3ij+C3S5ThbagbcqOkJXirKoNkjIe7C3rL1fbbsCdmegP5ePZ2FePu HDNw== X-Received: by 10.180.108.133 with SMTP id hk5mr16936wib.15.1439578010917; Fri, 14 Aug 2015 11:46:50 -0700 (PDT) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.180.8.166 with SMTP id s6ls148980wia.39.canary; Fri, 14 Aug 2015 11:46:50 -0700 (PDT) X-Received: by 10.180.82.101 with SMTP id h5mr1343597wiy.1.1439578010352; Fri, 14 Aug 2015 11:46:50 -0700 (PDT) Received: from mx02.posteo.de (mx02.posteo.de. [89.146.194.165]) by gmr-mx.google.com with ESMTPS id jv9si113914wid.0.2015.08.14.11.46.50 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Aug 2015 11:46:50 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning bbasu@nvidia.com does not designate 89.146.194.165 as permitted sender) client-ip=89.146.194.165; Received: from dovecot04.posteo.de (unknown [185.67.36.27]) by mx02.posteo.de (Postfix) with ESMTPS id 7834825ACC38; Fri, 14 Aug 2015 20:46:48 +0200 (CEST) Received: from mail.posteo.de (localhost [127.0.0.1]) by dovecot04.posteo.de (Postfix) with ESMTPSA id 3mtDJS2XTkzFpVq; Fri, 14 Aug 2015 20:46:48 +0200 (CEST) Date: Fri, 14 Aug 2015 20:44:02 +0200 From: Bibek Basu To: rtc-linux@googlegroups.com Cc: Alexandre Belloni Subject: [rtc-linux] [PATCH v2] drivers/rtc/rtc-as3722: correct month value Message-ID: <20150814184402.GA8953@nyan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20150814084515.GH22269@piout.net> User-Agent: Mutt/1.5.23 (2014-03-12) X-Original-Sender: bbasu@nvidia.com X-Original-Authentication-Results: gmr-mx.google.com; spf=softfail (google.com: domain of transitioning bbasu@nvidia.com does not designate 89.146.194.165 as permitted sender) smtp.mailfrom=bbasu@nvidia.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: rtc-linux@googlegroups.com X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , The RTCmonth value is 1-indexed, but the kernel assumes it is 0-indexed. This may result in the RTC not rolling over correctly. Signed-off-by: Bibek Basu Signed-off-by: Felix Janda --- v1 -> v2: Correct attribution and use original commit message --- drivers/rtc/rtc-as3722.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-as3722.c b/drivers/rtc/rtc-as3722.c index 9f38eda..56cc582 100644 --- a/drivers/rtc/rtc-as3722.c +++ b/drivers/rtc/rtc-as3722.c @@ -45,7 +45,7 @@ static void as3722_time_to_reg(u8 *rbuff, struct rtc_time *tm) rbuff[1] = bin2bcd(tm->tm_min); rbuff[2] = bin2bcd(tm->tm_hour); rbuff[3] = bin2bcd(tm->tm_mday); - rbuff[4] = bin2bcd(tm->tm_mon); + rbuff[4] = bin2bcd(tm->tm_mon + 1); rbuff[5] = bin2bcd(tm->tm_year - (AS3722_RTC_START_YEAR - 1900)); } @@ -55,7 +55,7 @@ static void as3722_reg_to_time(u8 *rbuff, struct rtc_time *tm) tm->tm_min = bcd2bin(rbuff[1] & 0x7F); tm->tm_hour = bcd2bin(rbuff[2] & 0x3F); tm->tm_mday = bcd2bin(rbuff[3] & 0x3F); - tm->tm_mon = bcd2bin(rbuff[4] & 0x1F); + tm->tm_mon = bcd2bin(rbuff[4] & 0x1F) - 1; tm->tm_year = (AS3722_RTC_START_YEAR - 1900) + bcd2bin(rbuff[5] & 0x7F); return; }