From patchwork Tue Feb 11 12:37:26 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anthony Olech X-Patchwork-Id: 319326 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-ee0-x238.google.com (mail-ee0-x238.google.com [IPv6:2a00:1450:4013:c00::238]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 9A1D32C009B for ; Wed, 12 Feb 2014 03:10:25 +1100 (EST) Received: by mail-ee0-f56.google.com with SMTP id b57sf576594eek.11 for ; Tue, 11 Feb 2014 08:10:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=message-id:from:date:subject:to:cc:mime-version:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:list-post:list-help:list-archive:sender:list-subscribe :list-unsubscribe:content-type; bh=DMC0xWn00lc9Tld8hG5VKVqJm7B0i1wjZzXq1qrEgGw=; b=j+cOJG6/VrSmjSamQnXsWN3o04jNavgziRbKomEnB1NinGzK8MaG2ZIg8R+qd85XdL BmS18fCSBD5WSRjufxe+bSfNYWxxTyJ6bYbD/xerydIdY/1m5UP1OKP7TkaSF8+OHzqK A3OhNGk9gJ2Y7bYGDyZ1uwQKaqdn4NFrc1boTb96qX7+BE8Sz2/RBmUCPfS5UUGzuT6c 6LHQ99Vz+dHI3X6MNDV4HWOUlZeCDXnkXcADtUbY31YDNBqut3lVQGtHq4UxBfVsxP99 MFX+h+KBbRycVfWwtDxRmnYCh1DpaXgLaJE09dv0xSIukgQly3SZxhsutZU/IENMRbPK po5A== X-Received: by 10.152.1.102 with SMTP id 6mr19430lal.30.1392135021025; Tue, 11 Feb 2014 08:10:21 -0800 (PST) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.152.27.199 with SMTP id v7ls181061lag.59.gmail; Tue, 11 Feb 2014 08:10:20 -0800 (PST) X-Received: by 10.152.201.198 with SMTP id kc6mr156852lac.2.1392135020599; Tue, 11 Feb 2014 08:10:20 -0800 (PST) Received: from mail1.bemta14.messagelabs.com (mail1.bemta14.messagelabs.com. [193.109.254.112]) by gmr-mx.google.com with ESMTPS id t10si913105wiw.3.2014.02.11.08.10.20 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 11 Feb 2014 08:10:20 -0800 (PST) Received-SPF: neutral (google.com: 193.109.254.112 is neither permitted nor denied by best guess record for domain of anthony.olech.opensource@diasemi.com) client-ip=193.109.254.112; Received: from [85.158.140.195:51049] by server-8.bemta-14.messagelabs.com id EF/BF-18529-C6B4AF25; Tue, 11 Feb 2014 16:10:20 +0000 X-Env-Sender: anthony.olech.opensource@diasemi.com X-Msg-Ref: server-13.tower-193.messagelabs.com!1392135018!11843342!1 X-Originating-IP: [82.210.246.133] X-StarScan-Received: X-StarScan-Version: 6.9.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 24768 invoked from network); 11 Feb 2014 16:10:18 -0000 Received: from mailrelay1.diasemi.com (HELO NB-EX-CASHUB01.diasemi.com) (82.210.246.133) by server-13.tower-193.messagelabs.com with AES128-SHA encrypted SMTP; 11 Feb 2014 16:10:18 -0000 Received: from mailrelay1.diasemi.com (10.1.17.243) by NB-EX-CASHUB01.diasemi.com (10.1.16.140) with Microsoft SMTP Server id 14.2.309.2; Tue, 11 Feb 2014 17:10:17 +0100 Received: from swsrvapps-02.lan (Not Verified[10.20.27.23]) by mailrelay1.diasemi.com with ESMTP Gateway id ; Tue, 11 Feb 2014 17:10:17 +0100 Received: from swsrvapps-02.lan (localhost [127.0.0.1]) by swsrvapps-02.lan (8.14.4/8.14.4/Debian-2ubuntu2.1) with ESMTP id s1BGAGmW056464; Tue, 11 Feb 2014 16:10:16 GMT Received: (from aolech@localhost) by swsrvapps-02.lan (8.14.4/8.14.4/Submit) id s1BGAG67056463; Tue, 11 Feb 2014 16:10:16 GMT Message-ID: <201402111610.s1BGAG67056463@swsrvapps-02.lan> X-Authentication-Warning: swsrvapps-02.lan: aolech set sender to anthony.olech.opensource@diasemi.com using -f From: Anthony Olech Date: Tue, 11 Feb 2014 12:37:26 +0000 Subject: [rtc-linux] [PATCH V1] rtc: da9052: Remove redundant private structure field To: Alessandro Zummo CC: , , David Dajun Chen MIME-Version: 1.0 X-Original-Sender: anthony.olech.opensource@diasemi.com X-Original-Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 193.109.254.112 is neither permitted nor denied by best guess record for domain of anthony.olech.opensource@diasemi.com) smtp.mail=anthony.olech.opensource@diasemi.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , remove redundant irq field in private rtc structure. Signed-off-by: Anthony Olech Acked-by: David Dajun Chen --- This patch is relative to linux-next repository tag next-20140210 This issue was found when doing a code review whilst investigating a different problem. This patch has been test compiled on an amd64 server for both x86 and arm targets. This patch has been spot verified using an SMDK6410 platform fly-wired to a Dialog da9053 EVB. drivers/rtc/rtc-da9052.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/rtc/rtc-da9052.c b/drivers/rtc/rtc-da9052.c index 4385ca4..a1cbf64 100644 --- a/drivers/rtc/rtc-da9052.c +++ b/drivers/rtc/rtc-da9052.c @@ -26,7 +26,6 @@ struct da9052_rtc { struct rtc_device *rtc; struct da9052 *da9052; - int irq; }; static int da9052_rtc_enable_alarm(struct da9052 *da9052, bool enable) @@ -240,8 +239,7 @@ static int da9052_rtc_probe(struct platform_device *pdev) rtc->da9052 = dev_get_drvdata(pdev->dev.parent); platform_set_drvdata(pdev, rtc); - rtc->irq = DA9052_IRQ_ALARM; - ret = da9052_request_irq(rtc->da9052, rtc->irq, "ALM", + ret = da9052_request_irq(rtc->da9052, DA9052_IRQ_ALARM, "ALM", da9052_rtc_irq, rtc); if (ret != 0) { rtc_err(rtc->da9052, "irq registration failed: %d\n", ret);