From patchwork Wed Mar 9 12:44:39 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Cox X-Patchwork-Id: 86105 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-ww0-f56.google.com (mail-ww0-f56.google.com [74.125.82.56]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id 6DBCAB6FA4 for ; Thu, 10 Mar 2011 00:05:30 +1100 (EST) Received: by wwb22 with SMTP id 22sf474593wwb.11 for ; Wed, 09 Mar 2011 05:05:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=beta; h=domainkey-signature:x-beenthere:received-spf:from:subject:to:date :message-id:user-agent:mime-version:x-original-sender :x-original-authentication-results:x-google-group-id:reply-to :precedence:mailing-list:list-id:list-post:list-help:list-archive :sender:list-subscribe:list-unsubscribe:content-type; bh=NSei9eFXoPPVJK5NghstoDGn+zdNusj9nwf4wouR7KI=; b=ZdQB6U5Ep8fKbkRjppaBNnfUF6ALJfq46IAiByu6+QYS5LPvIG0z1huff17IBUrGMp M2T6DR3zKzozreerSXKaZ8qLFV5h60XovmBsqkWWTlWgx1DEfRiYqoNZ/ZVX4fEFxp0U BMDPsNpsMALJuIa/vZxK5WwPgd5utjuHpuqZI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlegroups.com; s=beta; h=x-beenthere:received-spf:from:subject:to:date:message-id:user-agent :mime-version:x-original-sender:x-original-authentication-results :x-google-group-id:reply-to:precedence:mailing-list:list-id :list-post:list-help:list-archive:sender:list-subscribe :list-unsubscribe:content-type; b=I724sADTa7zHuIp23wCKOdEcKj/4MKMKNYy7KiTAKlVhXpcV5YDpmRaKOm9J1/kyCP /a+U/AU8aPODCVEc7jN3g0DiHtjlRc294rvIMKimLo/YCH0/idxtsk8p+FxHzhHfMqxq SoUoY9h2XYoVYZXP2/r9lAzICSYPVpNK4pMo8= Received: by 10.216.24.31 with SMTP id w31mr929239wew.19.1299675924040; Wed, 09 Mar 2011 05:05:24 -0800 (PST) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.227.28.219 with SMTP id n27ls2149028wbc.2.p; Wed, 09 Mar 2011 05:05:23 -0800 (PST) Received: by 10.227.151.17 with SMTP id a17mr354881wbw.25.1299675923419; Wed, 09 Mar 2011 05:05:23 -0800 (PST) Received: by 10.227.151.17 with SMTP id a17mr354880wbw.25.1299675923401; Wed, 09 Mar 2011 05:05:23 -0800 (PST) Received: from lxorguk.ukuu.org.uk (lxorguk.ukuu.org.uk [81.2.110.251]) by gmr-mx.google.com with ESMTPS id f14si449658wbu.1.2011.03.09.05.05.21 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 09 Mar 2011 05:05:22 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of alan@lxorguk.ukuu.org.uk designates 81.2.110.251 as permitted sender) client-ip=81.2.110.251; Received: from bob.linux.org.uk (earthlight.etchedpixels.co.uk [81.2.110.250]) by lxorguk.ukuu.org.uk (8.14.4/8.14.1) with ESMTP id p29D87fw003447; Wed, 9 Mar 2011 13:08:12 GMT From: Alan Cox Subject: [rtc-linux] [PATCH] rtc-mrst: Fix section types To: rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, a.zummo@towertech.it Date: Wed, 09 Mar 2011 12:44:39 +0000 Message-ID: <20110309124431.20581.3589.stgit@bob.linux.org.uk> User-Agent: StGIT/0.14.3 MIME-Version: 1.0 X-Original-Sender: alan@lxorguk.ukuu.org.uk X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of alan@lxorguk.ukuu.org.uk designates 81.2.110.251 as permitted sender) smtp.mail=alan@lxorguk.ukuu.org.uk X-Google-Group-Id: 712029733259 Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , From: Major Lee Fix the following section mismatch warning. WARNING: drivers/rtc/built-in.o(.data+0xa0): Section mismatch in reference from the variable vrtc_mrst_platform_driver to the function .init.text:vrtc_mrst_platform_probe() The variable vrtc_mrst_platform_driver references the function __init vrtc_mrst_platform_probe() If the reference is valid then annotate the variable with __init* or __refdata (see linux/init.h) or name the variable: *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console, Signed-off-by: Major Lee Signed-off-by: Alan Cox --- drivers/rtc/rtc-mrst.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/rtc/rtc-mrst.c b/drivers/rtc/rtc-mrst.c index 28e02e7..4c3e251 100644 --- a/drivers/rtc/rtc-mrst.c +++ b/drivers/rtc/rtc-mrst.c @@ -360,7 +360,7 @@ static irqreturn_t mrst_rtc_irq(int irq, void *p) return IRQ_NONE; } -static int __init +static int __devinit vrtc_mrst_do_probe(struct device *dev, struct resource *iomem, int rtc_irq) { int retval = 0; @@ -432,7 +432,7 @@ static void rtc_mrst_do_shutdown(void) spin_unlock_irq(&rtc_lock); } -static void __exit rtc_mrst_do_remove(struct device *dev) +static void __devexit rtc_mrst_do_remove(struct device *dev) { struct mrst_rtc *mrst = dev_get_drvdata(dev); struct resource *iomem; @@ -541,14 +541,14 @@ static inline int mrst_poweroff(struct device *dev) #endif -static int __init vrtc_mrst_platform_probe(struct platform_device *pdev) +static int __devinit vrtc_mrst_platform_probe(struct platform_device *pdev) { return vrtc_mrst_do_probe(&pdev->dev, platform_get_resource(pdev, IORESOURCE_MEM, 0), platform_get_irq(pdev, 0)); } -static int __exit vrtc_mrst_platform_remove(struct platform_device *pdev) +static int __devexit vrtc_mrst_platform_remove(struct platform_device *pdev) { rtc_mrst_do_remove(&pdev->dev); return 0; @@ -566,7 +566,7 @@ MODULE_ALIAS("platform:vrtc_mrst"); static struct platform_driver vrtc_mrst_platform_driver = { .probe = vrtc_mrst_platform_probe, - .remove = __exit_p(vrtc_mrst_platform_remove), + .remove = __devexit_p(vrtc_mrst_platform_remove), .shutdown = vrtc_mrst_platform_shutdown, .driver = { .name = (char *) driver_name,