| Message ID | 1605000947-32882-1-git-send-email-tiantao6@hisilicon.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | rtc: cpcap: Fix missing IRQF_ONESHOT as only threaded handler | expand |
On Tue, 10 Nov 2020 17:35:47 +0800, Tian Tao wrote: > Coccinelle noticed: > drivers/rtc/rtc-cpcap.c:271:7-32: ERROR: Threaded IRQ with no > primary handler requested without IRQF_ONESHOT > drivers/rtc/rtc-cpcap.c:287:7-32: ERROR: Threaded IRQ with no > primary handler requested without IRQF_ONESHOT Applied, thanks! [1/1] rtc: cpcap: Fix missing IRQF_ONESHOT as only threaded handler commit: bc06cfc1c41e3b60b159132e5bba4c059a2e7f83 Best regards,
diff --git a/drivers/rtc/rtc-cpcap.c b/drivers/rtc/rtc-cpcap.c index 800667d..38d576b 100644 --- a/drivers/rtc/rtc-cpcap.c +++ b/drivers/rtc/rtc-cpcap.c @@ -269,7 +269,8 @@ static int cpcap_rtc_probe(struct platform_device *pdev) rtc->alarm_irq = platform_get_irq(pdev, 0); err = devm_request_threaded_irq(dev, rtc->alarm_irq, NULL, - cpcap_rtc_alarm_irq, IRQF_TRIGGER_NONE, + cpcap_rtc_alarm_irq, + IRQF_TRIGGER_NONE | IRQF_ONESHOT, "rtc_alarm", rtc); if (err) { dev_err(dev, "Could not request alarm irq: %d\n", err); @@ -285,7 +286,8 @@ static int cpcap_rtc_probe(struct platform_device *pdev) */ rtc->update_irq = platform_get_irq(pdev, 1); err = devm_request_threaded_irq(dev, rtc->update_irq, NULL, - cpcap_rtc_update_irq, IRQF_TRIGGER_NONE, + cpcap_rtc_update_irq, + IRQF_TRIGGER_NONE | IRQF_ONESHOT, "rtc_1hz", rtc); if (err) { dev_err(dev, "Could not request update irq: %d\n", err);
Coccinelle noticed: drivers/rtc/rtc-cpcap.c:271:7-32: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT drivers/rtc/rtc-cpcap.c:287:7-32: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT Signed-off-by: Tian Tao <tiantao6@hisilicon.com> --- drivers/rtc/rtc-cpcap.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)