| Message ID | 1590370788-15136-1-git-send-email-yangtiezhu@loongson.cn |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/2] rtc: goldfish: Use correct return value for goldfish_rtc_probe() | expand |
On Mon, 25 May 2020 09:39:47 +0800, Tiezhu Yang wrote: > When call function devm_platform_ioremap_resource(), we should use IS_ERR() > to check the return value and return PTR_ERR() if failed. Applied, thanks! [1/2] rtc: goldfish: Use correct return value for goldfish_rtc_probe() commit: e712bb5c45313b3ab35ece2fb0a44cdc49548bd9 [2/2] rtc: mpc5121: Use correct return value for mpc5121_rtc_probe() commit: 4c2a13a2d686a7412d862802156eebd0e15df7ad Best regards,
diff --git a/drivers/rtc/rtc-goldfish.c b/drivers/rtc/rtc-goldfish.c index cb6b0ad..2779715 100644 --- a/drivers/rtc/rtc-goldfish.c +++ b/drivers/rtc/rtc-goldfish.c @@ -174,7 +174,7 @@ static int goldfish_rtc_probe(struct platform_device *pdev) platform_set_drvdata(pdev, rtcdrv); rtcdrv->base = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(rtcdrv->base)) - return -ENODEV; + return PTR_ERR(rtcdrv->base); rtcdrv->irq = platform_get_irq(pdev, 0); if (rtcdrv->irq < 0)
When call function devm_platform_ioremap_resource(), we should use IS_ERR() to check the return value and return PTR_ERR() if failed. Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn> --- drivers/rtc/rtc-goldfish.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)