| Message ID | 1590227782-32249-2-git-send-email-yangtiezhu@loongson.cn |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [1/2] rtc: goldfish: Fix return value of goldfish_rtc_probe() | expand |
On 23/05/2020 17:56:22+0800, Tiezhu Yang wrote: > When call function devm_platform_ioremap_resource(), we should use IS_ERR() > to check the return value and return PTR_ERR() if failed. > Same comment here. > Fixes: d53d4ae981d0 ("rtc: mpc5121: simplify probe") > Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn> > --- > drivers/rtc/rtc-mpc5121.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/rtc/rtc-mpc5121.c b/drivers/rtc/rtc-mpc5121.c > index 3040844..5c2ce71 100644 > --- a/drivers/rtc/rtc-mpc5121.c > +++ b/drivers/rtc/rtc-mpc5121.c > @@ -316,7 +316,7 @@ static int mpc5121_rtc_probe(struct platform_device *op) > rtc->regs = devm_platform_ioremap_resource(op, 0); > if (IS_ERR(rtc->regs)) { > dev_err(&op->dev, "%s: couldn't map io space\n", __func__); > - return -ENOSYS; > + return PTR_ERR(rtc->regs); > } > > device_init_wakeup(&op->dev, 1); > -- > 2.1.0 >
diff --git a/drivers/rtc/rtc-mpc5121.c b/drivers/rtc/rtc-mpc5121.c index 3040844..5c2ce71 100644 --- a/drivers/rtc/rtc-mpc5121.c +++ b/drivers/rtc/rtc-mpc5121.c @@ -316,7 +316,7 @@ static int mpc5121_rtc_probe(struct platform_device *op) rtc->regs = devm_platform_ioremap_resource(op, 0); if (IS_ERR(rtc->regs)) { dev_err(&op->dev, "%s: couldn't map io space\n", __func__); - return -ENOSYS; + return PTR_ERR(rtc->regs); } device_init_wakeup(&op->dev, 1);
When call function devm_platform_ioremap_resource(), we should use IS_ERR() to check the return value and return PTR_ERR() if failed. Fixes: d53d4ae981d0 ("rtc: mpc5121: simplify probe") Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn> --- drivers/rtc/rtc-mpc5121.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)