| Message ID | 1588757640-39044-1-git-send-email-zou_wei@huawei.com |
|---|---|
| State | Rejected |
| Headers | show |
| Series | [-next] rtc: pcf8523: Use PTR_ERR_OR_ZERO() to simplify code | expand |
Hi, On 06/05/2020 17:34:00+0800, Samuel Zou wrote: > Fixes coccicheck warning: > > drivers/rtc/rtc-pcf8523.c:361:1-3: WARNING: PTR_ERR_OR_ZERO can be used > I'm not taking this change because it is useless and will have to be revert as soon as the probe function changes (and it will). Does it really simplifies the code? I very much doubt so. > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Samuel Zou <zou_wei@huawei.com> > --- > drivers/rtc/rtc-pcf8523.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/rtc/rtc-pcf8523.c b/drivers/rtc/rtc-pcf8523.c > index 47e0f41..da8889a 100644 > --- a/drivers/rtc/rtc-pcf8523.c > +++ b/drivers/rtc/rtc-pcf8523.c > @@ -358,10 +358,8 @@ static int pcf8523_probe(struct i2c_client *client, > > rtc = devm_rtc_device_register(&client->dev, DRIVER_NAME, > &pcf8523_rtc_ops, THIS_MODULE); > - if (IS_ERR(rtc)) > - return PTR_ERR(rtc); > > - return 0; > + return PTR_ERR_OR_ZERO(rtc); > } > > static const struct i2c_device_id pcf8523_id[] = { > -- > 2.6.2 >
diff --git a/drivers/rtc/rtc-pcf8523.c b/drivers/rtc/rtc-pcf8523.c index 47e0f41..da8889a 100644 --- a/drivers/rtc/rtc-pcf8523.c +++ b/drivers/rtc/rtc-pcf8523.c @@ -358,10 +358,8 @@ static int pcf8523_probe(struct i2c_client *client, rtc = devm_rtc_device_register(&client->dev, DRIVER_NAME, &pcf8523_rtc_ops, THIS_MODULE); - if (IS_ERR(rtc)) - return PTR_ERR(rtc); - return 0; + return PTR_ERR_OR_ZERO(rtc); } static const struct i2c_device_id pcf8523_id[] = {
Fixes coccicheck warning: drivers/rtc/rtc-pcf8523.c:361:1-3: WARNING: PTR_ERR_OR_ZERO can be used Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Samuel Zou <zou_wei@huawei.com> --- drivers/rtc/rtc-pcf8523.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)