| Message ID | 1583481181-22972-1-git-send-email-clabbe@baylibre.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/2] PNP: constify driver name | expand |
On 3/6/2020 8:53 AM, Corentin Labbe wrote: > struct pnp_driver has name set as char* instead of const char* like platform_driver, pci_driver, usb_driver, etc... > Let's unify a bit by setting name as const char*. > Furthermore, all users of this structures set name from already const > data. > > Signed-off-by: Corentin Labbe <clabbe@baylibre.com> > --- > include/linux/pnp.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/pnp.h b/include/linux/pnp.h > index 3b12fd28af78..b18dca67253d 100644 > --- a/include/linux/pnp.h > +++ b/include/linux/pnp.h > @@ -379,7 +379,7 @@ struct pnp_id { > }; > > struct pnp_driver { > - char *name; > + const char *name; > const struct pnp_device_id *id_table; > unsigned int flags; > int (*probe) (struct pnp_dev *dev, const struct pnp_device_id *dev_id); Applied as 5.7 material along with the [2/2]. BTW, please CC PNP patches to linux-acpi in the future.
On Tue, Mar 17, 2020 at 06:46:24PM +0100, Rafael J. Wysocki wrote: > On 3/6/2020 8:53 AM, Corentin Labbe wrote: > > struct pnp_driver has name set as char* instead of const char* like platform_driver, pci_driver, usb_driver, etc... > > Let's unify a bit by setting name as const char*. > > Furthermore, all users of this structures set name from already const > > data. > > > > Signed-off-by: Corentin Labbe <clabbe@baylibre.com> > > --- > > include/linux/pnp.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/include/linux/pnp.h b/include/linux/pnp.h > > index 3b12fd28af78..b18dca67253d 100644 > > --- a/include/linux/pnp.h > > +++ b/include/linux/pnp.h > > @@ -379,7 +379,7 @@ struct pnp_id { > > }; > > > > struct pnp_driver { > > - char *name; > > + const char *name; > > const struct pnp_device_id *id_table; > > unsigned int flags; > > int (*probe) (struct pnp_dev *dev, const struct pnp_device_id *dev_id); > > Applied as 5.7 material along with the [2/2]. > > BTW, please CC PNP patches to linux-acpi in the future. > Perhaps it is better to update MAINTAINERS ? I will send a patch for it.
diff --git a/include/linux/pnp.h b/include/linux/pnp.h index 3b12fd28af78..b18dca67253d 100644 --- a/include/linux/pnp.h +++ b/include/linux/pnp.h @@ -379,7 +379,7 @@ struct pnp_id { }; struct pnp_driver { - char *name; + const char *name; const struct pnp_device_id *id_table; unsigned int flags; int (*probe) (struct pnp_dev *dev, const struct pnp_device_id *dev_id);
struct pnp_driver has name set as char* instead of const char* like platform_driver, pci_driver, usb_driver, etc... Let's unify a bit by setting name as const char*. Furthermore, all users of this structures set name from already const data. Signed-off-by: Corentin Labbe <clabbe@baylibre.com> --- include/linux/pnp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)