From patchwork Wed Nov 8 19:58:14 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Akshay Bhat X-Patchwork-Id: 835972 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-rtc-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=timesys-com.20150623.gappssmtp.com header.i=@timesys-com.20150623.gappssmtp.com header.b="Q9tz3vpW"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yXHDN6vwGz9s72 for ; Thu, 9 Nov 2017 06:58:44 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751831AbdKHT6b (ORCPT ); Wed, 8 Nov 2017 14:58:31 -0500 Received: from mail-qk0-f196.google.com ([209.85.220.196]:46666 "EHLO mail-qk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751716AbdKHT6a (ORCPT ); Wed, 8 Nov 2017 14:58:30 -0500 Received: by mail-qk0-f196.google.com with SMTP id o6so4900717qkh.3 for ; Wed, 08 Nov 2017 11:58:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=timesys-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=9JMSHVK/xy/EEc/cOC+tmwPDvCB6UUk72Qx83Q1801g=; b=Q9tz3vpWeTg5SbvIwW1DwsfG2anozDqz942CKjB8iCWEIFdJnTdOFUD7AwLAgh+U8w caOHZubHrrK/uPdl4PzXZqW5bbOBoWRFH2Fkrcvvxqd0e05jTke9Sozl3MPkg7sGfBLi TdqIuSp9UJP/0qdlKSfkDoVKh5MLBxBo5QfA5okHPyHQKQCX/whaxYGNGOPx9r0X7J58 1GiXt5nxn3j1YAmar+TSq/irLcNraUTcGHae4Axwdccc1Bn8jWvMRaiAXqodGxrWksYG YNX9C96XLlms22VPxHTrgmGJUtNbfDadznJ4LehZ87YwXL/5+WGAPmRuIMzOQYJRzR9B YTMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=9JMSHVK/xy/EEc/cOC+tmwPDvCB6UUk72Qx83Q1801g=; b=LMqiokYj1FjuY3bCAkuKT5Bc0Bl3WqyV6bTCPbVJDlV5KVNRE6RBMW7HmXWtH0KSrE xeA8h3EJXjB0Aph8T8DOi7xXK2o3710BQYu/1VNRgFVc0R5J1pPVzUN5OLvbdDe3fNnV pYXElj7FX/ocvYSae3FaZshmPkl6vj5x+s/rsXFhmD/9jSSUXYgwGlkpvrY6bCj3Gtqn 65Rb6RLY8Yq943ydYNBebYaUA9yTl942Yl6Q+kpGtMp/Ds/AkM93Bh8eMsjXG42ImZMl l5AjUu3mhpdDiioKwbg9OfflGBNhZADbdC30BU74dbuufTh3QC9pnBMjIu1SIOOT6qC5 Tlug== X-Gm-Message-State: AJaThX5T+yreE1Oj47NP1JnUq/4OYFv6Fyd8HTrooieFPCJm6kDqZLS5 hQmLCGgrMzg9RlIJUnz3bDDP8g== X-Google-Smtp-Source: AGs4zMYwYe5vUpkFYl9h9mY6cL/prXOSrUAqL+0DOzQsYgivGNeepUetaWuT7hiWgryCBTQrv2kk8Q== X-Received: by 10.55.16.86 with SMTP id a83mr2567237qkh.222.1510171109762; Wed, 08 Nov 2017 11:58:29 -0800 (PST) Received: from timesysax.timesys.com (96-94-100-129-static.hfc.comcastbusiness.net. [96.94.100.129]) by smtp.gmail.com with ESMTPSA id u65sm3256236qtd.20.2017.11.08.11.58.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 08 Nov 2017 11:58:28 -0800 (PST) From: Akshay Bhat To: a.zummo@towertech.it, alexandre.belloni@free-electrons.com Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, Akshay Bhat Subject: [PATCH v2] rtc: rx8010: Fix for incorrect return value Date: Wed, 8 Nov 2017 14:58:14 -0500 Message-Id: <1510171094-4859-1-git-send-email-akshay.bhat@timesys.com> X-Mailer: git-send-email 2.7.4 Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org The err variable is not being reset after a successful read. Explicitly return 0 at the end of function call to account for all return paths. Reported-by: Jens-Peter Oswald Signed-off-by: Akshay Bhat --- v2: Address comments from Alexandre Belloni - Return 0 at end of function instead of resetting err variable drivers/rtc/rtc-rx8010.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-rx8010.c b/drivers/rtc/rtc-rx8010.c index 2e06e5f..5c5938a 100644 --- a/drivers/rtc/rtc-rx8010.c +++ b/drivers/rtc/rtc-rx8010.c @@ -247,7 +247,7 @@ static int rx8010_init_client(struct i2c_client *client) rx8010->ctrlreg = (ctrl[1] & ~RX8010_CTRL_TEST); - return err; + return 0; } static int rx8010_read_alarm(struct device *dev, struct rtc_wkalrm *t) @@ -276,7 +276,7 @@ static int rx8010_read_alarm(struct device *dev, struct rtc_wkalrm *t) t->enabled = !!(rx8010->ctrlreg & RX8010_CTRL_AIE); t->pending = (flagreg & RX8010_FLAG_AF) && t->enabled; - return err; + return 0; } static int rx8010_set_alarm(struct device *dev, struct rtc_wkalrm *t)