| Message ID | 1471005974-16973-1-git-send-email-clabbe.montjoie@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
On 12/08/2016 at 14:46:14 +0200, LABBE Corentin wrote : > The char pointer buf_ptr is assigned an address from a const char > pointer buf (parameter of wakealarm_store). > The data pointer by buf_ptr is never modified. > So casting it to a (char *) is useless. > > This patch remove this cast, and transform buf_ptr to a const char pointer. > > Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com> > --- > drivers/rtc/rtc-sysfs.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Applied, thanks.
diff --git a/drivers/rtc/rtc-sysfs.c b/drivers/rtc/rtc-sysfs.c index 63b9fb1..1218d5d 100644 --- a/drivers/rtc/rtc-sysfs.c +++ b/drivers/rtc/rtc-sysfs.c @@ -160,7 +160,7 @@ wakealarm_store(struct device *dev, struct device_attribute *attr, unsigned long push = 0; struct rtc_wkalrm alm; struct rtc_device *rtc = to_rtc_device(dev); - char *buf_ptr; + const char *buf_ptr; int adjust = 0; /* Only request alarms that trigger in the future. Disable them @@ -171,7 +171,7 @@ wakealarm_store(struct device *dev, struct device_attribute *attr, return retval; rtc_tm_to_time(&alm.time, &now); - buf_ptr = (char *)buf; + buf_ptr = buf; if (*buf_ptr == '+') { buf_ptr++; if (*buf_ptr == '=') {
The char pointer buf_ptr is assigned an address from a const char pointer buf (parameter of wakealarm_store). The data pointer by buf_ptr is never modified. So casting it to a (char *) is useless. This patch remove this cast, and transform buf_ptr to a const char pointer. Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com> --- drivers/rtc/rtc-sysfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)