From patchwork Sun Apr 10 14:59:24 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Akinobu Mita X-Patchwork-Id: 608527 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-io0-x23d.google.com (mail-io0-x23d.google.com [IPv6:2607:f8b0:4001:c06::23d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3qjbvp0zZcz9snm for ; Mon, 11 Apr 2016 00:59:50 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.b=m0ZQPXAk; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=07SuYRZE; dkim-atps=neutral Received: by mail-io0-x23d.google.com with SMTP id g185sf44797530ioa.1 for ; Sun, 10 Apr 2016 07:59:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=sender:mime-version:from:to:cc:subject:date:message-id:in-reply-to :references:x-original-sender:x-original-authentication-results :reply-to:precedence:mailing-list:list-id:x-spam-checked-in-group :list-post:list-help:list-archive:list-subscribe:list-unsubscribe; bh=PJOGcnE7ukUCkndnnZ5ccW27m/roZw+yM0PtRUKY09M=; b=m0ZQPXAk2eUHgedpByOD0MUMQsoAnMkw91Os067LRFSAKf2bW3CxhDBGCWe0CeW3E6 eO59UGr+E+d+8ywimuvQXGCzr9mFeSoO6BT/YBLdTHr9vh3hz/amTH1xujI8MeFZyTEl EkINjHzf/KzVGMnhH+yatp1SDc2feEMnf//3o91U47HzdA6bgfSpPw0nGjmHSc1UTsvP oKkWp+Nu6v2jjY8ALbS/3kFxldU83Hd4NF/C+xcKtZEE5lJ2PecbK4oW62BhyL4eLyoE DmMtWFp/aJu1R7r2PtJN80CEAv6OoT9RViBhvMuD/XhrXtUkh5kAkYT1BOZ9Dy5UOdua /M+w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:to:cc:subject:date:message-id:in-reply-to :references:x-original-sender:x-original-authentication-results :reply-to:precedence:mailing-list:list-id:x-spam-checked-in-group :list-post:list-help:list-archive:list-subscribe:list-unsubscribe; bh=PJOGcnE7ukUCkndnnZ5ccW27m/roZw+yM0PtRUKY09M=; b=07SuYRZEVrlhreem8xi68ylzYDXjErtYqJUqHgpRjK/0VU5vKUX/ftUFMJzQ7dVavr KMxtVTKfsWJmcJsT3dVI5rt2ArtYEF4/mXYXTDjykOHEBOOLYPuwgFXQ6isvtnKTkDuy +wica6OCWhIZHtSUBRoUriMDb8M1TVT3DxaZKs2rwK8AYjRJDc1agZvugutQkH0MMR6f h4nR6Clv7TEcm8ldp08m9qtYmJuATvqtABoB2o5OWKXIGghV0rT6HxSD1rucsRjAsRlf uMjza8fRm4jIvXJNFFuH4GILMXewTOA5VTkl14v80G81QNTml/XHmS5pz5V6mwdcLA1n QUqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=sender:x-gm-message-state:mime-version:from:to:cc:subject:date :message-id:in-reply-to:references:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:x-spam-checked-in-group:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=PJOGcnE7ukUCkndnnZ5ccW27m/roZw+yM0PtRUKY09M=; b=IKfGYGtZ4CkMTRLPinA159ipJcMyM5L28TKjcGIl0DjgNRGjqxTK7tqeVpNwi2OHkD 8XQQCzE0ClqIRaCbF4ZzETk/lNUc0FL7fHMreHMIqM8StBN0UdlwNhtODQ48WeTLUHCB Gx3lOYjrtwlD4Ak8WDt2x6PmvNyNgm7Xc8IwYK5jAKdas0hPqAvvg3iSzCN7ESQyUVbi d+CJfxDP/LE/kJn+Dk1k5e4sPzXm2lSdxVZFaEAMoqGyhPgbADgpZF3TH5Fu2UpDxqFV gYWvxnuE2rB7E0rNG/OkDfmMjc14wQlLJ1Ohhe2pyTHnnfxY2aktOuv9o4fM/VSQsGUB pNYg== Sender: rtc-linux@googlegroups.com X-Gm-Message-State: AD7BkJLXzk/sfuSS6a53HQWvHvAPQ4+U4ZYPt7hW3jWFXbX2tEo9O3RRMC8g5eowhJihyw== X-Received: by 10.50.1.80 with SMTP id 16mr241774igk.2.1460300388615; Sun, 10 Apr 2016 07:59:48 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: rtc-linux@googlegroups.com Received: by 10.107.9.137 with SMTP id 9ls1604567ioj.12.gmail; Sun, 10 Apr 2016 07:59:48 -0700 (PDT) X-Received: by 10.67.7.161 with SMTP id dd1mr11792858pad.41.1460300388371; Sun, 10 Apr 2016 07:59:48 -0700 (PDT) Received: from mail-pa0-x241.google.com (mail-pa0-x241.google.com. [2607:f8b0:400e:c03::241]) by gmr-mx.google.com with ESMTPS id r4si1058429pfr.1.2016.04.10.07.59.48 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 10 Apr 2016 07:59:48 -0700 (PDT) Received-SPF: pass (google.com: domain of akinobu.mita@gmail.com designates 2607:f8b0:400e:c03::241 as permitted sender) client-ip=2607:f8b0:400e:c03::241; Received: by mail-pa0-x241.google.com with SMTP id vv3so32517pab.0 for ; Sun, 10 Apr 2016 07:59:48 -0700 (PDT) X-Received: by 10.66.132.37 with SMTP id or5mr26591962pab.144.1460300388258; Sun, 10 Apr 2016 07:59:48 -0700 (PDT) Received: from localhost.localdomain (KD113159139091.ppp-bb.dion.ne.jp. [113.159.139.91]) by smtp.gmail.com with ESMTPSA id lq10sm30302002pab.36.2016.04.10.07.59.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 10 Apr 2016 07:59:47 -0700 (PDT) From: Akinobu Mita To: rtc-linux@googlegroups.com, devicetree@vger.kernel.org Cc: Akinobu Mita , Sergey Yanovich , Alessandro Zummo , Alexandre Belloni Subject: [rtc-linux] [PATCH 2/4] rtc: ds1302: fix write value for day of week register Date: Sun, 10 Apr 2016 23:59:24 +0900 Message-Id: <1460300366-25248-3-git-send-email-akinobu.mita@gmail.com> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1460300366-25248-1-git-send-email-akinobu.mita@gmail.com> References: <1460300366-25248-1-git-send-email-akinobu.mita@gmail.com> X-Original-Sender: Akinobu.Mita@gmail.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com; spf=pass (google.com: domain of akinobu.mita@gmail.com designates 2607:f8b0:400e:c03::241 as permitted sender) smtp.mailfrom=akinobu.mita@gmail.com; dmarc=pass (p=NONE dis=NONE) header.from=gmail.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: rtc-linux@googlegroups.com X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , The valid range of day of week register for DS1302 is 1 to 7. But the set_time callback for rtc-ds1302 attempts to write the value of tm->tm_wday which is in the range 0 to 6. While the get_time callback correctly decodes the register. Signed-off-by: Akinobu Mita Cc: Sergey Yanovich Cc: Alessandro Zummo Cc: Alexandre Belloni --- drivers/rtc/rtc-ds1302.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-ds1302.c b/drivers/rtc/rtc-ds1302.c index 5e05653..454248f 100644 --- a/drivers/rtc/rtc-ds1302.c +++ b/drivers/rtc/rtc-ds1302.c @@ -66,7 +66,7 @@ static int ds1302_rtc_set_time(struct device *dev, struct rtc_time *time) *bp++ = bin2bcd(time->tm_hour); *bp++ = bin2bcd(time->tm_mday); *bp++ = bin2bcd(time->tm_mon + 1); - *bp++ = time->tm_wday; + *bp++ = time->tm_wday + 1; *bp++ = bin2bcd(time->tm_year % 100); *bp++ = RTC_CMD_WRITE_DISABLE;