From patchwork Mon Feb 29 15:13:50 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Akinobu Mita X-Patchwork-Id: 589999 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-ob0-x23a.google.com (mail-ob0-x23a.google.com [IPv6:2607:f8b0:4003:c01::23a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id AE42A140770 for ; Tue, 1 Mar 2016 02:14:29 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.b=ISDOWGNl; dkim-atps=neutral Received: by mail-ob0-x23a.google.com with SMTP id rt8sf5073586obc.0 for ; Mon, 29 Feb 2016 07:14:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=mime-version:from:to:cc:subject:date:message-id:in-reply-to :references:x-original-sender:x-original-authentication-results :reply-to:precedence:mailing-list:list-id:x-spam-checked-in-group :list-post:list-help:list-archive:sender:list-subscribe :list-unsubscribe; bh=MfjCJINXScPyHlKbFAR8N+ZkoqL5sWed82FLxNHFsJU=; b=ISDOWGNlhHzY5m2kLloIPzW6aV4/8Jdi+r0EdfoEQSarkVf+sxua+rZZyqlSa8E/Hk 1uXmw0B/TwyjsTiWDmKcVjg/SvI/oO4K/YEDn32LEDtZFveA2hZS4C841CdQtl+flX+N 2zSbQQhQz93LAdaK/K+QTQm5WLP8UZyEr4TewptMuDN1ejFASBuCFnjGZNv8P72qoY+e SIoClAveG4QudtgpsYWoh3/5wa67S9ZY6okI2zPXthyx+Z1CzRp1EOGjs1v6KSlwSjqo XBClxmRLAZbEx6rjGnyatX33uNK4rKS5FNVtOtj8aMKBQP1FAfOs63vLgAvW6e3zl6/y Wtog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:to:cc:subject:date:message-id :in-reply-to:references:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:x-spam-checked-in-group:list-post:list-help:list-archive :sender:list-subscribe:list-unsubscribe; bh=MfjCJINXScPyHlKbFAR8N+ZkoqL5sWed82FLxNHFsJU=; b=jZyRN2pql9BUTe9QELPvS49rzoeixYIeivxgIzNtLtRgCBC/h+j1H7OBarly49zi3Z IhKP4lU4SKf0p17qn2YwZ6VbSpjuD98M94WZXEju3T9oxcfrKYVLw8GdVcND6eMh0xyu 3DxXF2R2cD6y6m8Eh/T7YQNNQd/D9nQH8Mth9plhAJbDkjD6HhY3jJ2cQCCtTUIY4Moe RBC3DY4rEMgVEGbtF4LHqpOVc9P3EZqPj+VbFLybAZxKJRBJ0Uto8joD4Mb+z9ixS0eX sSI3/wcUpJetAwoU2zZC9JEC3wXdb4lWZ1DzJIOvftitX09eV8agDqWzx/Q0zY+gxnS1 qvdA== X-Gm-Message-State: AD7BkJLfhEbYQt56tELAKynvJ6cPcFpBQQlnPBP7JntRbs9MpByLH7EbiwXM52irDHk8IQ== X-Received: by 10.50.43.194 with SMTP id y2mr174399igl.9.1456758867930; Mon, 29 Feb 2016 07:14:27 -0800 (PST) MIME-Version: 1.0 X-BeenThere: rtc-linux@googlegroups.com Received: by 10.107.34.74 with SMTP id i71ls266790ioi.96.gmail; Mon, 29 Feb 2016 07:14:27 -0800 (PST) X-Received: by 10.66.142.135 with SMTP id rw7mr13371573pab.20.1456758867603; Mon, 29 Feb 2016 07:14:27 -0800 (PST) Received: from mail-pa0-x22c.google.com (mail-pa0-x22c.google.com. [2607:f8b0:400e:c03::22c]) by gmr-mx.google.com with ESMTPS id ui7si3698544pab.0.2016.02.29.07.14.27 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 29 Feb 2016 07:14:27 -0800 (PST) Received-SPF: pass (google.com: domain of akinobu.mita@gmail.com designates 2607:f8b0:400e:c03::22c as permitted sender) client-ip=2607:f8b0:400e:c03::22c; Received: by mail-pa0-x22c.google.com with SMTP id bj10so24176316pad.2 for ; Mon, 29 Feb 2016 07:14:27 -0800 (PST) X-Received: by 10.66.145.194 with SMTP id sw2mr22489308pab.69.1456758867431; Mon, 29 Feb 2016 07:14:27 -0800 (PST) Received: from localhost.localdomain (KD113159139091.ppp-bb.dion.ne.jp. [113.159.139.91]) by smtp.gmail.com with ESMTPSA id g10sm38866329pfd.92.2016.02.29.07.14.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 29 Feb 2016 07:14:26 -0800 (PST) From: Akinobu Mita To: rtc-linux@googlegroups.com Cc: Akinobu Mita , Alessandro Zummo , Alexandre Belloni , Dennis Aberilla Subject: [rtc-linux] [PATCH v3 6/8] rtc: ds3232-core: remove unused UIE code Date: Tue, 1 Mar 2016 00:13:50 +0900 Message-Id: <1456758832-10590-6-git-send-email-akinobu.mita@gmail.com> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1456758832-10590-1-git-send-email-akinobu.mita@gmail.com> References: <1456758832-10590-1-git-send-email-akinobu.mita@gmail.com> X-Original-Sender: Akinobu.Mita@gmail.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of akinobu.mita@gmail.com designates 2607:f8b0:400e:c03::22c as permitted sender) smtp.mailfrom=akinobu.mita@gmail.com; dkim=pass header.i=@gmail.com; dmarc=pass (p=NONE dis=NONE) header.from=gmail.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: rtc-linux@googlegroups.com X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , UIE mode irqs are handled by the generic rtc core now. But there are remaining unused code fragments for it. Signed-off-by: Akinobu Mita Cc: Alessandro Zummo Cc: Alexandre Belloni Cc: Dennis Aberilla --- * New patch from this version drivers/rtc/rtc-ds3232-core.c | 20 +------------------- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/drivers/rtc/rtc-ds3232-core.c b/drivers/rtc/rtc-ds3232-core.c index bcce75b..be8dfe0 100644 --- a/drivers/rtc/rtc-ds3232-core.c +++ b/drivers/rtc/rtc-ds3232-core.c @@ -278,32 +278,14 @@ static int ds3232_update_alarm(struct device *dev, unsigned int enabled) struct ds3232 *ds3232 = dev_get_drvdata(dev); int control; int ret; - u8 buf[4]; mutex_lock(&ds3232->mutex); - ret = regmap_bulk_read(ds3232->regmap, DS3232_REG_ALARM1, buf, 4); - if (ret) - goto unlock; - - buf[0] = bcd2bin(buf[0]) < 0 || (ds3232->rtc->irq_data & RTC_UF) ? - 0x80 : buf[0]; - buf[1] = bcd2bin(buf[1]) < 0 || (ds3232->rtc->irq_data & RTC_UF) ? - 0x80 : buf[1]; - buf[2] = bcd2bin(buf[2]) < 0 || (ds3232->rtc->irq_data & RTC_UF) ? - 0x80 : buf[2]; - buf[3] = bcd2bin(buf[3]) < 0 || (ds3232->rtc->irq_data & RTC_UF) ? - 0x80 : buf[3]; - - ret = regmap_bulk_write(ds3232->regmap, DS3232_REG_ALARM1, buf, 4); - if (ret) - goto unlock; - ret = regmap_read(ds3232->regmap, DS3232_REG_CR, &control); if (ret) goto unlock; - if (enabled || (ds3232->rtc->irq_data & RTC_UF)) + if (enabled) /* enable alarm1 interrupt */ control |= DS3232_REG_CR_A1IE; else