From patchwork Mon Sep 21 13:33:56 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrzej Hajda X-Patchwork-Id: 520296 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-oi0-x23e.google.com (mail-oi0-x23e.google.com [IPv6:2607:f8b0:4003:c06::23e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 9C9351401DE for ; Mon, 21 Sep 2015 23:36:27 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.b=jK+xkDfx; dkim-atps=neutral Received: by oiww128 with SMTP id w128sf17721646oiw.1 for ; Mon, 21 Sep 2015 06:36:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=mime-version:from:to:cc:subject:date:message-id:in-reply-to :references:x-original-sender:x-original-authentication-results :reply-to:content-type:precedence:mailing-list:list-id :x-spam-checked-in-group:list-post:list-help:list-archive:sender :list-subscribe:list-unsubscribe; bh=9M+kGSnbfXu9uuDuavoN2bgDgOUJrs8POwmg27EL5Js=; b=jK+xkDfxeNXjKP6zcTl0/KhWTWQmbeG2FItbUbjbXR6ijCV7iClXgB94a+GKsRf/ub mAY6Sd73f6OBbhi7oDvnaWnPpVwrFkDHc3t/7EMoYkQiF9iUe8lIInWw7g+OI1jkzrQJ ezf7JWPNZ3EICIwvu5DAh4wPfHB+SXfle1bNuJnAnfZQps3oOFK2D+yo7LMWFrjpEVHa G+4IYGPFXgt/SiQuYC98VdMwMua/zdhyEg9tr7gvcHHC0L3KK2OJwZC7PAlOL/SFP0nD bh3+w47xtA6h0UtwL6C1wuThAw69CwsEfXIPTa0SGsU+Mh7UNeMz72BZasTkd1KsvWdX p8Dg== X-Received: by 10.140.97.8 with SMTP id l8mr122260qge.35.1442842585733; Mon, 21 Sep 2015 06:36:25 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: rtc-linux@googlegroups.com Received: by 10.140.20.77 with SMTP id 71ls2238351qgi.28.gmail; Mon, 21 Sep 2015 06:36:24 -0700 (PDT) X-Received: by 10.31.47.146 with SMTP id v140mr16885967vkv.3.1442842584394; Mon, 21 Sep 2015 06:36:24 -0700 (PDT) Received: from mailout4.w1.samsung.com (mailout4.w1.samsung.com. [210.118.77.14]) by gmr-mx.google.com with ESMTPS id w5si3187418pbt.1.2015.09.21.06.36.23 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 21 Sep 2015 06:36:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of a.hajda@samsung.com designates 210.118.77.14 as permitted sender) client-ip=210.118.77.14; Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NV100MUG4GJDS30@mailout4.w1.samsung.com> for rtc-linux@googlegroups.com; Mon, 21 Sep 2015 14:36:19 +0100 (BST) X-AuditID: cbfec7f5-f794b6d000001495-55-560007d31107 Received: from eusync3.samsung.com ( [203.254.199.213]) by eucpsbgm2.samsung.com (EUCPMTA) with SMTP id F5.67.05269.3D700065; Mon, 21 Sep 2015 14:36:19 +0100 (BST) Received: from AMDC1061.digital.local ([106.116.147.88]) by eusync3.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0NV100LNT4DTKI10@eusync3.samsung.com>; Mon, 21 Sep 2015 14:36:19 +0100 (BST) From: Andrzej Hajda To: linux-kernel@vger.kernel.org Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , Alessandro Zummo , Alexandre Belloni , rtc-linux@googlegroups.com Subject: [rtc-linux] [PATCH 24/38] rtc: opal: fix type of token Date: Mon, 21 Sep 2015 15:33:56 +0200 Message-id: <1442842450-29769-25-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> References: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprCLMWRmVeSWpSXmKPExsVy+t/xq7qX2RnCDA7/MbC4te4cq8WSi1fZ LTquLWay2DhjPavF5V1z2CzWHrnLbrG/s4PRgd3jyaaLjB57Jp5k8+jbsorRY/q8n0wenzfJ BbBGcdmkpOZklqUW6dslcGU0z77FXnCRrWLb9PwGxr2sXYycHBICJhIN094zQ9hiEhfurWfr YuTiEBJYyigx988BFginiUniQEsbI0gVm4CmxN/NN9lAbBEBBYnNvc9YQYqYBSYzSaycsgls lLCAscTU5S/BVrAIqErsebSaCcTmFXCRePxjLTvEOjmJk8cmg9VwAsUPHPzCAmILCThLHFhy hGkCI+8CRoZVjKKppckFxUnpuUZ6xYm5xaV56XrJ+bmbGCFh9XUH49JjVocYBTgYlXh4HQX+ hwqxJpYVV+YeYpTgYFYS4dWZBRTiTUmsrEotyo8vKs1JLT7EKM3BoiTOO3PX+xAhgfTEktTs 1NSC1CKYLBMHp1QDY8T2JyF70/8pXNeftLx7T6W9SNk36bfLvjDMFii441Fk/j7iFfcthoT7 x9TOJ92ZGHhu8XWREOZN9qwf08+db07bPe9D+8LpIacjCno0dTQSYsTFv31eeeoby4mVX6vj uWdbaSmv9hZIOvI6VFmxVJ1HT5pr6ryVLz+E8DHvkIk95b3Y98DFi0osxRmJhlrMRcWJAHrb 8N8nAgAA X-Original-Sender: a.hajda@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of a.hajda@samsung.com designates 210.118.77.14 as permitted sender) smtp.mailfrom=a.hajda@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: rtc-linux@googlegroups.com X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , The variable can take signed values. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda --- drivers/rtc/rtc-opal.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-opal.c b/drivers/rtc/rtc-opal.c index 6fbf9e6..590e1a4 100644 --- a/drivers/rtc/rtc-opal.c +++ b/drivers/rtc/rtc-opal.c @@ -152,10 +152,10 @@ exit: /* Set Timed Power-On */ static int opal_set_tpo_time(struct device *dev, struct rtc_wkalrm *alarm) { - u64 h_m_s_ms = 0, token; + u64 h_m_s_ms = 0; struct opal_msg msg; u32 y_m_d = 0; - int rc; + int token, rc; tm_to_opal(&alarm->time, &y_m_d, &h_m_s_ms);