| Message ID | 1440671672-26590-1-git-send-email-javier@osg.samsung.com |
|---|---|
| State | Accepted |
| Headers | show |
2015-08-27 13:34 GMT+03:00 Javier Martinez Canillas <javier@osg.samsung.com>: > These platform drivers have a platform device ID table but the module > alias information is not created so module autoloading will not work. > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> > > --- > > drivers/rtc/rtc-ab8500.c | 1 + > drivers/rtc/rtc-max8997.c | 1 + > drivers/rtc/rtc-s5m.c | 1 + > 3 files changed, 3 insertions(+) > > diff --git a/drivers/rtc/rtc-ab8500.c b/drivers/rtc/rtc-ab8500.c > index 133d2e2e1a25..8537d1e3a995 100644 > --- a/drivers/rtc/rtc-ab8500.c > +++ b/drivers/rtc/rtc-ab8500.c > @@ -446,6 +446,7 @@ static const struct platform_device_id ab85xx_rtc_ids[] = { > { "ab8500-rtc", (kernel_ulong_t)&ab8500_rtc_ops, }, > { "ab8540-rtc", (kernel_ulong_t)&ab8540_rtc_ops, }, Completely irrelevant, but this array should have an empty terminating element. > }; > +MODULE_DEVICE_TABLE(platform, ab85xx_rtc_ids); >
Hello Andrey, On 08/27/2015 02:20 PM, Andrey Ryabinin wrote: > 2015-08-27 13:34 GMT+03:00 Javier Martinez Canillas <javier@osg.samsung.com>: >> These platform drivers have a platform device ID table but the module >> alias information is not created so module autoloading will not work. >> >> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> >> >> --- >> >> drivers/rtc/rtc-ab8500.c | 1 + >> drivers/rtc/rtc-max8997.c | 1 + >> drivers/rtc/rtc-s5m.c | 1 + >> 3 files changed, 3 insertions(+) >> >> diff --git a/drivers/rtc/rtc-ab8500.c b/drivers/rtc/rtc-ab8500.c >> index 133d2e2e1a25..8537d1e3a995 100644 >> --- a/drivers/rtc/rtc-ab8500.c >> +++ b/drivers/rtc/rtc-ab8500.c >> @@ -446,6 +446,7 @@ static const struct platform_device_id ab85xx_rtc_ids[] = { >> { "ab8500-rtc", (kernel_ulong_t)&ab8500_rtc_ops, }, >> { "ab8540-rtc", (kernel_ulong_t)&ab8540_rtc_ops, }, > > Completely irrelevant, but this array should have an empty terminating element. > You are right, it's missing a sentinel indeed. But that change should be done in a separate patch. >> }; >> +MODULE_DEVICE_TABLE(platform, ab85xx_rtc_ids); >> Best regards,
On 27.08.2015 19:34, Javier Martinez Canillas wrote: > These platform drivers have a platform device ID table but the module > alias information is not created so module autoloading will not work. > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> > > --- > > drivers/rtc/rtc-ab8500.c | 1 + > drivers/rtc/rtc-max8997.c | 1 + > drivers/rtc/rtc-s5m.c | 1 + > 3 files changed, 3 insertions(+) Makes sense: Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Best regards, Krzysztof
On 27/08/2015 at 12:34:32 +0200, Javier Martinez Canillas wrote : > These platform drivers have a platform device ID table but the module > alias information is not created so module autoloading will not work. > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> > > --- > > drivers/rtc/rtc-ab8500.c | 1 + > drivers/rtc/rtc-max8997.c | 1 + > drivers/rtc/rtc-s5m.c | 1 + > 3 files changed, 3 insertions(+) Applied, thanks.
diff --git a/drivers/rtc/rtc-ab8500.c b/drivers/rtc/rtc-ab8500.c index 133d2e2e1a25..8537d1e3a995 100644 --- a/drivers/rtc/rtc-ab8500.c +++ b/drivers/rtc/rtc-ab8500.c @@ -446,6 +446,7 @@ static const struct platform_device_id ab85xx_rtc_ids[] = { { "ab8500-rtc", (kernel_ulong_t)&ab8500_rtc_ops, }, { "ab8540-rtc", (kernel_ulong_t)&ab8540_rtc_ops, }, }; +MODULE_DEVICE_TABLE(platform, ab85xx_rtc_ids); static int ab8500_rtc_probe(struct platform_device *pdev) { diff --git a/drivers/rtc/rtc-max8997.c b/drivers/rtc/rtc-max8997.c index 9e02bcda0c09..db984d4bf952 100644 --- a/drivers/rtc/rtc-max8997.c +++ b/drivers/rtc/rtc-max8997.c @@ -521,6 +521,7 @@ static const struct platform_device_id rtc_id[] = { { "max8997-rtc", 0 }, {}, }; +MODULE_DEVICE_TABLE(platform, rtc_id); static struct platform_driver max8997_rtc_driver = { .driver = { diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c index ab60287ee72d..f2504b4eef34 100644 --- a/drivers/rtc/rtc-s5m.c +++ b/drivers/rtc/rtc-s5m.c @@ -807,6 +807,7 @@ static const struct platform_device_id s5m_rtc_id[] = { { "s2mps14-rtc", S2MPS14X }, { }, }; +MODULE_DEVICE_TABLE(platform, s5m_rtc_id); static struct platform_driver s5m_rtc_driver = { .driver = {
These platform drivers have a platform device ID table but the module alias information is not created so module autoloading will not work. Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> --- drivers/rtc/rtc-ab8500.c | 1 + drivers/rtc/rtc-max8997.c | 1 + drivers/rtc/rtc-s5m.c | 1 + 3 files changed, 3 insertions(+)