From patchwork Thu Aug 13 08:49:24 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joonyoung Shim X-Patchwork-Id: 506890 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-pa0-x23a.google.com (mail-pa0-x23a.google.com [IPv6:2607:f8b0:400e:c03::23a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 63AB614028F for ; Thu, 13 Aug 2015 18:49:26 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.b=fhYZk0bc; dkim-atps=neutral Received: by pacum4 with SMTP id um4sf10283405pac.1 for ; Thu, 13 Aug 2015 01:49:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=mime-version:from:to:cc:subject:date:message-id:dlp-filter :x-original-sender:x-original-authentication-results:reply-to :content-type:precedence:mailing-list:list-id :x-spam-checked-in-group:list-post:list-help:list-archive:sender :list-subscribe:list-unsubscribe; bh=Wh708Mj3t/cuuQOBe+Ro+MYnRWgtBOteRNmTVbBUmnw=; b=fhYZk0bcB3Wz8JQaJJZFZTcvoX5sQaNnrlMkwuz7s/DeVaqzTw7usjGdmCWujXeltz nAVhdkrUUJo/zMLDzZcE3YmaozkyhbRYOPSmwGOQc3i7cU6+utKkjtEz89aAXtH/asGk XDULLzeEQOJp2EGLwWt0vExxiotmvSklamhxMXAxehbYs5dJ0HNTxAFD1eIgTbk6MOLj YZ6EXe2hNVe7B6cVjS5cXlXk0SADQs3lXwCQjzBlTkg7t06PAQO7XpwcaWZdqXkAWjCk J1+5si25TvjwUxXs3HkM/S6MTfD88Tio/AxfHVjMAHr4hHHuVBSU3megjshbDEp7rlyz 9t8A== X-Received: by 10.50.66.205 with SMTP id h13mr421171igt.10.1439455765546; Thu, 13 Aug 2015 01:49:25 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.112.4 with SMTP id im4ls2285771igb.36.canary; Thu, 13 Aug 2015 01:49:25 -0700 (PDT) X-Received: by 10.67.3.5 with SMTP id bs5mr34186604pad.35.1439455765094; Thu, 13 Aug 2015 01:49:25 -0700 (PDT) Received: from mailout3.samsung.com (mailout3.samsung.com. [203.254.224.33]) by gmr-mx.google.com with ESMTPS id eq2si153620pbb.2.2015.08.13.01.49.24 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 13 Aug 2015 01:49:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of jy0922.shim@samsung.com designates 203.254.224.33 as permitted sender) client-ip=203.254.224.33; Received: from epcpsbgr3.samsung.com (u143.gpu120.samsung.co.kr [203.254.230.143]) by mailout3.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NT0025XPJ6AL710@mailout3.samsung.com> for rtc-linux@googlegroups.com; Thu, 13 Aug 2015 17:49:22 +0900 (KST) Received: from epcpsbgm1new.samsung.com ( [172.20.52.112]) by epcpsbgr3.samsung.com (EPCPMTA) with SMTP id DE.6B.24422.21A5CC55; Thu, 13 Aug 2015 17:49:22 +0900 (KST) X-AuditID: cbfee68f-f793b6d000005f66-4b-55cc5a12c8d5 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1new.samsung.com (EPCPMTA) with SMTP id ED.6B.23663.21A5CC55; Thu, 13 Aug 2015 17:49:22 +0900 (KST) Received: from localhost.localdomain ([10.252.81.123]) by mmp2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0NT000DZIJ69AD30@mmp2.samsung.com>; Thu, 13 Aug 2015 17:49:22 +0900 (KST) From: Joonyoung Shim To: rtc-linux@googlegroups.com Cc: linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, a.zummo@towertech.it, alexandre.belloni@free-electrons.com, sbkim73@samsung.com, k.kozlowski@samsung.com, jy0922.shim@samsung.com Subject: [rtc-linux] [PATCH] rtc: s5m: fix to update ctrl register Date: Thu, 13 Aug 2015 17:49:24 +0900 Message-id: <1439455764-23526-1-git-send-email-jy0922.shim@samsung.com> X-Mailer: git-send-email 1.9.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrLLMWRmVeSWpSXmKPExsWyRsSkQFco6kyowYVmSYslF6+yW3RcW8xk 8eLeRRaL1y8MLS7vmsNmMeP8PiaL/Z0djBYXV3xhsliw8RGjA6fHk00XGT32TDzJ5tG3ZRWj x/R5P5k8Pm+SC2CN4rJJSc3JLEst0rdL4MrYduAKc8EkzopnzeuYGxh3s3cxcnJICJhIdJ38 zARhi0lcuLeerYuRi0NIYAWjxO61x+CKvq9shErMYpT49uk8M4Tzg1HiZtdKsHY2AT2JO9uO g9kiAnISNw++YwIpYhZ4wihx8d5qRpCEsICZxNLmJjYQm0VAVaLp418wm1fAXWJh20WoO+Qk Th6bzAph97NLPPwVDlEvIPFt8iGWLkYOoLisxKYDzBAlkhIHV9xgmcAouICRYRWjaGpBckFx UnqRsV5xYm5xaV66XnJ+7iZGYCif/vesfwfj3QPWhxgFOBiVeHg3PDodKsSaWFZcmXuI0RRo w0RmKdHkfGDE5JXEGxqbGVmYmpgaG5lbmimJ8y6U+hksJJCeWJKanZpakFoUX1Sak1p8iJGJ g1OqgXFukUfz+qt3z1/x+ynbrhHNGfLj0eb5j60/OTFEZ5q4X7e14Ov9upRfuT59iV9Iw9qz XySWJua/OfJs2xmRcK1rB9mWzAs8JlFt/mx6VsJn9TTDzpquCl2OzDaHsO/hVZyNF2on7EpK ehe56ojYM+Hg46b34qbanfuQf05vcvPf8pCAGtbNV5RYijMSDbWYi4oTATFbDSRgAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprNIsWRmVeSWpSXmKPExsVy+t9jQV2hqDOhBtO+CFssuXiV3aLj2mIm ixf3LrJYvH5haHF51xw2ixnn9zFZ7O/sYLS4uOILk8WCjY8YHTg9nmy6yOixZ+JJNo++LasY PabP+8nk8XmTXABrVAOjTUZqYkpqkUJqXnJ+SmZeuq2Sd3C8c7ypmYGhrqGlhbmSQl5ibqqt kotPgK5bZg7QQUoKZYk5pUChgMTiYiV9O0wTQkPcdC1gGiN0fUOC4HqMDNBAwhrGjG0HrjAX TOKseNa8jrmBcTd7FyMnh4SAicT3lY1sELaYxIV764FsLg4hgVmMEt8+nWeGcH4wStzsWskE UsUmoCdxZ9txMFtEQE7i5sF3TCBFzAJPGCUu3lvNCJIQFjCTWNrcBDaWRUBVounjXzCbV8Bd YmHbRSaIdXISJ49NZp3AyL2AkWEVo0RqQXJBcVJ6rmFearlecWJucWleul5yfu4mRnDEPJPa wXhwl/shRgEORiUe3g2PTocKsSaWFVfmHmKU4GBWEuE9KncmVIg3JbGyKrUoP76oNCe1+BCj KdABE5mlRJPzgdGcVxJvaGxiZmRpZG5oYWRsriTOK7thc6iQQHpiSWp2ampBahFMHxMHp1QD 48SL63aqncqwNbzPatK/KOyq+KsTC6UqDr0UOXlJ6mSJFG/ahVDuyCvvxP8911/Q9rTs8vTT l2b6Fepr9koXnUw6u//qyRWFX5RCm5WOs2woDuqWezdr06weN+8FTwrUXMLql+xq3JQWtyxr 4fPw3DfLLmXONjjXbvcz3UHFKLpjq3PmUwMLayWW4oxEQy3mouJEAMVin02uAgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jy0922.shim@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jy0922.shim@samsung.com designates 203.254.224.33 as permitted sender) smtp.mailfrom=jy0922.shim@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: rtc-linux@googlegroups.com X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , According to datasheet, the S2MPS13X and S2MPS14X should update write buffer via setting WUDR bit to high after ctrl register is updated. If not, ALARM interrupt of rtc-s5m doesn't happen first time when i use tools/testing/selftests/timers/rtctest.c test program and hour format is used to 12 hour mode in Odroid-XU3 board. Signed-off-by: Joonyoung Shim Cc: Reviewed-by: Krzysztof Kozlowski --- drivers/rtc/rtc-s5m.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c index 8c70d78..03828bb 100644 --- a/drivers/rtc/rtc-s5m.c +++ b/drivers/rtc/rtc-s5m.c @@ -635,6 +635,18 @@ static int s5m8767_rtc_init_reg(struct s5m_rtc_info *info) case S2MPS13X: data[0] = (0 << BCD_EN_SHIFT) | (1 << MODEL24_SHIFT); ret = regmap_write(info->regmap, info->regs->ctrl, data[0]); + if (ret < 0) + break; + + ret = regmap_update_bits(info->regmap, + info->regs->rtc_udr_update, + info->regs->rtc_udr_mask, + info->regs->rtc_udr_mask); + if (ret < 0) + break; + + ret = s5m8767_wait_for_udr_update(info); + break; default: