From patchwork Tue Aug 11 11:28:19 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joonyoung Shim X-Patchwork-Id: 505934 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-pa0-x23a.google.com (mail-pa0-x23a.google.com [IPv6:2607:f8b0:400e:c03::23a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 8259D140328 for ; Tue, 11 Aug 2015 21:28:26 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.b=HleSxnQp; dkim-atps=neutral Received: by pacum4 with SMTP id um4sf45378748pac.1 for ; Tue, 11 Aug 2015 04:28:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=mime-version:from:to:cc:subject:date:message-id:dlp-filter :x-original-sender:x-original-authentication-results:reply-to :content-type:precedence:mailing-list:list-id :x-spam-checked-in-group:list-post:list-help:list-archive:sender :list-subscribe:list-unsubscribe; bh=dpVLjs5jpH3HqQX5kd+lE/+sHAZmN2PJgDGCUcVsWiQ=; b=HleSxnQp0z6hDZysQCVrU5IA16sr5+Qj5Tv0wkZIoHksvM4bBTQt+ZzKXVEH4PWp0N jMbBaa4NoLmu8ZXF3dAUCowd+4S/MfJLrLAtMQQmCi3IMf+xtUfTxewS+yANgfRLKF08 wtiHfj51iVJ0LLZHAaVreA0by/bsb4MXFVmYgFEfpaJaDSJou8QWcx1vgNQTlOuc0383 YwX+BLM1HjFSBCWySxyLq2Vf8QttuQg6TXljMtXTopv6FNNRQPiEbhwzPG+5ejvu18WF jSO2ihqoSeXrTjGSm+nfdLv/hvi25aOcKM7x08IOvlyM6zZI02dBaKtmRXmJMUSTNnGd Nikg== X-Received: by 10.50.43.133 with SMTP id w5mr218610igl.0.1439292504834; Tue, 11 Aug 2015 04:28:24 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.83.8 with SMTP id m8ls3904igy.39.gmail; Tue, 11 Aug 2015 04:28:24 -0700 (PDT) X-Received: by 10.107.170.87 with SMTP id t84mr15945117ioe.18.1439292504557; Tue, 11 Aug 2015 04:28:24 -0700 (PDT) Received: from mailout1.samsung.com (mailout1.samsung.com. [203.254.224.24]) by gmr-mx.google.com with ESMTPS id fy14si160785pdb.2.2015.08.11.04.28.24 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 11 Aug 2015 04:28:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of jy0922.shim@samsung.com designates 203.254.224.24 as permitted sender) client-ip=203.254.224.24; Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NSX02XXP17AKJB0@mailout1.samsung.com> for rtc-linux@googlegroups.com; Tue, 11 Aug 2015 20:28:22 +0900 (KST) Received: from epcpsbgm2new.samsung.com ( [172.20.52.115]) by epcpsbgr1.samsung.com (EPCPMTA) with SMTP id 57.EF.29324.65CD9C55; Tue, 11 Aug 2015 20:28:22 +0900 (KST) X-AuditID: cbfee68d-f79106d00000728c-80-55c9dc56e863 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2new.samsung.com (EPCPMTA) with SMTP id 91.BB.07062.55CD9C55; Tue, 11 Aug 2015 20:28:21 +0900 (KST) Received: from localhost.localdomain ([10.252.81.123]) by mmp1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0NSX00CU9179S570@mmp1.samsung.com>; Tue, 11 Aug 2015 20:28:21 +0900 (KST) From: Joonyoung Shim To: rtc-linux@googlegroups.com Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, a.zummo@towertech.it, alexandre.belloni@free-electrons.com, cw00.choi@samsung.com, k.kozlowski@samsung.com, jy0922.shim@samsung.com Subject: [rtc-linux] [PATCH 1/4] rtc: s3c: add missing clk control Date: Tue, 11 Aug 2015 20:28:19 +0900 Message-id: <1439292502-22912-1-git-send-email-jy0922.shim@samsung.com> X-Mailer: git-send-email 1.9.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrGLMWRmVeSWpSXmKPExsWyRsSkWDfszslQg10vWSyWXLzKbtFxbTGT xfUvz1ktXty7yGLx+oWhxeVdc9gsZpzfx2Sxv7OD0YHD48mmi4weeyaeZPPo27KK0WP6vJ9M Hp83yQWwRnHZpKTmZJalFunbJXBlPN6jVNDCUbHi5xSWBsY7bF2MnBwSAiYS86ddZoSwxSQu 3FsPFOfiEBJYwSixvmkjXNGl1b+ZIBJLGSWeXNzBCOH8YJRY8XsXE0gVm4CexJ1tx8FsEQE5 iZsH34HZzAJnGCUaTiaB2MICZhJvNx1gAbFZBFQlTl9fwtzFyMHBK+AuMX2yF8QyOYmTxyaz gsyXEGhml+hYcgGqXkDi2+RDLCD1EgKyEpsOMEPUS0ocXHGDZQKj4AJGhlWMoqkFyQXFSelF hnrFibnFpXnpesn5uZsYgcF7+t+z3h2Mtw9YH2IU4GBU4uEV8DwZKsSaWFZcmXuI0RRow0Rm KdHkfGCM5JXEGxqbGVmYmpgaG5lbmimJ8ypK/QwWEkhPLEnNTk0tSC2KLyrNSS0+xMjEwSnV wDhlguZvpyPyulMWnS+v04udc/xPs42Y7fMMgfIay2PZcnEyPNNfbzj3wHGCwdG4mauv5Tzc 9CyS+fqqf3ynQ6XnrKgPEbZXt3gUusn/q+WSi2/PxZrc7tKb8stK/aqGY21ABdeMhct4WZiv Tf1xb151YnvzyXVfuY1/uXKJHQsRtp1q6q50cqYSS3FGoqEWc1FxIgDlQQB6WQIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprIIsWRmVeSWpSXmKPExsVy+t9jAd2wOydDDXgtlly8ym7RcW0xk8X1 L89ZLV7cu8hi8fqFocXlXXPYLGac38dksb+zg9GBw+PJpouMHnsmnmTz6NuyitFj+ryfTB6f N8kFsEY1MNpkpCampBYppOYl56dk5qXbKnkHxzvHm5oZGOoaWlqYKynkJeam2iq5+AToumXm AF2ipFCWmFMKFApILC5W0rfDNCE0xE3XAqYxQtc3JAiux8gADSSsYcx4vEepoIWjYsXPKSwN jHfYuhg5OSQETCQurf7NBGGLSVy4tx4ozsUhJLCUUeLJxR2MEM4PRokVv3eBVbEJ6Enc2XYc zBYRkJO4efAdmM0scIZRouFkEogtLGAm8XbTARYQm0VAVeL09SXMXYwcHLwC7hLTJ3tBLJOT OHlsMusERu4FjAyrGCVSC5ILipPSc43yUsv1ihNzi0vz0vWS83M3MYKj45n0DsbDu9wPMQpw MCrx8Ap4ngwVYk0sK67MPcQowcGsJMLLcRooxJuSWFmVWpQfX1Sak1p8iNEUaP9EZinR5Hxg 5OaVxBsam5gZWRqZG1oYGZsrifPqm2wKFRJITyxJzU5NLUgtgulj4uCUamBcLGr1zmCjQ91B VuO4T9Iu+1eyBO9bGFYT15DOvHNlybR7S9nvTHm8KPfpweVVeY0FSpO2Rwap1bzM77c4tkRs jpAx1+1dIRu8i/vnlj7SXbJOwae5Wa/j1LXu3VqPTwiumH1z+sotjreclzr03kmoOzIvKtTj 54rlS6aJS8xPM6h1yFlSyXhEiaU4I9FQi7moOBEAUE3xMqQCAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jy0922.shim@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jy0922.shim@samsung.com designates 203.254.224.24 as permitted sender) smtp.mailfrom=jy0922.shim@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: rtc-linux@googlegroups.com X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , It's missed to call clk_unprepare() about info->rtc_src_clk in s3c_rtc_remove and to call clk_disable_unprepare about info->rtc_clk in error routine of s3c_rtc_probe. Signed-off-by: Joonyoung Shim Reviewed-by: Krzysztof Kozlowski --- drivers/rtc/rtc-s3c.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c index a0f8323..d1866a4 100644 --- a/drivers/rtc/rtc-s3c.c +++ b/drivers/rtc/rtc-s3c.c @@ -410,6 +410,8 @@ static int s3c_rtc_remove(struct platform_device *pdev) s3c_rtc_setaie(info->dev, 0); + if (info->data->needs_src_clk) + clk_unprepare(info->rtc_src_clk); clk_unprepare(info->rtc_clk); info->rtc_clk = NULL; @@ -482,6 +484,7 @@ static int s3c_rtc_probe(struct platform_device *pdev) if (IS_ERR(info->rtc_src_clk)) { dev_err(&pdev->dev, "failed to find rtc source clock\n"); + clk_disable_unprepare(info->rtc_clk); return PTR_ERR(info->rtc_src_clk); } clk_prepare_enable(info->rtc_src_clk);