diff mbox

[2/2] rtc: rtc-ds1374: Remove unused variable

Message ID 1439210865-8611-2-git-send-email-fabio.estevam@freescale.com
State Accepted
Headers show

Commit Message

Fabio Estevam Aug. 10, 2015, 12:47 p.m. UTC
Remove unused variable 'res' and fix the following build warning:

drivers/rtc/rtc-ds1374.c:667:6: warning: unused variable 'res' [-Wunused-variable]

Reported-by: Olof's autobuilder <build@lixom.net>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 drivers/rtc/rtc-ds1374.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Alexandre Belloni Aug. 10, 2015, 2 p.m. UTC | #1
Greg,

Can you take this one or squash it in your misc_deregister patch?

Original is at: http://patchwork.ozlabs.org/patch/505614/

On 10/08/2015 at 09:47:45 -0300, Fabio Estevam wrote :
> Remove unused variable 'res' and fix the following build warning:
> 
> drivers/rtc/rtc-ds1374.c:667:6: warning: unused variable 'res' [-Wunused-variable]
> 
> Reported-by: Olof's autobuilder <build@lixom.net>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  drivers/rtc/rtc-ds1374.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/rtc/rtc-ds1374.c b/drivers/rtc/rtc-ds1374.c
> index 7067232..3b3049c 100644
> --- a/drivers/rtc/rtc-ds1374.c
> +++ b/drivers/rtc/rtc-ds1374.c
> @@ -664,8 +664,6 @@ static int ds1374_remove(struct i2c_client *client)
>  {
>  	struct ds1374 *ds1374 = i2c_get_clientdata(client);
>  #ifdef CONFIG_RTC_DRV_DS1374_WDT
> -	int res;
> -
>  	misc_deregister(&ds1374_miscdev);
>  	ds1374_miscdev.parent = NULL;
>  	unregister_reboot_notifier(&ds1374_wdt_notifier);
> -- 
> 1.9.1
>
Alexandre Belloni Sept. 5, 2015, 11:24 a.m. UTC | #2
On 10/08/2015 at 09:47:45 -0300, Fabio Estevam wrote :
> Remove unused variable 'res' and fix the following build warning:
> 
> drivers/rtc/rtc-ds1374.c:667:6: warning: unused variable 'res' [-Wunused-variable]
> 
> Reported-by: Olof's autobuilder <build@lixom.net>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  drivers/rtc/rtc-ds1374.c | 2 --
>  1 file changed, 2 deletions(-)
> 
Applied, thanks.
diff mbox

Patch

diff --git a/drivers/rtc/rtc-ds1374.c b/drivers/rtc/rtc-ds1374.c
index 7067232..3b3049c 100644
--- a/drivers/rtc/rtc-ds1374.c
+++ b/drivers/rtc/rtc-ds1374.c
@@ -664,8 +664,6 @@  static int ds1374_remove(struct i2c_client *client)
 {
 	struct ds1374 *ds1374 = i2c_get_clientdata(client);
 #ifdef CONFIG_RTC_DRV_DS1374_WDT
-	int res;
-
 	misc_deregister(&ds1374_miscdev);
 	ds1374_miscdev.parent = NULL;
 	unregister_reboot_notifier(&ds1374_wdt_notifier);