From patchwork Tue Aug 4 09:45:30 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandre Belloni X-Patchwork-Id: 503468 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-wi0-x237.google.com (mail-wi0-x237.google.com [IPv6:2a00:1450:400c:c05::237]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 9819014030C for ; Tue, 4 Aug 2015 19:45:49 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.b=yu4VkAoa; dkim-atps=neutral Received: by wibdx1 with SMTP id dx1sf2221669wib.0 for ; Tue, 04 Aug 2015 02:45:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=mime-version:from:to:cc:subject:date:message-id:in-reply-to :references:x-original-sender:x-original-authentication-results :reply-to:content-type:precedence:mailing-list:list-id :x-spam-checked-in-group:list-post:list-help:list-archive:sender :list-subscribe:list-unsubscribe; bh=H1iMC/iHlSi+Lmuh3Bs250YUSu1S81B2ySDgiu5GdqU=; b=yu4VkAoaxrCTSwXEnysdU6eDXFGB3npyMYNTeDjvynMTP7mbl9ZYpERY3HjBFi/2TV 2adrUljRMQRRlVjYxtziyYQYPYd77s1ECW4x9jyrjBQkaGhSPUoFu1v/Kv7qSONzRhtv 6Bd3hYKM/Q0dIZi2glPt3JLt4nWv9WH9DGfFFF52vCmLs8mX1GZ/D5F1ASHXvTMgDKx8 18SVLmXh0C4znQnVUyQmAZhpumnxzXXaFd1ZBOwDKNQQL75W/yhAfOEv0sk3ncQwa2oO Peha/EcbNNrrbXJhwB44Y2ZXlu791zCOCpotWhw5LLR4tDo8YBORPyFso6IaqdB8jvXW qb1Q== X-Received: by 10.152.44.200 with SMTP id g8mr13579lam.41.1438681547176; Tue, 04 Aug 2015 02:45:47 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: rtc-linux@googlegroups.com Received: by 10.152.120.3 with SMTP id ky3ls21719lab.70.gmail; Tue, 04 Aug 2015 02:45:46 -0700 (PDT) X-Received: by 10.112.13.200 with SMTP id j8mr841298lbc.14.1438681546562; Tue, 04 Aug 2015 02:45:46 -0700 (PDT) Received: from mail.free-electrons.com (down.free-electrons.com. [37.187.137.238]) by gmr-mx.google.com with ESMTP id cj6si48396wib.1.2015.08.04.02.45.46 for ; Tue, 04 Aug 2015 02:45:46 -0700 (PDT) Received-SPF: pass (google.com: domain of alexandre.belloni@free-electrons.com designates 37.187.137.238 as permitted sender) client-ip=37.187.137.238; Received: by mail.free-electrons.com (Postfix, from userid 106) id 3FC84166; Tue, 4 Aug 2015 11:45:47 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.free-electrons.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0 Received: from localhost (128-79-216-6.hfc.dyn.abo.bbox.fr [128.79.216.6]) by mail.free-electrons.com (Postfix) with ESMTPSA id 15E5D13FE; Tue, 4 Aug 2015 11:45:44 +0200 (CEST) From: Alexandre Belloni To: rtc-linux@googlegroups.com Cc: Alessandro Zummo , linux-kernel@vger.kernel.org, Alexandre Belloni Subject: [rtc-linux] [PATCH 11/15] rtc: rx8025: fix rx8025_init_client() Date: Tue, 4 Aug 2015 11:45:30 +0200 Message-Id: <1438681534-12027-12-git-send-email-alexandre.belloni@free-electrons.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1438681534-12027-1-git-send-email-alexandre.belloni@free-electrons.com> References: <1438681534-12027-1-git-send-email-alexandre.belloni@free-electrons.com> X-Original-Sender: alexandre.belloni@free-electrons.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of alexandre.belloni@free-electrons.com designates 37.187.137.238 as permitted sender) smtp.mail=alexandre.belloni@free-electrons.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: rtc-linux@googlegroups.com X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , rx8025_init_client is modifying ctrl[0] and writing it to RX8025_REG_CTRL2 but ctrl[0] is actually RX8025_REG_CTRL1. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-rx8025.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-rx8025.c b/drivers/rtc/rtc-rx8025.c index ab5fb4fe2a83..22ce08d6e807 100644 --- a/drivers/rtc/rtc-rx8025.c +++ b/drivers/rtc/rtc-rx8025.c @@ -263,7 +263,7 @@ static int rx8025_init_client(struct i2c_client *client) need_clear = 1; if (need_clear) { - ctrl2 = ctrl[0]; + ctrl2 = ctrl[1]; ctrl2 &= ~(RX8025_BIT_CTRL2_PON | RX8025_BIT_CTRL2_VDET | RX8025_BIT_CTRL2_CTFG | RX8025_BIT_CTRL2_WAFG | RX8025_BIT_CTRL2_DAFG);