From patchwork Sun Jul 26 21:48:31 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Zapolskiy X-Patchwork-Id: 500172 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-lb0-x238.google.com (mail-lb0-x238.google.com [IPv6:2a00:1450:4010:c04::238]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 56B0F140D57 for ; Mon, 27 Jul 2015 07:48:49 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.b=C5D6Bkxw; dkim-atps=neutral Received: by lbbvz8 with SMTP id vz8sf29777649lbb.0 for ; Sun, 26 Jul 2015 14:48:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=mime-version:from:to:cc:subject:date:message-id:in-reply-to :references:x-original-sender:x-original-authentication-results :reply-to:content-type:precedence:mailing-list:list-id :x-spam-checked-in-group:list-post:list-help:list-archive:sender :list-subscribe:list-unsubscribe; bh=Kg3B6yYWDfbTo0zSExCINumz5pIKYw+iaysapCkGY1o=; b=C5D6BkxwLiaD/UYsM3/UvmkKo/OOiq03kQs+pDCYGUVGMDBLNGJzi0WP+CT+YVNyq9 gAHuaolA/XAI0CtGOCbtlnp3qzNV59GQgvZ7P3t2AdqSYQzpkBMosPMmPzNU5UBV5s5u DGkGkCIoyH5p9rIVfzwuUZ6s+Q1V9MT8tqnHXYqk4G5d1ZXclrQjcvyRz4xrKEZFQayO KqoaN4afXoyaB70/l86RMlB9E91vAw3UdhSZNH2GbDL1eYrP7u1DQaJQXWqCe1Z8JFk2 PC4BrU0EaupHZvRD+Ht0e0Mk19VWZKNU/Fcx1Q37vto2udeMXT0M7dAQmaZtwxgW6OB2 0zCg== X-Received: by 10.180.187.226 with SMTP id fv2mr47678wic.1.1437947326915; Sun, 26 Jul 2015 14:48:46 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: rtc-linux@googlegroups.com Received: by 10.180.109.73 with SMTP id hq9ls504237wib.30.canary; Sun, 26 Jul 2015 14:48:46 -0700 (PDT) X-Received: by 10.180.83.33 with SMTP id n1mr4020565wiy.4.1437947326612; Sun, 26 Jul 2015 14:48:46 -0700 (PDT) Received: from mail.mleia.com (li271-223.members.linode.com. [178.79.152.223]) by gmr-mx.google.com with ESMTPS id t6si247181wiz.0.2015.07.26.14.48.46 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 26 Jul 2015 14:48:46 -0700 (PDT) Received-SPF: neutral (google.com: 178.79.152.223 is neither permitted nor denied by best guess record for domain of vz@mleia.com) client-ip=178.79.152.223; Received: from mail.mleia.com (localhost [127.0.0.1]) by mail.mleia.com (Postfix) with ESMTP id AA923101210; Sun, 26 Jul 2015 22:53:58 +0100 (BST) Received: from localhost.localdomain (a91-152-106-128.elisa-laajakaista.fi [91.152.106.128]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mleia.com (Postfix) with ESMTPSA id 68891101211; Sun, 26 Jul 2015 22:53:58 +0100 (BST) From: Vladimir Zapolskiy To: Alessandro Zummo , Alexandre Belloni Cc: rtc-linux@googlegroups.com, Greg Kroah-Hartman Subject: [rtc-linux] [PATCH 06/11] rtc: ds1553: clean up ds1553_nvram_read()/ds1553_nvram_write() Date: Mon, 27 Jul 2015 00:48:31 +0300 Message-Id: <1437947316-5652-7-git-send-email-vz@mleia.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1437947316-5652-1-git-send-email-vz@mleia.com> References: <1437947316-5652-1-git-send-email-vz@mleia.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-49551924 X-CRM114-CacheID: sfid-20150726_225358_720320_5ACE68C9 X-CRM114-Status: GOOD ( 16.57 ) X-Original-Sender: vz@mleia.com X-Original-Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 178.79.152.223 is neither permitted nor denied by best guess record for domain of vz@mleia.com) smtp.mail=vz@mleia.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: rtc-linux@googlegroups.com X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , The change removes redundant sysfs binary file boundary checks, since this task is already done on caller side in fs/sysfs/file.c Signed-off-by: Vladimir Zapolskiy --- drivers/rtc/rtc-ds1553.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-ds1553.c b/drivers/rtc/rtc-ds1553.c index a24e091..38422ab 100644 --- a/drivers/rtc/rtc-ds1553.c +++ b/drivers/rtc/rtc-ds1553.c @@ -245,7 +245,7 @@ static ssize_t ds1553_nvram_read(struct file *filp, struct kobject *kobj, void __iomem *ioaddr = pdata->ioaddr; ssize_t count; - for (count = 0; size > 0 && pos < RTC_OFFSET; count++, size--) + for (count = 0; count < size; count++) *buf++ = readb(ioaddr + pos++); return count; } @@ -260,7 +260,7 @@ static ssize_t ds1553_nvram_write(struct file *filp, struct kobject *kobj, void __iomem *ioaddr = pdata->ioaddr; ssize_t count; - for (count = 0; size > 0 && pos < RTC_OFFSET; count++, size--) + for (count = 0; count < size; count++) writeb(*buf++, ioaddr + pos++); return count; }