| Message ID | 1432901645-17478-1-git-send-email-ldewangan@nvidia.com |
|---|---|
| State | Accepted |
| Headers | show |
On 29/05/2015 at 17:44:05 +0530, Laxman Dewangan wrote : > Initialise the variable high_bb_charging before using it to avoid > configuring wrong value and fix following compilation warning: > > /* > rtc-palmas.c: In function ‘palmas_rtc_probe’: > rtc-palmas.c:242:7: warning: ‘high_bb_charging’ may be used > uninitialized in this function > */ > I didn't find a way to get that warning and I'm interested to know how you got it. I've applied the patch anyway. > Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
diff --git a/drivers/rtc/rtc-palmas.c b/drivers/rtc/rtc-palmas.c index 3b01d56..7ea2c47 100644 --- a/drivers/rtc/rtc-palmas.c +++ b/drivers/rtc/rtc-palmas.c @@ -239,7 +239,7 @@ static int palmas_rtc_probe(struct platform_device *pdev) struct palmas_rtc *palmas_rtc = NULL; int ret; bool enable_bb_charging = false; - bool high_bb_charging; + bool high_bb_charging = false; if (pdev->dev.of_node) { enable_bb_charging = of_property_read_bool(pdev->dev.of_node,
Initialise the variable high_bb_charging before using it to avoid configuring wrong value and fix following compilation warning: /* rtc-palmas.c: In function ‘palmas_rtc_probe’: rtc-palmas.c:242:7: warning: ‘high_bb_charging’ may be used uninitialized in this function */ Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com> --- drivers/rtc/rtc-palmas.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)