From patchwork Mon Jun 9 17:29:52 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Raghavendra Ganiga X-Patchwork-Id: 357576 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-ie0-x23a.google.com (mail-ie0-x23a.google.com [IPv6:2607:f8b0:4001:c03::23a]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 8B75F140092 for ; Tue, 10 Jun 2014 03:30:09 +1000 (EST) Received: by mail-ie0-f186.google.com with SMTP id rl12sf679111iec.3 for ; Mon, 09 Jun 2014 10:30:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=mime-version:from:to:cc:subject:date:message-id:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:list-post:list-help:list-archive:sender:list-subscribe :list-unsubscribe:content-type; bh=q92MlBnqDtx3mUxUgqGbXiNxDuf4PBFJs7CllZGBHxU=; b=fymlCzOCzTdSfrjRHu97z0bDtrz1WI+WAVLY66h0Jdfv721bxMiXR5obYx+V1Rrnla gwwsSckST5UpPTem30XwcHcCz95t4s6iXysbhJmGi1s9c4yePu5ZVR5tTQMgSMD/2MdN bB3yca1AjmLv5G42a/Y5nztpdSGPVotwa7wfWOBkCNmOIztQZvgwTKcolxte6C7rcgD3 hKHDvQ81a+Cly5rdHEAsLgX4RV82w1j5jxDRQusRRZUUJsRlWuw+8Z7HMaAAggvNEJWM iQGgxhrkVXbz4liHUvNFPUQs541nd7w2kpiikDjjqLkEzmqeXuxyAfcqal9qFJ1kxV1P o0Dg== X-Received: by 10.140.51.18 with SMTP id t18mr35679qga.27.1402335006742; Mon, 09 Jun 2014 10:30:06 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: rtc-linux@googlegroups.com Received: by 10.140.104.49 with SMTP id z46ls1698542qge.50.gmail; Mon, 09 Jun 2014 10:30:06 -0700 (PDT) X-Received: by 10.236.9.41 with SMTP id 29mr1106264yhs.23.1402335006429; Mon, 09 Jun 2014 10:30:06 -0700 (PDT) Received: from mail-pb0-x231.google.com (mail-pb0-x231.google.com [2607:f8b0:400e:c01::231]) by gmr-mx.google.com with ESMTPS id zs4si4272274pbc.1.2014.06.09.10.30.06 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 09 Jun 2014 10:30:06 -0700 (PDT) Received-SPF: pass (google.com: domain of ravi23ganiga@gmail.com designates 2607:f8b0:400e:c01::231 as permitted sender) client-ip=2607:f8b0:400e:c01::231; Received: by mail-pb0-f49.google.com with SMTP id jt11so5138601pbb.36 for ; Mon, 09 Jun 2014 10:30:06 -0700 (PDT) X-Received: by 10.68.223.202 with SMTP id qw10mr4831216pbc.163.1402335006313; Mon, 09 Jun 2014 10:30:06 -0700 (PDT) Received: from localhost.localdomain ([219.91.250.13]) by mx.google.com with ESMTPSA id it4sm65051934pbc.39.2014.06.09.10.30.02 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 09 Jun 2014 10:30:05 -0700 (PDT) From: Raghavendra Ganiga To: a.zummo@towertech.it, rtc-linux@googlegroups.com Cc: linux-kernel@vger.kernel.org, Raghavendra Ganiga Subject: [rtc-linux] [PATCH] rtc: add support of nvram for maxim dallas rtc ds1343 Date: Mon, 9 Jun 2014 22:59:52 +0530 Message-Id: <1402334992-3945-1-git-send-email-ravi23ganiga@gmail.com> X-Mailer: git-send-email 1.9.1 X-Original-Sender: ravi23ganiga@gmail.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of ravi23ganiga@gmail.com designates 2607:f8b0:400e:c01::231 as permitted sender) smtp.mail=ravi23ganiga@gmail.com; dkim=pass header.i=@gmail.com; dmarc=pass (p=NONE dis=NONE) header.from=gmail.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , This is a patch to add support of nvram for maxim dallas rtc ds1343 Signed-off-by: Raghavendra Chandra Ganiga --- drivers/rtc/rtc-ds1343.c | 75 ++++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 73 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-ds1343.c b/drivers/rtc/rtc-ds1343.c index c371918..ae9f997 100644 --- a/drivers/rtc/rtc-ds1343.c +++ b/drivers/rtc/rtc-ds1343.c @@ -4,6 +4,7 @@ * Real Time Clock * * Author : Raghavendra Chandra Ganiga + * Ankur Srivastava : DS1343 Nvram Support * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License version 2 as @@ -45,6 +46,9 @@ #define DS1343_CONTROL_REG 0x0F #define DS1343_STATUS_REG 0x10 #define DS1343_TRICKLE_REG 0x11 +#define DS1343_NVRAM 0x20 + +#define DS1343_NVRAM_LEN 96 /* DS1343 Control Registers bits */ #define DS1343_EOSC 0x80 @@ -149,6 +153,64 @@ static ssize_t ds1343_store_glitchfilter(struct device *dev, static DEVICE_ATTR(glitch_filter, S_IRUGO | S_IWUSR, ds1343_show_glitchfilter, ds1343_store_glitchfilter); +static ssize_t ds1343_nvram_write(struct file *filp, struct kobject *kobj, + struct bin_attribute *attr, + char *buf, loff_t off, size_t count) +{ + int ret; + unsigned char address; + struct device *dev = kobj_to_dev(kobj); + struct ds1343_priv *priv = dev_get_drvdata(dev); + + if (unlikely(!count)) + return count; + + if ((count + off) > DS1343_NVRAM_LEN) + count = DS1343_NVRAM_LEN - off; + + address = DS1343_NVRAM + off; + + ret = regmap_bulk_write(priv->map, address, buf, count); + if (ret < 0) + dev_err(&priv->spi->dev, "Error in nvram write %d", ret); + + return (ret < 0) ? ret : count; +} + + +static ssize_t ds1343_nvram_read(struct file *filp, struct kobject *kobj, + struct bin_attribute *attr, + char *buf, loff_t off, size_t count) +{ + int ret; + unsigned char address; + struct device *dev = kobj_to_dev(kobj); + struct ds1343_priv *priv = dev_get_drvdata(dev); + + if (unlikely(!count)) + return count; + + if ((count + off) > DS1343_NVRAM_LEN) + count = DS1343_NVRAM_LEN - off; + + address = DS1343_NVRAM + off; + + ret = regmap_bulk_read(priv->map, address, buf, count); + if (ret < 0) + dev_err(&priv->spi->dev, "Error in nvram read %d\n", ret); + + return (ret < 0) ? ret : count; +} + + +static struct bin_attribute nvram_attr = { + .attr.name = "nvram", + .attr.mode = S_IRUGO | S_IWUSR, + .read = ds1343_nvram_read, + .write = ds1343_nvram_write, + .size = DS1343_NVRAM_LEN, +}; + static ssize_t ds1343_show_alarmstatus(struct device *dev, struct device_attribute *attr, char *buf) { @@ -274,12 +336,16 @@ static int ds1343_sysfs_register(struct device *dev) if (err) goto error1; + err = device_create_bin_file(dev, &nvram_attr); + if (err) + goto error2; + if (priv->irq <= 0) return err; err = device_create_file(dev, &dev_attr_alarm_mode); if (err) - goto error2; + goto error3; err = device_create_file(dev, &dev_attr_alarm_status); if (!err) @@ -287,6 +353,9 @@ static int ds1343_sysfs_register(struct device *dev) device_remove_file(dev, &dev_attr_alarm_mode); +error3: + device_remove_bin_file(dev, &nvram_attr); + error2: device_remove_file(dev, &dev_attr_trickle_charger); @@ -302,6 +371,7 @@ static void ds1343_sysfs_unregister(struct device *dev) device_remove_file(dev, &dev_attr_glitch_filter); device_remove_file(dev, &dev_attr_trickle_charger); + device_remove_bin_file(dev, &nvram_attr); if (priv->irq <= 0) return; @@ -684,6 +754,7 @@ static struct spi_driver ds1343_driver = { module_spi_driver(ds1343_driver); MODULE_DESCRIPTION("DS1343 RTC SPI Driver"); -MODULE_AUTHOR("Raghavendra Chandra Ganiga "); +MODULE_AUTHOR("Raghavendra Chandra Ganiga ," + "Ankur Srivastava "); MODULE_LICENSE("GPL v2"); MODULE_VERSION(DS1343_DRV_VERSION);