From patchwork Thu Dec 19 07:44:00 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Lee, Chun-Yi" X-Patchwork-Id: 303234 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-ob0-x238.google.com (mail-ob0-x238.google.com [IPv6:2607:f8b0:4003:c01::238]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 2D0462C00A6 for ; Thu, 19 Dec 2013 18:45:42 +1100 (EST) Received: by mail-ob0-f184.google.com with SMTP id vb8sf124771obc.1 for ; Wed, 18 Dec 2013 23:45:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=mime-version:from:to:cc:subject:date:message-id:in-reply-to :references:x-original-sender:x-original-authentication-results :reply-to:precedence:mailing-list:list-id:list-post:list-help :list-archive:sender:list-subscribe:list-unsubscribe:content-type; bh=m7XbOg3D3lg2FDqXXFZx7VezUX6UsbmWw2OPNA5l7kQ=; b=BxAx/I7V9pnKl/Wk6UYV4kJHbaqsDMD99m+ZVXs+XEecwGuyJt6t/txOoYv55hEgfR LCMBcKn3Rj3x9inmHz3JFNFFw7KGfpOd88Qtp4XT0tggZ6877KWjjo1l9WQzlkLQgTC8 GHkQfU/g7MQ5GpoF88Rl9VqqllE9JEw81UnKLsWJjL5ENMCr6qNl3CTXOwqC8Zbfygzh 85ZfGq7tDlQaPSm3Kiq512FfTcBFXaVx9S/1XE+LbyCjvodmv9D2i23uq37/KrLtHlCG GXVLRmqo8J3kKpR/34mSc6BtElJwwIYJiirg5AZxYlxvIERKx0sReohv3azy+cjNltWL xzIA== X-Received: by 10.182.84.199 with SMTP id b7mr610obz.13.1387439140540; Wed, 18 Dec 2013 23:45:40 -0800 (PST) MIME-Version: 1.0 X-BeenThere: rtc-linux@googlegroups.com Received: by 10.182.46.134 with SMTP id v6ls254403obm.50.gmail; Wed, 18 Dec 2013 23:45:40 -0800 (PST) X-Received: by 10.183.3.36 with SMTP id bt4mr852obd.29.1387439139952; Wed, 18 Dec 2013 23:45:39 -0800 (PST) Received: from mail-pb0-x230.google.com (mail-pb0-x230.google.com [2607:f8b0:400e:c01::230]) by gmr-mx.google.com with ESMTPS id k45si946339yhn.4.2013.12.18.23.45.39 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 18 Dec 2013 23:45:39 -0800 (PST) Received-SPF: pass (google.com: domain of joeyli.kernel@gmail.com designates 2607:f8b0:400e:c01::230 as permitted sender) client-ip=2607:f8b0:400e:c01::230; Received: by mail-pb0-x230.google.com with SMTP id md12so801749pbc.35 for ; Wed, 18 Dec 2013 23:45:39 -0800 (PST) X-Received: by 10.66.136.101 with SMTP id pz5mr70874pab.118.1387439139688; Wed, 18 Dec 2013 23:45:39 -0800 (PST) Received: from localhost.localdomain ([130.57.30.250]) by mx.google.com with ESMTPSA id fk4sm6658745pab.23.2013.12.18.23.45.30 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Wed, 18 Dec 2013 23:45:38 -0800 (PST) From: "Lee, Chun-Yi" To: "Rafael J. Wysocki" , Alessandro Zummo , "H. Peter Anvin" , Matt Fleming , Matthew Garrett Cc: Elliott@hp.com, samer.el-haj-mahmoud@hp.com, Oliver Neukum , werner@suse.com, trenn@suse.de, JBeulich@suse.com, linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com, x86@kernel.org, "linux-efi@vger.kernel.org" , linux-acpi@vger.kernel.org, "Lee, Chun-Yi" Subject: [rtc-linux] [PATCH 01/14] rtc-efi: fix decrease day twice when computing year days Date: Thu, 19 Dec 2013 15:44:00 +0800 Message-Id: <1387439053-8711-2-git-send-email-jlee@suse.com> X-Mailer: git-send-email 1.6.0.2 In-Reply-To: <1387439053-8711-1-git-send-email-jlee@suse.com> References: <1387439053-8711-1-git-send-email-jlee@suse.com> X-Original-Sender: joeyli.kernel@gmail.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of joeyli.kernel@gmail.com designates 2607:f8b0:400e:c01::230 as permitted sender) smtp.mail=joeyli.kernel@gmail.com; dkim=pass header.i=@gmail.com; dmarc=pass (p=NONE dis=NONE) header.from=gmail.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Compared with the logic in rtc_year_days of efirtc.c, the code in rtc-efi decreases value of day twice when it computing year days. That's becase rtc_year_days in rtc-lib.c already decrease day for return the year days from 0 to 365. --- drivers/rtc/rtc-efi.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/rtc/rtc-efi.c b/drivers/rtc/rtc-efi.c index 797aa02..c4c3843 100644 --- a/drivers/rtc/rtc-efi.c +++ b/drivers/rtc/rtc-efi.c @@ -35,7 +35,7 @@ static inline int compute_yday(efi_time_t *eft) { /* efi_time_t.month is in the [1-12] so, we need -1 */ - return rtc_year_days(eft->day - 1, eft->month - 1, eft->year); + return rtc_year_days(eft->day, eft->month - 1, eft->year); } /* * returns day of the week [0-6] 0=Sunday