From patchwork Fri May 10 08:17:07 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 242932 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-lb0-f190.google.com (mail-lb0-f190.google.com [209.85.217.190]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 3A3F22C00F6 for ; Fri, 10 May 2013 18:17:16 +1000 (EST) Received: by mail-lb0-f190.google.com with SMTP id z5sf812592lbh.17 for ; Fri, 10 May 2013 01:17:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:mime-version:x-beenthere:x-received:received-spf:from:to :cc:subject:date:message-id:x-mailer:in-reply-to:references :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:x-google-group-id:list-post :list-help:list-archive:sender:list-subscribe:list-unsubscribe :content-type; bh=1JxsIIYD5rwa+XgjKbkiKdGhDMBpVzDQPiOo82uzY5Q=; b=h003SuvSIIlnvYT8CCKJn84nEPrLGCUOFc6dkaZ/cxEE5b8FAbf//btApmv4zY64JY 3u66rnwxT6+tSMtVkxcJtVHJF598AfADdYiAFhiBMKDJCekbvI/rjNR3x4My0orxV27W 3d00bieOyi/nrtSPbIZKFPTOAqFoNfuJSJatiJZu1/STbK59u3vxvR8A2Zc+OKHFaPpD IlrbWpMvaAhvUbfdWKLRbSSx6U0bwY6tql6PuVfCnmj+dA6O/MQo1L4zFhDnV4kvFeMw jYGbq6Z0lJF5CJ6cR6Sfqo+3cg+seGDwjfFSZytTvl5/U4Aad1f4UiCP9MNWcOX0ZhiO BMqg== X-Received: by 10.181.13.138 with SMTP id ey10mr24324wid.11.1368173832290; Fri, 10 May 2013 01:17:12 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: rtc-linux@googlegroups.com Received: by 10.180.73.233 with SMTP id o9ls72385wiv.5.canary; Fri, 10 May 2013 01:17:11 -0700 (PDT) X-Received: by 10.204.70.76 with SMTP id c12mr3634208bkj.5.1368173831598; Fri, 10 May 2013 01:17:11 -0700 (PDT) Received: from pokefinder.org (sauhun.de. [89.238.76.85]) by gmr-mx.google.com with ESMTPS id jh7si114990bkb.3.2013.05.10.01.17.11 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 10 May 2013 01:17:11 -0700 (PDT) Received-SPF: pass (google.com: domain of wsa@the-dreams.de designates 89.238.76.85 as permitted sender) client-ip=89.238.76.85; Received: from p5b38793b.dip0.t-ipconnect.de ([91.56.121.59]:12862 helo=localhost) by pokefinder.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.69) (envelope-from ) id 1UaiVm-0001D0-Bp; Fri, 10 May 2013 10:17:08 +0200 From: Wolfram Sang To: linux-kernel@vger.kernel.org Cc: Wolfram Sang , Wan ZongShun , Alessandro Zummo , Stephen Warren , linux-arm-kernel@lists.infradead.org, rtc-linux@googlegroups.com, linux-tegra@vger.kernel.org Subject: [rtc-linux] [RFC 22/42] drivers/rtc: don't check resource with devm_ioremap_resource Date: Fri, 10 May 2013 10:17:07 +0200 Message-Id: <1368173847-5661-23-git-send-email-wsa@the-dreams.de> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1368173847-5661-1-git-send-email-wsa@the-dreams.de> References: <1368173847-5661-1-git-send-email-wsa@the-dreams.de> X-Original-Sender: wsa@the-dreams.de X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of wsa@the-dreams.de designates 89.238.76.85 as permitted sender) smtp.mail=wsa@the-dreams.de Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang Acked-by: Viresh Kumar --- drivers/rtc/rtc-nuc900.c | 6 +----- drivers/rtc/rtc-omap.c | 5 ----- drivers/rtc/rtc-s3c.c | 5 ----- drivers/rtc/rtc-spear.c | 7 +------ drivers/rtc/rtc-tegra.c | 6 ------ 5 files changed, 2 insertions(+), 27 deletions(-) diff --git a/drivers/rtc/rtc-nuc900.c b/drivers/rtc/rtc-nuc900.c index f5dfb6e..c0f54ec 100644 --- a/drivers/rtc/rtc-nuc900.c +++ b/drivers/rtc/rtc-nuc900.c @@ -233,12 +233,8 @@ static int __init nuc900_rtc_probe(struct platform_device *pdev) dev_err(&pdev->dev, "kzalloc nuc900_rtc failed\n"); return -ENOMEM; } - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!res) { - dev_err(&pdev->dev, "platform_get_resource failed\n"); - return -ENXIO; - } + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); nuc900_rtc->rtc_reg = devm_ioremap_resource(&pdev->dev, res); if (IS_ERR(nuc900_rtc->rtc_reg)) return PTR_ERR(nuc900_rtc->rtc_reg); diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c index 4e1bdb8..b0ba3fc 100644 --- a/drivers/rtc/rtc-omap.c +++ b/drivers/rtc/rtc-omap.c @@ -347,11 +347,6 @@ static int __init omap_rtc_probe(struct platform_device *pdev) } res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!res) { - pr_debug("%s: RTC resource data missing\n", pdev->name); - return -ENOENT; - } - rtc_base = devm_ioremap_resource(&pdev->dev, res); if (IS_ERR(rtc_base)) return PTR_ERR(rtc_base); diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c index 14040b2..0b495e8 100644 --- a/drivers/rtc/rtc-s3c.c +++ b/drivers/rtc/rtc-s3c.c @@ -477,11 +477,6 @@ static int s3c_rtc_probe(struct platform_device *pdev) /* get the memory region */ res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (res == NULL) { - dev_err(&pdev->dev, "failed to get memory region resource\n"); - return -ENOENT; - } - s3c_rtc_base = devm_ioremap_resource(&pdev->dev, res); if (IS_ERR(s3c_rtc_base)) return PTR_ERR(s3c_rtc_base); diff --git a/drivers/rtc/rtc-spear.c b/drivers/rtc/rtc-spear.c index 574359c..34eed6a 100644 --- a/drivers/rtc/rtc-spear.c +++ b/drivers/rtc/rtc-spear.c @@ -358,12 +358,6 @@ static int spear_rtc_probe(struct platform_device *pdev) int status = 0; int irq; - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!res) { - dev_err(&pdev->dev, "no resource defined\n"); - return -EBUSY; - } - config = devm_kzalloc(&pdev->dev, sizeof(*config), GFP_KERNEL); if (!config) { dev_err(&pdev->dev, "out of memory\n"); @@ -385,6 +379,7 @@ static int spear_rtc_probe(struct platform_device *pdev) return status; } + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); config->ioaddr = devm_ioremap_resource(&pdev->dev, res); if (IS_ERR(config->ioaddr)) return PTR_ERR(config->ioaddr); diff --git a/drivers/rtc/rtc-tegra.c b/drivers/rtc/rtc-tegra.c index a34315d..76af92a 100644 --- a/drivers/rtc/rtc-tegra.c +++ b/drivers/rtc/rtc-tegra.c @@ -322,12 +322,6 @@ static int __init tegra_rtc_probe(struct platform_device *pdev) return -ENOMEM; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!res) { - dev_err(&pdev->dev, - "Unable to allocate resources for device.\n"); - return -EBUSY; - } - info->rtc_base = devm_ioremap_resource(&pdev->dev, res); if (IS_ERR(info->rtc_base)) return PTR_ERR(info->rtc_base);