| Message ID | 1353313413-17382-1-git-send-email-sivaramn@nvidia.com |
|---|---|
| State | Superseded |
| Headers | show |
On Monday, November 19, 2012 9:24:31 AM UTC+1, Sivaram Nair wrote: > > This is a cosmetic change to rename the irq name to match the device > name. > I have a question regarding irq. There is statically assigned irq in drivers/mfd/tps65910.c static struct resource rtc_resources[] = { { .start = TPS65910_IRQ_RTC_ALARM, .end = TPS65910_IRQ_RTC_ALARM, .flags = IORESOURCE_IRQ, } }; for me it doesn't make much sense, cause it is an external chip and I can attach INT1 pin to any pin on my SoC. How can I assign this pin dynamically? How can I specify it the dts file? Am I missing something? Regards, Yegor
On Monday, November 19, 2012 11:05:19 AM UTC+1, yegorich wrote: > > On Monday, November 19, 2012 9:24:31 AM UTC+1, Sivaram Nair wrote: >> >> This is a cosmetic change to rename the irq name to match the device >> name. >> > > I have a question regarding irq. There is statically assigned irq in > drivers/mfd/tps65910.c > > static struct resource rtc_resources[] = { > { > .start = TPS65910_IRQ_RTC_ALARM, > .end = TPS65910_IRQ_RTC_ALARM, > .flags = IORESOURCE_IRQ, > } > }; > > for me it doesn't make much sense, cause it is an external chip and I can > attach INT1 pin to any pin on my SoC. How can I assign this pin > dynamically? How can I specify it the dts file? > > Am I missing something? > Sorry for the noise. Just found the patches: https://lkml.org/lkml/2012/11/2/324
On 11/19/2012 01:23 AM, Sivaram Nair wrote: > This is a cosmetic change to rename the irq name to match the device > name. I believe you need to repost this to Andrew Morton since he's been picking up RTC patches. You don't need to post the patch to linux-tegra@ since it doesn't have anything to do with Tegra really, even though Tegra happens to use the driver.
diff --git a/drivers/rtc/rtc-tps65910.c b/drivers/rtc/rtc-tps65910.c index 7a82337..e8d44bc 100644 --- a/drivers/rtc/rtc-tps65910.c +++ b/drivers/rtc/rtc-tps65910.c @@ -261,7 +261,7 @@ static int __devinit tps65910_rtc_probe(struct platform_device *pdev) ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, tps65910_rtc_interrupt, IRQF_TRIGGER_LOW, - "rtc-tps65910", &pdev->dev); + dev_name(&pdev->dev), &pdev->dev); if (ret < 0) { dev_err(&pdev->dev, "IRQ is not free.\n"); return ret;
This is a cosmetic change to rename the irq name to match the device name. Signed-off-by: Sivaram Nair <sivaramn@nvidia.com> --- drivers/rtc/rtc-tps65910.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)