From patchwork Tue Apr 7 13:26:25 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Atsushi Nemoto X-Patchwork-Id: 25683 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from wf-out-1516.google.com (wf-out-1516.google.com [209.85.200.161]) by ozlabs.org (Postfix) with ESMTP id 23829DDFD2 for ; Tue, 7 Apr 2009 23:26:26 +1000 (EST) Received: by wf-out-1516.google.com with SMTP id n22so758710wfa.41 for ; Tue, 07 Apr 2009 06:26:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=beta; h=domainkey-signature:received:received:x-sender:x-apparently-to :received:received:received-spf:authentication-results:received:from :to:cc:subject:date:message-id:x-mailer:reply-to:sender:precedence :x-google-loop:mailing-list:list-id:list-post:list-help :list-unsubscribe:x-beenthere-env:x-beenthere; bh=FbON5aVNtoXVLRhkqY5g+oyNg/ppGIgGJwsLL41c/dQ=; b=aWP9X9KY+GOnCqxdR5WKl1M82Iw3OdqvwcRXQ9SC+AnUGY2oZSchNo9BFSTOvHjUFb 4H0dW/HEbHgafpQWMNYzNm/FJc4kk6qw3VTUVxF64JlokP3jpbIokcGErv7UM8Z4Rou7 DBPnlRIxysK6bW/4nDeRic8wxRI3tVCoriT44= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlegroups.com; s=beta; h=x-sender:x-apparently-to:received-spf:authentication-results:from :to:cc:subject:date:message-id:x-mailer:reply-to:sender:precedence :x-google-loop:mailing-list:list-id:list-post:list-help :list-unsubscribe:x-beenthere-env:x-beenthere; b=LrLcbtBukA+J7PBEfhy3LYxR5mTL9+rVQ0Y+KyQqa5pCIabSLaY1ByF0kTfctT6b9/ iZmKuD5V/2kPlqj59P2u1lZa0fKzWBxZU3XYy1FO20cuDOyPfmWx5LOKX61Tg0QXnD0E WvaX1s6s1VFPg/Ihe9I306HNinR6ROOasfRrM= Received: by 10.142.242.11 with SMTP id p11mr13012wfh.29.1239110781163; Tue, 07 Apr 2009 06:26:21 -0700 (PDT) Received: by 10.106.168.10 with SMTP id q10gr2106pre.0; Tue, 07 Apr 2009 06:26:21 -0700 (PDT) X-Sender: anemo@mba.ocn.ne.jp X-Apparently-To: rtc-linux@googlegroups.com Received: by 10.114.25.3 with SMTP id 3mr34580way.2.1239110780834; Tue, 07 Apr 2009 06:26:20 -0700 (PDT) Received: from smtp.mba.ocn.ne.jp (mba.ocn.ne.jp [122.1.235.107]) by gmr-mx.google.com with ESMTP id k32si2974239wah.6.2009.04.07.06.26.20; Tue, 07 Apr 2009 06:26:20 -0700 (PDT) Received-SPF: pass (google.com: domain of anemo@mba.ocn.ne.jp designates 122.1.235.107 as permitted sender) client-ip=122.1.235.107; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of anemo@mba.ocn.ne.jp designates 122.1.235.107 as permitted sender) smtp.mail=anemo@mba.ocn.ne.jp Received: from localhost.localdomain (p3230-ipad212funabasi.chiba.ocn.ne.jp [58.91.167.230]) by smtp.mba.ocn.ne.jp (Postfix) with ESMTP id 5C7C6A994; Tue, 7 Apr 2009 22:26:19 +0900 (JST) From: Atsushi Nemoto To: Alessandro Zummo Cc: rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: [rtc-linux] [PATCH] rtc-ds1553: Drop IRQF_SHARED Date: Tue, 7 Apr 2009 22:26:25 +0900 Message-Id: <1239110785-7680-2-git-send-email-anemo@mba.ocn.ne.jp> X-Mailer: git-send-email 1.5.6.3 Reply-To: rtc-linux@googlegroups.com Sender: rtc-linux@googlegroups.com Precedence: bulk X-Google-Loop: groups Mailing-List: list rtc-linux@googlegroups.com; contact rtc-linux+owner@googlegroups.com List-Id: List-Post: List-Help: List-Unsubscribe: , X-BeenThere-Env: rtc-linux@googlegroups.com X-BeenThere: rtc-linux@googlegroups.com IRQF_SHARED should not be used with IRQF_DISABLED. There is no in-tree user of this driver and only out-of-tree user I know uses a dedicated irq line for this RTC. Signed-off-by: Atsushi Nemoto --- drivers/rtc/rtc-ds1553.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-ds1553.c b/drivers/rtc/rtc-ds1553.c index 38d472b..7172885 100644 --- a/drivers/rtc/rtc-ds1553.c +++ b/drivers/rtc/rtc-ds1553.c @@ -329,8 +329,7 @@ static int __devinit ds1553_rtc_probe(struct platform_device *pdev) if (pdata->irq > 0) { writeb(0, ioaddr + RTC_INTERRUPTS); if (request_irq(pdata->irq, ds1553_rtc_interrupt, - IRQF_DISABLED | IRQF_SHARED, - pdev->name, pdev) < 0) { + IRQF_DISABLED, pdev->name, pdev) < 0) { dev_warn(&pdev->dev, "interrupt not available.\n"); pdata->irq = 0; }