From patchwork Tue Apr 7 13:26:24 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Atsushi Nemoto X-Patchwork-Id: 25682 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from wa-out-1516.google.com (wa-out-1516.google.com [209.85.146.163]) by ozlabs.org (Postfix) with ESMTP id 22B4BDDFB2 for ; Tue, 7 Apr 2009 23:26:25 +1000 (EST) Received: by wa-out-1516.google.com with SMTP id c2so2109616waa.1 for ; Tue, 07 Apr 2009 06:26:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=beta; h=domainkey-signature:received:received:x-sender:x-apparently-to :received:received:received-spf:authentication-results:received:from :to:cc:subject:date:message-id:x-mailer:reply-to:sender:precedence :x-google-loop:mailing-list:list-id:list-post:list-help :list-unsubscribe:x-beenthere-env:x-beenthere; bh=AWvlk3Cxv974jNCY9qxvwHVIImWqAoV5gVwPagX59EI=; b=rZ0n/uKFsq5ft4+Y7FsgO+Z7+4Nwye9IWxEbtQTO8FuDiQ3x66ADu46cLiJV8OGuUc +8LwqEc4pX6yg1fOdoV/JAWkIPBhe3JPvjs2Z/qwv8u9dSlaFu95tKlhIdyA22H3FWfM 5hhVA/AGrWhTmMRJi0p0NwFdwtzhnPoBal3UQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlegroups.com; s=beta; h=x-sender:x-apparently-to:received-spf:authentication-results:from :to:cc:subject:date:message-id:x-mailer:reply-to:sender:precedence :x-google-loop:mailing-list:list-id:list-post:list-help :list-unsubscribe:x-beenthere-env:x-beenthere; b=Xdmr7YRP7bilg76/nx4x3p/R2JyrEwE3zJb0s5MSUacrPPn0I0oEH965nCBY4ZSKId NtxqHXcnrJQi7A0oJmQN9+l+siz/BdRwMw8fwGtfznYW47nt6c2rZKJNGiXLblEBcNNX SppECW2h2v6bgzDDB75Vss1YWxkKO7Vq/McV8= Received: by 10.114.158.1 with SMTP id g1mr16224wae.0.1239110780779; Tue, 07 Apr 2009 06:26:20 -0700 (PDT) Received: by 10.106.129.7 with SMTP id b7gr2105prd.0; Tue, 07 Apr 2009 06:26:20 -0700 (PDT) X-Sender: anemo@mba.ocn.ne.jp X-Apparently-To: rtc-linux@googlegroups.com Received: by 10.115.90.11 with SMTP id s11mr30227wal.20.1239110780302; Tue, 07 Apr 2009 06:26:20 -0700 (PDT) Received: from smtp.mba.ocn.ne.jp (mba.ocn.ne.jp [122.1.235.107]) by gmr-mx.google.com with ESMTP id m37si2931200waf.4.2009.04.07.06.26.19; Tue, 07 Apr 2009 06:26:20 -0700 (PDT) Received-SPF: pass (google.com: domain of anemo@mba.ocn.ne.jp designates 122.1.235.107 as permitted sender) client-ip=122.1.235.107; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of anemo@mba.ocn.ne.jp designates 122.1.235.107 as permitted sender) smtp.mail=anemo@mba.ocn.ne.jp Received: from localhost.localdomain (p3230-ipad212funabasi.chiba.ocn.ne.jp [58.91.167.230]) by smtp.mba.ocn.ne.jp (Postfix) with ESMTP id 4B27DA420; Tue, 7 Apr 2009 22:26:18 +0900 (JST) From: Atsushi Nemoto To: Alessandro Zummo Cc: rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: [rtc-linux] [PATCH] rtc-tx4939: Drop IRQF_SHARED Date: Tue, 7 Apr 2009 22:26:24 +0900 Message-Id: <1239110785-7680-1-git-send-email-anemo@mba.ocn.ne.jp> X-Mailer: git-send-email 1.5.6.3 Reply-To: rtc-linux@googlegroups.com Sender: rtc-linux@googlegroups.com Precedence: bulk X-Google-Loop: groups Mailing-List: list rtc-linux@googlegroups.com; contact rtc-linux+owner@googlegroups.com List-Id: List-Post: List-Help: List-Unsubscribe: , X-BeenThere-Env: rtc-linux@googlegroups.com X-BeenThere: rtc-linux@googlegroups.com IRQF_SHARED should not be used with IRQF_DISABLED. This RTC have a dedicated irq line to SoC's internal interrupt controller so there is no reason to use IRQF_SHARED. Signed-off-by: Atsushi Nemoto --- drivers/rtc/rtc-tx4939.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/rtc/rtc-tx4939.c b/drivers/rtc/rtc-tx4939.c index 4ee4857..4a6ed11 100644 --- a/drivers/rtc/rtc-tx4939.c +++ b/drivers/rtc/rtc-tx4939.c @@ -261,10 +261,8 @@ static int __init tx4939_rtc_probe(struct platform_device *pdev) tx4939_rtc_cmd(pdata->rtcreg, TX4939_RTCCTL_COMMAND_NOP); if (devm_request_irq(&pdev->dev, irq, tx4939_rtc_interrupt, - IRQF_DISABLED | IRQF_SHARED, - pdev->name, &pdev->dev) < 0) { + IRQF_DISABLED, pdev->name, &pdev->dev) < 0) return -EBUSY; - } rtc = rtc_device_register(pdev->name, &pdev->dev, &tx4939_rtc_ops, THIS_MODULE); if (IS_ERR(rtc))