From patchwork Mon Apr 6 16:50:33 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Atsushi Nemoto X-Patchwork-Id: 25646 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from wa-out-1516.google.com (wa-out-1516.google.com [209.85.146.160]) by ozlabs.org (Postfix) with ESMTP id 34588DDEEC for ; Tue, 7 Apr 2009 02:50:34 +1000 (EST) Received: by wa-out-1516.google.com with SMTP id c2so1812702waa.1 for ; Mon, 06 Apr 2009 09:50:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=beta; h=domainkey-signature:received:received:x-sender:x-apparently-to :received:received:received-spf:authentication-results:received:from :to:cc:subject:date:message-id:x-mailer:reply-to:sender:precedence :x-google-loop:mailing-list:list-id:list-post:list-help :list-unsubscribe:x-beenthere-env:x-beenthere; bh=6OqGcCwKpoYNNiJjEtGuf2BhFywMHDGSzRkE26Y8paY=; b=QrH+5Rzaa6ewbtbatpFGtkxyF4/M/cqHQ5HfMOqK4cqrLyc+b5td2934w5UlsuVbhE UnJEnnkwc8ntJ2OpoXQUcm2RXXJVVQ/f9oSI5WaqZuvNVpE1lDveCskrenzt88c+gJH2 uCfJl131qVJgPUJvlJCm3QGpw93AQ1YEp2Yn8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlegroups.com; s=beta; h=x-sender:x-apparently-to:received-spf:authentication-results:from :to:cc:subject:date:message-id:x-mailer:reply-to:sender:precedence :x-google-loop:mailing-list:list-id:list-post:list-help :list-unsubscribe:x-beenthere-env:x-beenthere; b=ptiszkbkOaGdr/WJX1UjDH6gfK6RuenYqp51i+UaWubANbVTL9ymUmlAjVSVVjrKzj zzSsyboK8UzkYY6tsGQikSIoeHJPxX8f1eSqghD4jGwUwakBOSaGaRS2ZQx5NorlRgX2 305yMx41tDXZuX8pnwEiTkKgk8EiyU4Ac/pEo= Received: by 10.141.89.13 with SMTP id r13mr463469rvl.9.1239036629687; Mon, 06 Apr 2009 09:50:29 -0700 (PDT) Received: by 10.107.155.38 with SMTP id h38gr2090pro.0; Mon, 06 Apr 2009 09:50:29 -0700 (PDT) X-Sender: anemo@mba.ocn.ne.jp X-Apparently-To: rtc-linux@googlegroups.com Received: by 10.114.145.17 with SMTP id s17mr446121wad.0.1239036629333; Mon, 06 Apr 2009 09:50:29 -0700 (PDT) Received: from smtp.mba.ocn.ne.jp (mba.ocn.ne.jp [122.1.235.107]) by gmr-mx.google.com with ESMTP id m37si2453784waf.4.2009.04.06.09.50.29; Mon, 06 Apr 2009 09:50:29 -0700 (PDT) Received-SPF: pass (google.com: domain of anemo@mba.ocn.ne.jp designates 122.1.235.107 as permitted sender) client-ip=122.1.235.107; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of anemo@mba.ocn.ne.jp designates 122.1.235.107 as permitted sender) smtp.mail=anemo@mba.ocn.ne.jp Received: from localhost.localdomain (p7250-ipad207funabasi.chiba.ocn.ne.jp [222.145.89.250]) by smtp.mba.ocn.ne.jp (Postfix) with ESMTP id 26DEBA335; Tue, 7 Apr 2009 01:50:28 +0900 (JST) From: Atsushi Nemoto To: Alessandro Zummo Cc: rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: [rtc-linux] [PATCH] rtc-tx4939: Drop IRQF_SHARED Date: Tue, 7 Apr 2009 01:50:33 +0900 Message-Id: <1239036633-10032-3-git-send-email-anemo@mba.ocn.ne.jp> X-Mailer: git-send-email 1.5.6.3 Reply-To: rtc-linux@googlegroups.com Sender: rtc-linux@googlegroups.com Precedence: bulk X-Google-Loop: groups Mailing-List: list rtc-linux@googlegroups.com; contact rtc-linux+owner@googlegroups.com List-Id: List-Post: List-Help: List-Unsubscribe: , X-BeenThere-Env: rtc-linux@googlegroups.com X-BeenThere: rtc-linux@googlegroups.com IRQF_SHARED should be used with IRQF_DISABLED. This RTC have dedicated irq line so there is no reason to use IRQF_SHARED. Signed-off-by: Atsushi Nemoto --- drivers/rtc/rtc-tx4939.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/rtc/rtc-tx4939.c b/drivers/rtc/rtc-tx4939.c index 4ee4857..69085d9 100644 --- a/drivers/rtc/rtc-tx4939.c +++ b/drivers/rtc/rtc-tx4939.c @@ -261,7 +261,7 @@ static int __init tx4939_rtc_probe(struct platform_device *pdev) tx4939_rtc_cmd(pdata->rtcreg, TX4939_RTCCTL_COMMAND_NOP); if (devm_request_irq(&pdev->dev, irq, tx4939_rtc_interrupt, - IRQF_DISABLED | IRQF_SHARED, + IRQF_DISABLED, pdev->name, &pdev->dev) < 0) { return -EBUSY; }