From patchwork Thu Feb 21 08:36:45 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 222205 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-ob0-f187.google.com (mail-ob0-f187.google.com [209.85.214.187]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id E381A2C0090 for ; Thu, 21 Feb 2013 19:36:49 +1100 (EST) Received: by mail-ob0-f187.google.com with SMTP id tb18sf3541636obb.4 for ; Thu, 21 Feb 2013 00:36:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:x-received:received-spf:x-auditid :from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:x-mailer:thread-index:x-brightmail-tracker :x-brightmail-tracker:dlp-filter:x-mtr:x-cfilter-loop :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:x-google-group-id:list-post :list-help:list-archive:sender:list-subscribe:list-unsubscribe :content-type:content-language; bh=zhZhGCF8ENUmBNI3YVC6zJjX4LtAUAZqTecTdRCI2A8=; b=QODSacvV4lAQ4L73XuXzCR2l2TWQUVmVMjdffqq1Y/xEcMTSCTvJLEvNLE/HzlG1CP 0BI5WcEb38rfkN0AmsbSVgHBTb0vDKV5CppVZgm3wxPRFDYuCdmRhYGxZe+pOxqMDdET nwS+lVfiJeNL+dcuKn/J9lvlrCEFYONMZrUiXySuknJlDqHtkqhrjrKPLCb3/dyQk8fA E3ss8geXNDeb+yAZAmBvU99F+qUPImVQUqy7l9NdypfvRgzW8fMhq2LH5H4CdtAFa4Pu sdFM8ooZ6CkJk4wXNVSRxMbIPwU2zUG8FdouaP48HhQS8/4hlXQ+V9zwqyNSnr5gVlIQ 2NSw== X-Received: by 10.50.187.133 with SMTP id fs5mr3020801igc.12.1361435807156; Thu, 21 Feb 2013 00:36:47 -0800 (PST) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.46.129 with SMTP id v1ls161307igm.33.canary; Thu, 21 Feb 2013 00:36:46 -0800 (PST) X-Received: by 10.68.196.229 with SMTP id ip5mr3193834pbc.6.1361435806901; Thu, 21 Feb 2013 00:36:46 -0800 (PST) X-Received: by 10.68.196.229 with SMTP id ip5mr3193833pbc.6.1361435806889; Thu, 21 Feb 2013 00:36:46 -0800 (PST) Received: from mailout1.samsung.com (mailout1.samsung.com. [203.254.224.24]) by gmr-mx.google.com with ESMTP id k3si2639416pax.1.2013.02.21.00.36.46; Thu, 21 Feb 2013 00:36:46 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.24 as permitted sender) client-ip=203.254.224.24; Received: from epcpsbgr3.samsung.com (u143.gpu120.samsung.co.kr [203.254.230.143]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MIK00F8HAKVMKJ0@mailout1.samsung.com> for rtc-linux@googlegroups.com; Thu, 21 Feb 2013 17:36:46 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.51]) by epcpsbgr3.samsung.com (EPCPMTA) with SMTP id 7C.86.03448.D9CD5215; Thu, 21 Feb 2013 17:36:45 +0900 (KST) X-AuditID: cbfee68f-b7f656d000000d78-e2-5125dc9d5a29 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 2A.C3.03880.D9CD5215; Thu, 21 Feb 2013 17:36:45 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MIK0041AAL9XG70@mmp2.samsung.com> for rtc-linux@googlegroups.com; Thu, 21 Feb 2013 17:36:45 +0900 (KST) From: Jingoo Han To: 'Andrew Morton' Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' , rtc-linux@googlegroups.com, 'Jingoo Han' References: <00cc01ce100d$f42fddc0$dc8f9940$%han@samsung.com> In-reply-to: <00cc01ce100d$f42fddc0$dc8f9940$%han@samsung.com> Subject: [rtc-linux] [PATCH 09/12] rtc: rtc-palmas: use devm_request_threaded_irq() Date: Thu, 21 Feb 2013 17:36:45 +0900 Message-id: <00d401ce100e$94f05cd0$bed11670$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4QDe9M0/OnFjrjTvSUwIYm7R1WAgAAJFgw X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrLIsWRmVeSWpSXmKPExsVy+t8zY915d1QDDXbyW+zv7GB0YPTYM/Ek WwBjFJdNSmpOZllqkb5dAlfGnyub2Qveslfs7b3K3MB4hq2LkZ1DQsBE4rBkFyMnkCUmceHe eqAoF4eQwDJGiccz7rBBJEwkrrxcywiRmM4o8eLiDChnJpPEpNbHzCBVbAJqEl++HGbvYuTg EBHQl2hr0QCpYRboZZQ407ubHaRGSMBWYs6Ha2D1nAJ2Epe3fWEFsYUF3CXef9kJVsMioCpx YPFfJhCbF6j+84YGNghbUOLH5HssIDazgJbE+p3HmSBseYnNa94yg+yVEFCXePRXFyQsImAk 8fLSN2aIEhGJfS/eMUI8s45d4vG/GIhVAhLfJh9igWiVldh0gBmiRFLi4IobLBMYJWYhWTwL yeJZSBbPQrJhASPLKkbR1ILkguKk9CJjveLE3OLSvHS95PzcTYyQqOrfwXj3gPUhxmSg9ROZ pUST84FRmVcSb2hsbGJmYmpibmlqbkqasJI4r/wlmUAhgfTEktTs1NSC1KL4otKc1OJDjEwc nFINjOKu7/58qvqqOZs1Y82LTLX3gfll7m6ZIRms/2ZL3Q/7NsO+ocl7Q/6u7P1SbDPn9m/4 l6venyO3POuKtGv7j8c//3w5a+gRPHEt32f30qZ7M9t849/UZty3N/iwXWGV5h920zjBg7WR d1ZX2K/MqX+e41wXbf7Q6m7mkSuiCwXlKxvkTTsnKbEUZyQaajEXFScCAPOfOkvAAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupjleLIzCtJLcpLzFFi42I5/e+xoO7cO6qBBg82Wlrs7+xgdGD02DPx JFsAY1QDo01GamJKapFCal5yfkpmXrqtkndwvHO8qZmBoa6hpYW5kkJeYm6qrZKLT4CuW2YO 0FglhbLEnFKgUEBicbGSvh2mCaEhbroWMI0Rur4hQXA9RgZoIGEdY8afK5vZC96yV+ztvcrc wHiGrYuRk0NCwETiysu1jBC2mMSFe+uB4lwcQgLTGSVeXJzBCOHMZJKY1PqYGaSKTUBN4suX w+xdjBwcIgL6Em0tGiA1zAK9jBJnenezg9QICdhKzPlwDayeU8BO4vK2L6wgtrCAu8T7LzvB algEVCUOLP7LBGLzAtV/3tDABmELSvyYfI8FxGYW0JJYv/M4E4QtL7F5zVtmkL0SAuoSj/7q goRFBIwkXl76xgxRIiKx78U7xgmMQrOQTJqFZNIsJJNmIWlZwMiyilE0tSC5oDgpPddIrzgx t7g0L10vOT93EyM4dp9J72Bc1WBxiFGAg1GJh3fBS5VAIdbEsuLK3EOMEhzMSiK8irdVA4V4 UxIrq1KL8uOLSnNSiw8xJgM9OpFZSjQ5H5hW8kriDY1NzIwsjcwsjEzMzUkTVhLnZTz1JEBI ID2xJDU7NbUgtQhmCxMHp1QD44Rdf9L5puxR3zcr5mpb97O0S1tMmhPvKrw+1XLiLN/5m8+O fmMpstn46+b/dzcUt387b8P0y+Nv4n/h6WlL9D/0mhyO23TpkLrvwUUnduULpH1U37Lv09mU BZr5U1/P297E8VrTMyKrNvt5ea9eaa2Q5yaFtPJHNvtsz95P/PDwksv2Y3NaHM4rsRRnJBpq MRcVJwIA4yl+liEDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.24 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-type: text/plain; charset=ISO-8859-1 Content-language: ko Use devm_request_threaded_irq() to make cleanup paths more simple. Signed-off-by: Jingoo Han --- drivers/rtc/rtc-palmas.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-palmas.c b/drivers/rtc/rtc-palmas.c index 59c4298..df9359c 100644 --- a/drivers/rtc/rtc-palmas.c +++ b/drivers/rtc/rtc-palmas.c @@ -272,7 +272,7 @@ static int palmas_rtc_probe(struct platform_device *pdev) return ret; } - ret = request_threaded_irq(palmas_rtc->irq, NULL, + ret = devm_request_threaded_irq(&pdev->dev, palmas_rtc->irq, NULL, palmas_rtc_interrupt, IRQF_TRIGGER_LOW | IRQF_ONESHOT | IRQF_EARLY_RESUME, @@ -292,7 +292,6 @@ static int palmas_rtc_remove(struct platform_device *pdev) struct palmas_rtc *palmas_rtc = platform_get_drvdata(pdev); palmas_rtc_alarm_irq_enable(&pdev->dev, 0); - free_irq(palmas_rtc->irq, palmas_rtc); rtc_device_unregister(palmas_rtc->rtc); return 0; }