From patchwork Thu Feb 21 08:36:09 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 222204 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-qc0-f192.google.com (mail-qc0-f192.google.com [209.85.216.192]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 6BAB92C0090 for ; Thu, 21 Feb 2013 19:36:14 +1100 (EST) Received: by mail-qc0-f192.google.com with SMTP id g10sf3576910qcs.19 for ; Thu, 21 Feb 2013 00:36:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:x-received:received-spf:x-auditid :from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:x-mailer:thread-index:x-brightmail-tracker :x-brightmail-tracker:dlp-filter:x-mtr:x-cfilter-loop :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:x-google-group-id:list-post :list-help:list-archive:sender:list-subscribe:list-unsubscribe :content-type:content-language; bh=JUxkBSF14IwHd4xfIA2C5k0EZMn7JKnPnYTac/6enLY=; b=Nw4JbTwRIrWSMrbrnHUKeeKIZKXQarijrj8+gIWb0y16vWdzO4vVtbC7CPkmQ9KsSV jqVFoEMKlGeun6xK9uIz3dDyGtsY4mvZ6K+jCJRWIFxmqPt9CKDCzYyjtRkKBWr+5E+/ +owljeIMXprs2AhFA7LIh9LjOiAJb8zTcK0XjLq7lcz3srEgL/PDG6eRybZYi7pkG40g DXtjiyoFAUZYVQb9IkPHFB3uvTN8tws/2vEyHmrPjvzna93BmIJZfJ7ytxh/k0QNHDkt s/X/w2s+X/XXH+R2myv4p72YRiLLiKyPKrkk3cu1ZZ9Ai+LAd5VS7erFI4mqU4j7R9sC CEEg== X-Received: by 10.50.161.225 with SMTP id xv1mr2749291igb.15.1361435771622; Thu, 21 Feb 2013 00:36:11 -0800 (PST) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.154.167 with SMTP id vp7ls157174igb.38.canary; Thu, 21 Feb 2013 00:36:11 -0800 (PST) X-Received: by 10.66.162.163 with SMTP id yb3mr3462804pab.14.1361435771385; Thu, 21 Feb 2013 00:36:11 -0800 (PST) X-Received: by 10.66.162.163 with SMTP id yb3mr3462803pab.14.1361435771371; Thu, 21 Feb 2013 00:36:11 -0800 (PST) Received: from mailout4.samsung.com (mailout4.samsung.com. [203.254.224.34]) by gmr-mx.google.com with ESMTP id d9si3870446paw.0.2013.02.21.00.36.11; Thu, 21 Feb 2013 00:36:11 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.34 as permitted sender) client-ip=203.254.224.34; Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MIK001SOAK7QSG0@mailout4.samsung.com> for rtc-linux@googlegroups.com; Thu, 21 Feb 2013 17:36:10 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.47]) by epcpsbgr1.samsung.com (EPCPMTA) with SMTP id CB.9E.16905.A7CD5215; Thu, 21 Feb 2013 17:36:10 +0900 (KST) X-AuditID: cbfee68d-b7f4f6d000004209-e8-5125dc7aee49 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 72.93.03880.A7CD5215; Thu, 21 Feb 2013 17:36:10 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MIK00CLLAKAC310@mmp1.samsung.com> for rtc-linux@googlegroups.com; Thu, 21 Feb 2013 17:36:10 +0900 (KST) From: Jingoo Han To: 'Andrew Morton' Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' , rtc-linux@googlegroups.com, 'Jingoo Han' References: <00cc01ce100d$f42fddc0$dc8f9940$%han@samsung.com> In-reply-to: <00cc01ce100d$f42fddc0$dc8f9940$%han@samsung.com> Subject: [rtc-linux] [PATCH 08/12] rtc: rtc-da9052: use devm_request_threaded_irq() Date: Thu, 21 Feb 2013 17:36:09 +0900 Message-id: <00d301ce100e$7fced110$7f6c7330$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4QDe9M0/OnFjrjTvSUwIYm7R1WAgAAIA7Q X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrHIsWRmVeSWpSXmKPExsVy+t8zfd2qO6qBBh9uy1rs7+xgdGD02DPx JFsAYxSXTUpqTmZZapG+XQJXxpdle1gKdvFWbOzmbWBs5+5i5OSQEDCRWHrhIhOELSZx4d56 ti5GLg4hgWWMEkcmnmLtYuQAK1qwSgwivohR4t2E44wQzkwmiWvbTjGDdLMJqEl8+XKYHaRB REBfoq1FA6SGWaCXUeJM7252kBohAVuJOR+ugdVzCthJXN72hRXEFhZwl/jTOIkFxGYRUJXY cuMGC8gcXqD61oNVIGFeAUGJH5PvgZUwC2hJrN95nAnClpfYvOYtM8Sd6hKP/uqChEUEjCQW LrgGVSIise/FO7CTJQRWsUvcetLBDLFKQOLb5EMsEL2yEpsOMEPCQVLi4IobLBMYJWYh2TwL yeZZSDbPQrJiASPLKkbR1ILkguKk9CJDveLE3OLSvHS95PzcTYyQuOrdwXj7gPUhxmSg9ROZ pUST84FxmVcSb2hsbGJmYmpibmlqbkqasJI4r9wlmUAhgfTEktTs1NSC1KL4otKc1OJDjEwc nFINjPy7Ji6f78V/0uQC579Oz/0zpp+Y+nr3Dk95/ds/uqf7zv2uvHfPyZRvL5PWVJ//tFzQ U+ffk71Ml2MqHngE/cpXLZbht+dT2hb79eeFE77u89aV/rY+O0dJO2DCl3Pzrl+Z/WGG329L Q2OL2jmR7QeP2E48lWbgY5Su8WfjZ9eGZX6Tj5SoHHyhxFKckWioxVxUnAgAtdUF/cECAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupmleLIzCtJLcpLzFFi42I5/e+xgG7VHdVAg2/3JS32d3YwOjB67Jl4 ki2AMaqB0SYjNTEltUghNS85PyUzL91WyTs43jne1MzAUNfQ0sJcSSEvMTfVVsnFJ0DXLTMH aKySQlliTilQKCCxuFhJ3w7ThNAQN10LmMYIXd+QILgeIwM0kLCOMePLsj0sBbt4KzZ28zYw tnN3MXJwSAiYSCxYJdbFyAlkiklcuLeerYuRi0NIYBGjxLsJxxkhnJlMEte2nWIGqWITUJP4 8uUwO0iziIC+RFuLBkgNs0Avo8SZ3t3sIDVCArYScz5cA6vnFLCTuLztCyuILSzgLvGncRIL iM0ioCqx5cYNFpA5vED1rQerQMK8AoISPybfAythFtCSWL/zOBOELS+xec1bZoib1SUe/dUF CYsIGEksXHANqkREYt+Ld4wTGIVmIZk0C8mkWUgmzULSsoCRZRWjaGpBckFxUnqukV5xYm5x aV66XnJ+7iZGcNQ+k97BuKrB4hCjAAejEg/vgpcqgUKsiWXFlbmHGCU4mJVEeBVvqwYK8aYk VlalFuXHF5XmpBYfYkwG+nMis5Rocj4woeSVxBsam5gZWRqZWRiZmJuTJqwkzst46kmAkEB6 YklqdmpqQWoRzBYmDk6pBsaZR0remj9zLZy86XHm8r2y17wnCxyeu+/Hk95wPua3nt91V27Y VBUlqPzszHb+Dp6/H7xvbgh59eGhhEpazum9Mo4uZ6NcFcNeJ71aeXzeuilq110yXq11MC40 CTsU6vl8ttOl2opt8VcX3uKNLN9aEDvRfeF/Q7uQlX1LpFuPbJ35wOvtU69oJZbijERDLeai 4kQA+WcaTx4DAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.34 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-type: text/plain; charset=ISO-8859-1 Content-language: ko Use devm_request_threaded_irq() to make cleanup paths more simple. Signed-off-by: Jingoo Han --- drivers/rtc/rtc-da9052.c | 18 ++++++------------ 1 files changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/rtc/rtc-da9052.c b/drivers/rtc/rtc-da9052.c index 60b826e..0dde688 100644 --- a/drivers/rtc/rtc-da9052.c +++ b/drivers/rtc/rtc-da9052.c @@ -240,9 +240,10 @@ static int da9052_rtc_probe(struct platform_device *pdev) rtc->da9052 = dev_get_drvdata(pdev->dev.parent); platform_set_drvdata(pdev, rtc); rtc->irq = platform_get_irq_byname(pdev, "ALM"); - ret = request_threaded_irq(rtc->irq, NULL, da9052_rtc_irq, - IRQF_TRIGGER_LOW | IRQF_ONESHOT, - "ALM", rtc); + ret = devm_request_threaded_irq(&pdev->dev, rtc->irq, NULL, + da9052_rtc_irq, + IRQF_TRIGGER_LOW | IRQF_ONESHOT, + "ALM", rtc); if (ret != 0) { rtc_err(rtc->da9052, "irq registration failed: %d\n", ret); return ret; @@ -250,16 +251,10 @@ static int da9052_rtc_probe(struct platform_device *pdev) rtc->rtc = rtc_device_register(pdev->name, &pdev->dev, &da9052_rtc_ops, THIS_MODULE); - if (IS_ERR(rtc->rtc)) { - ret = PTR_ERR(rtc->rtc); - goto err_free_irq; - } + if (IS_ERR(rtc->rtc)) + return PTR_ERR(rtc->rtc); return 0; - -err_free_irq: - free_irq(rtc->irq, rtc); - return ret; } static int da9052_rtc_remove(struct platform_device *pdev) @@ -267,7 +262,6 @@ static int da9052_rtc_remove(struct platform_device *pdev) struct da9052_rtc *rtc = pdev->dev.platform_data; rtc_device_unregister(rtc->rtc); - free_irq(rtc->irq, rtc); platform_set_drvdata(pdev, NULL); return 0;