From patchwork Thu Feb 21 08:35:40 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 222203 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-qe0-f62.google.com (mail-qe0-f62.google.com [209.85.128.62]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id A39632C0090 for ; Thu, 21 Feb 2013 19:35:45 +1100 (EST) Received: by mail-qe0-f62.google.com with SMTP id 3sf3508597qea.17 for ; Thu, 21 Feb 2013 00:35:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:x-received:received-spf:x-auditid :from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:x-mailer:thread-index:x-brightmail-tracker :x-brightmail-tracker:dlp-filter:x-mtr:x-cfilter-loop :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:x-google-group-id:list-post :list-help:list-archive:sender:list-subscribe:list-unsubscribe :content-type:content-language; bh=/i5xuk84OQiiHAMh8AuTqBrYmmVr7NVPVVLpUDnPUVI=; b=ZT7GNcaSItjMhnjwGRoJg/qqKjolWgQzVDNOrMkHuberWW1kdXnK0QcCx6BnWiGCqC arCOuXVzUaYEbxldA4mzO2K4MX+rmy0I2lyk9aEw9dRK5OTbeYY8Aqa8fuNkpv65qUv+ XRkQh61hO7CIGnhEO208KrKYZ5Ogwglav+KkehMbQ7xhDeXynm1CMjteRdVau4h/STOP DVxE+1GAUCmTe0qwPNHONJCkU64ZDan+I5C9zV7IlzQPPbbZnGje5q3ZyJqNkBS9jhp+ mfCYauAd1clNjV1GnpfK25jvzaqx2y0xgiRFjgs8DzxFUfjHwtIuZrzQq2Nm+0axuHpx /X5Q== X-Received: by 10.50.187.133 with SMTP id fs5mr3020721igc.12.1361435742858; Thu, 21 Feb 2013 00:35:42 -0800 (PST) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.15.193 with SMTP id z1ls197610igc.19.gmail; Thu, 21 Feb 2013 00:35:42 -0800 (PST) X-Received: by 10.66.251.193 with SMTP id zm1mr2446064pac.15.1361435742462; Thu, 21 Feb 2013 00:35:42 -0800 (PST) X-Received: by 10.66.251.193 with SMTP id zm1mr2446063pac.15.1361435742450; Thu, 21 Feb 2013 00:35:42 -0800 (PST) Received: from mailout1.samsung.com (mailout1.samsung.com. [203.254.224.24]) by gmr-mx.google.com with ESMTP id ka10si4407595pbb.2.2013.02.21.00.35.42; Thu, 21 Feb 2013 00:35:42 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.24 as permitted sender) client-ip=203.254.224.24; Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MIK00JO1AJBGNG0@mailout1.samsung.com> for rtc-linux@googlegroups.com; Thu, 21 Feb 2013 17:35:41 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.51]) by epcpsbgr5.samsung.com (EPCPMTA) with SMTP id B1.08.06692.D5CD5215; Thu, 21 Feb 2013 17:35:41 +0900 (KST) X-AuditID: cbfee691-b7f556d000001a24-81-5125dc5d10e9 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 8E.63.03880.D5CD5215; Thu, 21 Feb 2013 17:35:41 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MIK00CE1AJGC310@mmp1.samsung.com> for rtc-linux@googlegroups.com; Thu, 21 Feb 2013 17:35:41 +0900 (KST) From: Jingoo Han To: 'Andrew Morton' Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' , rtc-linux@googlegroups.com, 'Jingoo Han' References: <00cc01ce100d$f42fddc0$dc8f9940$%han@samsung.com> In-reply-to: <00cc01ce100d$f42fddc0$dc8f9940$%han@samsung.com> Subject: [rtc-linux] [PATCH 07/12] rtc: rtc-wm831x: use devm_request_threaded_irq() Date: Thu, 21 Feb 2013 17:35:40 +0900 Message-id: <00d201ce100e$6e66f1f0$4b34d5d0$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4QDe9M0/OnFjrjTvSUwIYm7R1WAgAAHGNA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrAIsWRmVeSWpSXmKPExsVy+t8zY93YO6qBBnP2CVjs7+xgdGD02DPx JFsAYxSXTUpqTmZZapG+XQJXxoV9fawFszkr9j32aWA8zN7FyMkhIWAicehaAxOELSZx4d56 ti5GLg4hgWWMEjMez2WCKTo95yETRGIRo8TNczegqmYySaz5NosFpIpNQE3iyxeQsRwcIgL6 Em0tGiA1zAK9jBJneneDrRMSsJWY8+EaM4jNKWAncXnbF1YQW1jAXWJ/wzI2EJtFQFVi862l YJt5geo/fVwLZQtK/Jh8D2wXs4CWxPqdx5kgbHmJzWveMoPslRBQl3j0VxckLCJgJNF1cApU uYjEvhfvGEHukRBYxC7RefoXE8QuAYlvkw+xQPTKSmw6wAzxsKTEwRU3WCYwSsxCsnkWks2z kGyehWTFAkaWVYyiqQXJBcVJ6UWmesWJucWleel6yfm5mxghsTVxB+P9A9aHGJOB1k9klhJN zgfGZl5JvKGxsYmZiamJuaWpuSlpwkrivPKXZAKFBNITS1KzU1MLUovii0pzUosPMTJxcEo1 MB6Z7TFZ0POo0eQqidN6pinpqrreD+SbnJqE9xUenHD9QuGmLwFmxUzFiRfq9EOWfTjZYnpu BevVXb/2PuIo3XDqP3vgtOzwz2tWnznTMvFfx6SMuEk9f4/8Yv29K6c3g/vap4LlE259P7C9 ea7cjgc7LbbYKnpfs62fabnlVXzQLVMtwY2PdP8psRRnJBpqMRcVJwIATtzShMMCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuplleLIzCtJLcpLzFFi42I5/e+xgG7sHdVAg1XbeCz2d3YwOjB67Jl4 ki2AMaqB0SYjNTEltUghNS85PyUzL91WyTs43jne1MzAUNfQ0sJcSSEvMTfVVsnFJ0DXLTMH aKySQlliTilQKCCxuFhJ3w7ThNAQN10LmMYIXd+QILgeIwM0kLCOMePCvj7WgtmcFfse+zQw HmbvYuTkkBAwkTg95yEThC0mceHeerYuRi4OIYFFjBI3z92AcmYySaz5NosFpIpNQE3iyxeQ bg4OEQF9ibYWDZAaZoFeRokzvbvBpgoJ2ErM+XCNGcTmFLCTuLztCyuILSzgLrG/YRkbiM0i oCqx+dZSsM28QPWfPq6FsgUlfky+B7aLWUBLYv3O40wQtrzE5jVvmUH2SgioSzz6qwsSFhEw kug6OAWqXERi34t3jBMYhWYhmTQLyaRZSCbNQtKygJFlFaNoakFyQXFSeq6RXnFibnFpXrpe cn7uJkZw5D6T3sG4qsHiEKMAB6MSD++ClyqBQqyJZcWVuYcYJTiYlUR4FW+rBgrxpiRWVqUW 5ccXleakFh9iTAZ6dCKzlGhyPjCp5JXEGxqbmBlZGplZGJmYm5MmrCTOy3jqSYCQQHpiSWp2 ampBahHMFiYOTqkGRteb1y/GOr3/9K/XQfCv9Dy+pc6ivxfpTbvwcUXIApXZuZaHxOefa+1z y521K+7w/Fv3/nPVyC+9Zjz/ykPeNXU168Wy1aL2c/j/6tqtcE1muoVT3zvXpbU7BdiP+LFP fN07sWm+Mvef3DCtIJeS+yWyEsu+1XD/ZReMiC08qJ8Yc/583tzQj0osxRmJhlrMRcWJANMJ vXwgAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.24 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-type: text/plain; charset=ISO-8859-1 Content-language: ko Use devm_request_threaded_irq() to make cleanup paths more simple. Signed-off-by: Jingoo Han --- drivers/rtc/rtc-wm831x.c | 9 ++++----- 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/rtc/rtc-wm831x.c b/drivers/rtc/rtc-wm831x.c index 1b0affb..2f0ac7b 100644 --- a/drivers/rtc/rtc-wm831x.c +++ b/drivers/rtc/rtc-wm831x.c @@ -443,9 +443,10 @@ static int wm831x_rtc_probe(struct platform_device *pdev) goto err; } - ret = request_threaded_irq(alm_irq, NULL, wm831x_alm_irq, - IRQF_TRIGGER_RISING, "RTC alarm", - wm831x_rtc); + ret = devm_request_threaded_irq(&pdev->dev, alm_irq, NULL, + wm831x_alm_irq, + IRQF_TRIGGER_RISING, "RTC alarm", + wm831x_rtc); if (ret != 0) { dev_err(&pdev->dev, "Failed to request alarm IRQ %d: %d\n", alm_irq, ret); @@ -462,9 +463,7 @@ err: static int wm831x_rtc_remove(struct platform_device *pdev) { struct wm831x_rtc *wm831x_rtc = platform_get_drvdata(pdev); - int alm_irq = platform_get_irq_byname(pdev, "ALM"); - free_irq(alm_irq, wm831x_rtc); rtc_device_unregister(wm831x_rtc->rtc); return 0;