From patchwork Thu Feb 28 08:41:02 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 223821 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-gh0-f192.google.com (mail-gh0-f192.google.com [209.85.160.192]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 55FD62C0040 for ; Thu, 28 Feb 2013 19:41:06 +1100 (EST) Received: by mail-gh0-f192.google.com with SMTP id r20sf665141ghr.9 for ; Thu, 28 Feb 2013 00:41:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:x-received:received-spf:x-auditid :from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:x-mailer:thread-index:x-brightmail-tracker :x-brightmail-tracker:dlp-filter:x-mtr:x-cfilter-loop :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:x-google-group-id:list-post :list-help:list-archive:sender:list-subscribe:list-unsubscribe :content-type:content-language; bh=sniD4mriorqGl+1JllrNqF3XZ8Db7nr8CW0b0Evqm2Q=; b=qwixfNlcSIENyufVNyMzfL+bTHbOlrK1civhhGyDWeSPZ05R7DXe5s5jaaMkF/Mhha hzNGxaarcSpx+rTaFliuKLoCf/IRxZpQ8p7lgTMBFJTZA5+kIDdEK8x4oS3kn7HLFS/Y HbnT1qdXbFUhyPECymmNoFA/WjCCprx9872h+M8dnh1mGFi79VLv9PI0S7MB0jO1rK/4 9tC1c3r1HobPRMBBtzdY+hDIBghxelr0WJ1CKtHC9BgrTRVcW9HWX5w7+iUafIBQHQ+v dlPSXkRVfQjeAZ0kJ2gYxNXT/rQ8P+1woTyinHAFeq3uek0Pl6xojxVy1aNcvsuHX0DA PDrg== X-Received: by 10.50.152.232 with SMTP id vb8mr2860774igb.16.1362040863869; Thu, 28 Feb 2013 00:41:03 -0800 (PST) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.203.40 with SMTP id kn8ls1880902igc.17.canary; Thu, 28 Feb 2013 00:41:03 -0800 (PST) X-Received: by 10.68.210.15 with SMTP id mq15mr1231312pbc.2.1362040863539; Thu, 28 Feb 2013 00:41:03 -0800 (PST) X-Received: by 10.68.210.15 with SMTP id mq15mr1231311pbc.2.1362040863531; Thu, 28 Feb 2013 00:41:03 -0800 (PST) Received: from mailout4.samsung.com (mailout4.samsung.com. [203.254.224.34]) by gmr-mx.google.com with ESMTP id tj3si1698477pbc.0.2013.02.28.00.41.03; Thu, 28 Feb 2013 00:41:03 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.34 as permitted sender) client-ip=203.254.224.34; Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MIX00NU49ES2BH0@mailout4.samsung.com> for rtc-linux@googlegroups.com; Thu, 28 Feb 2013 17:41:02 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.50]) by epcpsbgr1.samsung.com (EPCPMTA) with SMTP id 14.F1.02494.E181F215; Thu, 28 Feb 2013 17:41:02 +0900 (KST) X-AuditID: cbfee68d-b7f636d0000009be-6c-512f181eed65 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id DD.78.03918.E181F215; Thu, 28 Feb 2013 17:41:02 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MIX00I4O9GEEH30@mmp2.samsung.com>; Thu, 28 Feb 2013 17:41:02 +0900 (KST) From: Jingoo Han To: 'Andrew Morton' Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' , rtc-linux@googlegroups.com, 'Jingoo Han' References: <00a501ce158e$ef171610$cd454230$%han@samsung.com> In-reply-to: <00a501ce158e$ef171610$cd454230$%han@samsung.com> Subject: [rtc-linux] [PATCH 06/19] rtc: rtc-mc13xxx: remove erroneous __init/__exit annotations Date: Thu, 28 Feb 2013 17:41:02 +0900 Message-id: <00aa01ce158f$56fc8760$04f59620$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4Vju7DHmrOxtsNRmyyH1DU6RVYuAAAFuUA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrGIsWRmVeSWpSXmKPExsVy+t8zI105Cf1Ag3sr1CyWXLzKbjFn/Ro2 i8sLL7FaXN41h81if2cHowOrx56JJ9k8Tsz4zeLRt2UVo8f0eT+ZPD5vkgtgjeKySUnNySxL LdK3S+DK2PX0FFPBXu6KntfXmBsYL3J2MXJySAiYSNy/9ZgdwhaTuHBvPVsXIxeHkMAyRomD PVuYYYrez33LApGYziix+dFmZgjnF6PEhenbwdrZBNQkvnw5DGRzcIgI6Eu0tWiA1DAL9DJK nOndDVYjJGArcaytjQXE5hSwk/j99CgriC0sECrRfHYbWJxFQFVizsI9YDYvUP2NZ33sELag xI/J98DizAJaEut3HmeCsOUlNq95ywyyV0JAXeLRX12IE4wkplwsh6gQkdj34h0jxC+32CWW PC6F2CQg8W3yIRaITlmJTQeg3pWUOLjiBssERolZSPbOQrJ3FpK9s5BsWMDIsopRNLUguaA4 Kb3IUK84Mbe4NC9dLzk/dxMjJE57dzDePmB9iDEZaP1EZinR5HxgnOeVxBsaG5uYmZiamFua mpuSJqwkzit3SSZQSCA9sSQ1OzW1ILUovqg0J7X4ECMTB6dUA+Ndt711ruttf9suk4mZdE+7 Y+8lgXiH05eik+O/v5D8+vES36YQ5rnpa+ufcLz/9cijLcd1xd+dHIfPOV+bftsvWS/fPfX1 97uzgzOfKZ3/b1q+YsuKotiT4aLL3ugEpPkl/5r4pth/RgrXHv/TNtN52tKm84l3zlRlSppb af/X4JXfAYYZ31KUWIozEg21mIuKEwGF69p76QIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrCKsWRmVeSWpSXmKPExsVy+t9jQV05Cf1Agw+vFC2WXLzKbjFn/Ro2 i8sLL7FaXN41h81if2cHowOrx56JJ9k8Tsz4zeLRt2UVo8f0eT+ZPD5vkgtgjWpgtMlITUxJ LVJIzUvOT8nMS7dV8g6Od443NTMw1DW0tDBXUshLzE21VXLxCdB1y8wB2q6kUJaYUwoUCkgs LlbSt8M0ITTETdcCpjFC1zckCK7HyAANJKxjzNj19BRTwV7uip7X15gbGC9ydjFyckgImEi8 n/uWBcIWk7hwbz1bFyMXh5DAdEaJzY82M0M4vxglLkzfzg5SxSagJvHly2Egm4NDREBfoq1F A6SGWaCXUeJM726wGiEBW4ljbW1gUzkF7CR+Pz3KCmILC4RKNJ/dBhZnEVCVmLNwD5jNC1R/ 41kfO4QtKPFj8j2wOLOAlsT6nceZIGx5ic1r3jKD7JUQUJd49FcX4gQjiSkXyyEqRCT2vXjH OIFRaBaSQbOQDJqFZNAsJC0LGFlWMYqmFiQXFCel5xrqFSfmFpfmpesl5+duYgSngWdSOxhX NlgcYhTgYFTi4e0w0QsUYk0sK67MPcQowcGsJMLrwq8fKMSbklhZlVqUH19UmpNafIgxGejP icxSosn5wBSVVxJvaGxiZmRpZGZhZGJuTpqwkjgv46knAUIC6YklqdmpqQWpRTBbmDg4pRoY K8JOPHkx3X6/2NFDNhlGB11dXsdd+pd2xL/BYMfGU6zroszd9j2ONFEODVzYVaJaGDNB/GJK xAGLGUlzF3boV4jYF2Sydmq/Nu7wfHuNc0Fh2PVZ/y+mNLU1+/7weLTLR8HhXkfgmsCw/o8S pydoCocYZV89XhrWyjHjRvSiLWdn/HRbHLNUiaU4I9FQi7moOBEA2DZ1rUcDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.34 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-type: text/plain; charset=ISO-8859-1 Content-language: ko __init/__exit annotations for probe()/remove() are supposed to be __devinit/__devexit, because __init/__exit for probe()/remove() are not correct. However, __devinit/__devexit are not used, because CONFIG_HOTPLUG was removed. Thus, these annotations should be removed. Signed-off-by: Jingoo Han --- drivers/rtc/rtc-mc13xxx.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/rtc/rtc-mc13xxx.c b/drivers/rtc/rtc-mc13xxx.c index 2643d88..9ae755d 100644 --- a/drivers/rtc/rtc-mc13xxx.c +++ b/drivers/rtc/rtc-mc13xxx.c @@ -309,7 +309,7 @@ static irqreturn_t mc13xxx_rtc_reset_handler(int irq, void *dev) return IRQ_HANDLED; } -static int __init mc13xxx_rtc_probe(struct platform_device *pdev) +static int mc13xxx_rtc_probe(struct platform_device *pdev) { int ret; struct mc13xxx_rtc *priv; @@ -378,7 +378,7 @@ err_reset_irq_request: return ret; } -static int __exit mc13xxx_rtc_remove(struct platform_device *pdev) +static int mc13xxx_rtc_remove(struct platform_device *pdev) { struct mc13xxx_rtc *priv = platform_get_drvdata(pdev); @@ -413,7 +413,7 @@ MODULE_DEVICE_TABLE(platform, mc13xxx_rtc_idtable); static struct platform_driver mc13xxx_rtc_driver = { .id_table = mc13xxx_rtc_idtable, - .remove = __exit_p(mc13xxx_rtc_remove), + .remove = mc13xxx_rtc_remove, .driver = { .name = DRIVER_NAME, .owner = THIS_MODULE,