From patchwork Thu Mar 14 08:19:35 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 227479 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-yh0-x23a.google.com (mail-yh0-x23a.google.com [IPv6:2607:f8b0:4002:c01::23a]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 4BD4F2C00A8 for ; Thu, 14 Mar 2013 19:19:39 +1100 (EST) Received: by mail-yh0-f58.google.com with SMTP id 47sf774266yhr.3 for ; Thu, 14 Mar 2013 01:19:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:received-spf:x-auditid:from:to:cc :references:in-reply-to:subject:date:message-id:mime-version :x-mailer:thread-index:x-brightmail-tracker:x-brightmail-tracker :dlp-filter:x-mtr:x-cfilter-loop:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:x-google-group-id:list-post:list-help:list-archive:sender :list-subscribe:list-unsubscribe:content-type:content-language; bh=48QOU9foIHIlklLwgf/rCh6iMNt8LirOdTXshpXaW70=; b=AIKsxblmTCiXbHeMZzPJ71TgyAHwR1axGHlDA5dGJJ1av9XAUlIYoOOI9fL0yGqbaz 7seT54A5lBlN8MopU24JWcbIeUtBL1K734nyy2WSNKCurxUtjqgP9nbwBmfCrh43El4/ 7tpwzEz43ImW7ONDrriY92DOuB1eWKufY9lKlP0FutrE9iENVl3PkElKjmxwlLilcbg6 G1nOIkhokL+oeVwPI2OkqvdjrWAesXWVigRovfOJ5iUMabVRdSqlGi1tYlQxTE135yy5 a+i+R5Nf2PqO4XveWEF6L1veSn2qhbX9zp1pzWtmI0VIsuRFetiLly0haKUWNKFLHzyh KAaQ== X-Received: by 10.50.30.201 with SMTP id u9mr106249igh.3.1363249176803; Thu, 14 Mar 2013 01:19:36 -0700 (PDT) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.45.232 with SMTP id q8ls3341044igm.28.gmail; Thu, 14 Mar 2013 01:19:36 -0700 (PDT) X-Received: by 10.68.132.73 with SMTP id os9mr917900pbb.4.1363249176490; Thu, 14 Mar 2013 01:19:36 -0700 (PDT) Received: from mailout2.samsung.com (mailout2.samsung.com. [203.254.224.25]) by gmr-mx.google.com with ESMTP id ir9si648525pbc.1.2013.03.14.01.19.36; Thu, 14 Mar 2013 01:19:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.25 as permitted sender) client-ip=203.254.224.25; Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MJN00BLR5SM0Y20@mailout2.samsung.com> for rtc-linux@googlegroups.com; Thu, 14 Mar 2013 17:19:35 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.49]) by epcpsbgr4.samsung.com (EPCPMTA) with SMTP id C0.CD.02019.71881415; Thu, 14 Mar 2013 17:19:35 +0900 (KST) X-AuditID: cbfee690-b7f656d0000007e3-4a-51418817f987 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id CE.48.13494.71881415; Thu, 14 Mar 2013 17:19:35 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MJN00IJH5SNW680@mmp2.samsung.com>; Thu, 14 Mar 2013 17:19:35 +0900 (KST) From: Jingoo Han To: 'Andrew Morton' Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' , rtc-linux@googlegroups.com, 'Jingoo Han' References: <008401ce208b$5c9dc6f0$15d954d0$%han@samsung.com> In-reply-to: <008401ce208b$5c9dc6f0$15d954d0$%han@samsung.com> Subject: [rtc-linux] [PATCH 16/30] rtc: rtc-max6900: use devm_rtc_device_register() Date: Thu, 14 Mar 2013 17:19:35 +0900 Message-id: <009301ce208c$a99a3910$fcceab30$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4gi1x0RMHvEnZmRRqxNJmQP3DTwgAAT+UQ X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrKIsWRmVeSWpSXmKPExsVy+t8zQ13xDsdAgzuLlSyWXLzKbjFn/Ro2 i8sLL7FaXN41h81if2cHowOrx56JJ9k8Tsz4zeLRt2UVo8f0eT+ZPD5vkgtgjeKySUnNySxL LdK3S+DKuP32CXPBX46Ku2ub2BsY97J3MXJySAiYSNy49YwFwhaTuHBvPVsXIxeHkMAyRonu QweZYYomr//DDJGYDpRY8x6q6hejxNxLv8Cq2ATUJL58OQw0loNDREBfoq1FA6SGWaCXUeJM 726wuJCArcT1/3YgJqeAncSG9WIgncIC7hI31m5iBQmzCKhKbO3QAAnzAhWfPHWRHcIWlPgx +R7YncwCWhLrdx5ngrDlJTavecsM0iohoC7x6K8uSFhEwEji3swbbBAlIhL7XrxjBDlGQuAW u8TcPw1gCRYBAYlvkw+xQPTKSmw6APWtpMTBFTdYJjBKzEKyeRaSzbOQbJ6FZMUCRpZVjKKp BckFxUnpRSZ6xYm5xaV56XrJ+bmbGCFROmEH470D1ocYk4HWT2SWEk3OB0Z5Xkm8obGZkYWp iamxkbmlGWnCSuK86i3WgUIC6YklqdmpqQWpRfFFpTmpxYcYmTg4pRoYJz7hm73lfk9028qn V4MnGh69M+dFU+u0PZc0194uSUztuWPlp75Id0rCmvVqfruvnlALi9DSmfh2/6qcyyeCpons nP9WP4i1NF+Ab2+iG2NO4saz3f8ZLH0L5rOZSbDzvbij/jlZjmFOeP7f7TeWXGDa83u53vT5 6c0rX1+aLJsbGpqS3aviosRSnJFoqMVcVJwIAO3um+voAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrEKsWRmVeSWpSXmKPExsVy+t9jQV3xDsdAg4bHshZLLl5lt5izfg2b xeWFl1gtLu+aw2axv7OD0YHVY8/Ek2weJ2b8ZvHo27KK0WP6vJ9MHp83yQWwRjUw2mSkJqak Fimk5iXnp2TmpdsqeQfHO8ebmhkY6hpaWpgrKeQl5qbaKrn4BOi6ZeYAbVdSKEvMKQUKBSQW Fyvp22GaEBripmsB0xih6xsSBNdjZIAGEtYxZtx++4S54C9Hxd21TewNjHvZuxg5OSQETCQm r//DDGGLSVy4t56ti5GLQ0hgOqNE95r3UM4vRom5l36BVbEJqEl8+XIYqJuDQ0RAX6KtRQOk hlmgl1HiTO9usLiQgK3E9f92ICangJ3EhvViIJ3CAu4SN9ZuYgUJswioSmzt0AAJ8wIVnzx1 kR3CFpT4MfkeC4jNLKAlsX7ncSYIW15i85q3zCCtEgLqEo/+6oKERQSMJO7NvMEGUSIise/F O8YJjEKzkEyahWTSLCSTZiFpWcDIsopRNLUguaA4KT3XSK84Mbe4NC9dLzk/dxMjOAU8k97B uKrB4hCjAAejEg9vhKhjoBBrYllxZe4hRgkOZiURXk8voBBvSmJlVWpRfnxRaU5q8SHGZKA/ JzJLiSbnA9NTXkm8obGJmZGlkZmFkYm5OWnCSuK8B1utA4UE0hNLUrNTUwtSi2C2MHFwSjUw tgWwRKb/9JnCtWM/j4Wt94kzZhnZ5coam17mMMm8vWWut9CCu3fiZ3XBEsXpx+3qKgwYnUxr rE6XLsv8LGq6m1mwjaP74mQm/Qr7j22xmpdnXgwQed705HZj1p+T8tP4c43v+t47dSZeIG1Z wIK/N1XkUg+cr15y38jPrEWOJfTFIjYJ0UNKLMUZiYZazEXFiQCRxdjFRQMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.25 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-type: text/plain; charset=ISO-8859-1 Content-language: ko devm_rtc_device_register() is device managed and makes cleanup paths simpler. Signed-off-by: Jingoo Han --- drivers/rtc/rtc-max6900.c | 9 ++------- 1 files changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/rtc/rtc-max6900.c b/drivers/rtc/rtc-max6900.c index a00e332..8669d6d 100644 --- a/drivers/rtc/rtc-max6900.c +++ b/drivers/rtc/rtc-max6900.c @@ -214,11 +214,6 @@ static int max6900_rtc_set_time(struct device *dev, struct rtc_time *tm) static int max6900_remove(struct i2c_client *client) { - struct rtc_device *rtc = i2c_get_clientdata(client); - - if (rtc) - rtc_device_unregister(rtc); - return 0; } @@ -237,8 +232,8 @@ max6900_probe(struct i2c_client *client, const struct i2c_device_id *id) dev_info(&client->dev, "chip found, driver version " DRV_VERSION "\n"); - rtc = rtc_device_register(max6900_driver.driver.name, - &client->dev, &max6900_rtc_ops, THIS_MODULE); + rtc = devm_rtc_device_register(&client->dev, max6900_driver.driver.name, + &max6900_rtc_ops, THIS_MODULE); if (IS_ERR(rtc)) return PTR_ERR(rtc);