| Message ID | 003401ce47c8$cf834140$6e89c3c0$@samsung.com |
|---|---|
| State | Accepted |
| Headers | show |
On 03/05/13 18:38, Jingoo Han wrote: > The driver core clears the driver data to NULL after device_release > or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d > (device-core: Ensure drvdata = NULL when no driver is bound). > Thus, it is not needed to manually clear the device driver data to NULL. > > Signed-off-by: Jingoo Han <jg1.han@samsung.com> > --- > drivers/rtc/rtc-vt8500.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/drivers/rtc/rtc-vt8500.c b/drivers/rtc/rtc-vt8500.c > index d89efee..c2d6331 100644 > --- a/drivers/rtc/rtc-vt8500.c > +++ b/drivers/rtc/rtc-vt8500.c > @@ -282,8 +282,6 @@ static int vt8500_rtc_remove(struct platform_device *pdev) > /* Disable alarm matching */ > writel(0, vt8500_rtc->regbase + VT8500_RTC_IS); > > - platform_set_drvdata(pdev, NULL); > - > return 0; > } > Acked-by: Tony Prisk <linux@prisktech.co.nz>
diff --git a/drivers/rtc/rtc-vt8500.c b/drivers/rtc/rtc-vt8500.c index d89efee..c2d6331 100644 --- a/drivers/rtc/rtc-vt8500.c +++ b/drivers/rtc/rtc-vt8500.c @@ -282,8 +282,6 @@ static int vt8500_rtc_remove(struct platform_device *pdev) /* Disable alarm matching */ writel(0, vt8500_rtc->regbase + VT8500_RTC_IS); - platform_set_drvdata(pdev, NULL); - return 0; }
The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han <jg1.han@samsung.com> --- drivers/rtc/rtc-vt8500.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)