From patchwork Fri Feb 15 07:26:59 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 220670 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-ie0-x23e.google.com (mail-ie0-x23e.google.com [IPv6:2607:f8b0:4001:c03::23e]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 8048C2C0082 for ; Fri, 15 Feb 2013 18:27:04 +1100 (EST) Received: by mail-ie0-f190.google.com with SMTP id 17sf1055119iea.27 for ; Thu, 14 Feb 2013 23:27:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:x-received:received-spf:x-auditid :from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:x-mailer:thread-index:x-cr-hashedpuzzle:x-cr-puzzleid :x-brightmail-tracker:x-brightmail-tracker:dlp-filter:x-mtr :x-cfilter-loop:x-original-sender:x-original-authentication-results :reply-to:precedence:mailing-list:list-id:x-google-group-id :list-post:list-help:list-archive:sender:list-subscribe :list-unsubscribe:content-type:content-language; bh=BwRZ20T6jleo+csSwenVnzHBBs8x5Qx/aRZZHipnaNQ=; b=ORBBuEkPJlB/1ry9tjsm8K/OJYy8Hg3PeF4gomo9v6cfDajRyhZftMcRHvA5cOe3ce RLEZwAP5aV8KDj42qjTampzXUCnCQyILoUNrBARbqkK7hRMhhH0yuM52AyyTQ7mkRSo5 XOtOHIuofIRf7jxIEj1GYaZ0qkeAQPy3yabKdhTCW53YnwqENXiDuLYwzBHqgQyBFm6G e3LduURAfguyEQGbkupRNSsJ2vlFahEvgxSuuvsbfp7J0CJGYkUmyYg/fI9VFGV3q+9n fMUNWuzVT8+F0qIzfyYFSTNaMH/CGvPXRs/Ns9Bm10/2uOnXNpbLrDiVdwM3Vn4EomGS tvMw== X-Received: by 10.50.196.227 with SMTP id ip3mr177161igc.10.1360913222191; Thu, 14 Feb 2013 23:27:02 -0800 (PST) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.192.134 with SMTP id hg6ls333931igc.33.gmail; Thu, 14 Feb 2013 23:27:01 -0800 (PST) X-Received: by 10.66.84.100 with SMTP id x4mr929290pay.43.1360913221781; Thu, 14 Feb 2013 23:27:01 -0800 (PST) X-Received: by 10.66.84.100 with SMTP id x4mr929289pay.43.1360913221769; Thu, 14 Feb 2013 23:27:01 -0800 (PST) Received: from mailout4.samsung.com (mailout4.samsung.com. [203.254.224.34]) by gmr-mx.google.com with ESMTP id tj3si630486pbc.0.2013.02.14.23.27.01; Thu, 14 Feb 2013 23:27:01 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.34 as permitted sender) client-ip=203.254.224.34; Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MI9004H63D0VMH0@mailout4.samsung.com> for rtc-linux@googlegroups.com; Fri, 15 Feb 2013 16:27:00 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.51]) by epcpsbgr5.samsung.com (EPCPMTA) with SMTP id E8.5D.06692.343ED115; Fri, 15 Feb 2013 16:26:59 +0900 (KST) X-AuditID: cbfee691-b7f556d000001a24-a1-511de34366b5 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id A5.49.03880.343ED115; Fri, 15 Feb 2013 16:26:59 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MI9006KT3CZXMN1@mmp1.samsung.com> for rtc-linux@googlegroups.com; Fri, 15 Feb 2013 16:26:59 +0900 (KST) From: Jingoo Han To: 'Andrew Morton' Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' , rtc-linux@googlegroups.com, 'Jingoo Han' References: <002b01ce0b4d$865ca950$9315fbf0$%han@samsung.com> In-reply-to: <002b01ce0b4d$865ca950$9315fbf0$%han@samsung.com> Subject: [rtc-linux] [PATCH V3 04/11] rtc: rtc-ds2404: use dev_err() instead of printk() Date: Fri, 15 Feb 2013 16:26:59 +0900 Message-id: <002e01ce0b4d$d77e0270$867a0750$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4LTYY6VzXwCUtKTcq8t8M0FTt2HQAADQ6w x-cr-hashedpuzzle: Gk0F Mcku NfuK R3bV Suy6 VSgV WjmD ZECt ZM3k ayd1 nR94 pYxj sBeE x906 zLws zZfP; 5; YQAuAHoAdQBtAG0AbwBAAHQAbwB3AGUAcgB0AGUAYwBoAC4AaQB0ADsAYQBrAHAAbQBAAGwAaQBuAHUAeAAtAGYAbwB1AG4AZABhAHQAaQBvAG4ALgBvAHIAZwA7AGoAZwAxAC4AaABhAG4AQABzAGEAbQBzAHUAbgBnAC4AYwBvAG0AOwBsAGkAbgB1AHgALQBrAGUAcgBuAGUAbABAAHYAZwBlAHIALgBrAGUAcgBuAGUAbAAuAG8AcgBnADsAcgB0AGMALQBsAGkAbgB1AHgAQABnAG8AbwBnAGwAZQBnAHIAbwB1AHAAcwAuAGMAbwBtAA==; Sosha1_v1; 7; {CC394ABA-A623-416F-817F-222F1C6EA019}; agBnADEALgBoAGEAbgBAAHMAYQBtAHMAdQBuAGcALgBjAG8AbQA=; Fri, 15 Feb 2013 07:26:51 GMT; WwBQAEEAVABDAEgAIABWADMAIAAwADQALwAxADEAXQAgAHIAdABjADoAIAByAHQAYwAtAGQAcwAyADQAMAA0ADoAIAB1AHMAZQAgAGQAZQB2AF8AZQByAHIAKAApACAAaQBuAHMAdABlAGEAZAAgAG8AZgAgAHAAcgBpAG4AdABrACgAKQA= x-cr-puzzleid: {CC394ABA-A623-416F-817F-222F1C6EA019} X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrJIsWRmVeSWpSXmKPExsVy+t8zY13nx7KBBtdXGVvs7+xgdGD02DPx JFsAYxSXTUpqTmZZapG+XQJXxtpNU9kLVnFWLJ97nrmBcS97FyMnh4SAiUTPyS9sELaYxIV7 64FsLg4hgWWMEv8ub4cr+vryHhOILSSwiFGi8zMTRNFMJonzH2axgiTYBNQkvnw5DNTAwSEi oC/R1qIBUsMs0MsocaZ3NztEs63E1N/fwOo5BewkVk/qAIsLC/hInPo2iRHEZhFQlZg8YS6Y zQtUv2h7LxuELSjxY/I9FhCbWUBLYvO2JlYIW15i85q3zCB7JQTUJR791QUJiwgYSSz+t50J okREYt+Ld4wg90gIfGCV+HzgMNRjphLfph9khUjsY5f4ePEOM8QRAhLfJh9igRgqK7HpADNE vaTEwRU3WCYwSs1CctIsJCfNQnLSLCS7FzCyrGIUTS1ILihOSi8y1StOzC0uzUvXS87P3cQI icaJOxjvH7A+xJgMtH4is5Rocj4wmvNK4g2NjU3MTExNzC1NzU1JE1YS55W/JBMoJJCeWJKa nZpakFoUX1Sak1p8iJGJg1OqgTEh17Dg0Nv+Fg3z+262kZcX7kpwPSy5dkN08cerSkx3w7jy ZkszPfv42XfZhlCr194bftldvu2iVrHdKe3K8jMHN+TUpZcZfzq0lFfUZkKv1SvNNbozHd9s nSLbesLo8rR5pu7L//VWH9VjKpyuezgvT9/6tOl6BvPXUl9LmDUDvr9Z/iRr1iMlluKMREMt 5qLiRADPr1/d3AIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrGKsWRmVeSWpSXmKPExsVy+t9jAV3nx7KBBlsO6Fvs7+xgdGD02DPx JFsAY1QDo01GamJKapFCal5yfkpmXrqtkndwvHO8qZmBoa6hpYW5kkJeYm6qrZKLT4CuW2YO 0FglhbLEnFKgUEBicbGSvh2mCaEhbroWMI0Rur4hQXA9RgZoIGEdY8baTVPZC1ZxViyfe565 gXEvexcjJ4eEgInE15f3mCBsMYkL99azgdhCAosYJTo/A8W5gOyZTBLnP8xiBUmwCahJfPly GKiZg0NEQF+irUUDpIZZoJdR4kzvbnaIZluJqb+/gdVzCthJrJ7UARYXFvCROPVtEiOIzSKg KjF5wlwwmxeoftH2XjYIW1Dix+R7LCA2s4CWxOZtTawQtrzE5jVvmUH2SgioSzz6qwsSFhEw klj8bzsTRImIxL4X7xhB7pEQ+MAq8fnAYagnTSW+TT/IOoFRZBaSFbOQrJiFZMUsJLMWMLKs YhRNLUguKE5KzzXSK07MLS7NS9dLzs/dxAiO9WfSOxhXNVgcYhTgYFTi4RWQkA0UYk0sK67M PcQowcGsJMIrdwsoxJuSWFmVWpQfX1Sak1p8iDEZGAITmaVEk/OBaSivJN7Q2MTMyNLIzMLI xNycNGElcV7GU08ChATSE0tSs1NTC1KLYLYwcXBKNTBKu9UaM39s4er0zd/l/+P4/ZLshPSk iITdW9r1vpa63VFIuHfQcPf1935hc6X++KXtUdv7VTt7nya/RG3mhbajZtW9My89kNa7cdKv 99CqA1lmp6fHLNev4ufbzvaxru/X00sHdczLjswP1Q+WaHpptVNvYhWnzZ7nrF/jvzdeOFF1 c1LO8bVKLMUZiYZazEXFiQBNauhQOQMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.34 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-type: text/plain; charset=ISO-8859-1 Content-language: ko Fixed the checkpatch warning as below: WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... Signed-off-by: Jingoo Han --- No changes since v1: No changes since v2: drivers/rtc/rtc-ds2404.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-ds2404.c b/drivers/rtc/rtc-ds2404.c index 4539e37..b04fc42 100644 --- a/drivers/rtc/rtc-ds2404.c +++ b/drivers/rtc/rtc-ds2404.c @@ -70,7 +70,7 @@ static int ds2404_gpio_map(struct ds2404 *chip, struct platform_device *pdev, for (i = 0; i < ARRAY_SIZE(ds2404_gpio); i++) { err = gpio_request(ds2404_gpio[i].gpio, ds2404_gpio[i].name); if (err) { - printk(KERN_ERR "error mapping gpio %s: %d\n", + dev_err(&pdev->dev, "error mapping gpio %s: %d\n", ds2404_gpio[i].name, err); goto err_request; } @@ -177,7 +177,7 @@ static void ds2404_write_memory(struct device *dev, u16 offset, for (i = 0; i < length; i++) { if (out[i] != ds2404_read_byte(dev)) { - printk(KERN_ERR "read invalid data\n"); + dev_err(dev, "read invalid data\n"); return; } }