From patchwork Fri Feb 15 07:24:43 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 220667 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-ob0-f189.google.com (mail-ob0-f189.google.com [209.85.214.189]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 13A1E2C007B for ; Fri, 15 Feb 2013 18:24:47 +1100 (EST) Received: by mail-ob0-f189.google.com with SMTP id wd20sf1061204obb.16 for ; Thu, 14 Feb 2013 23:24:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:x-received:received-spf:x-auditid :from:to:cc:subject:date:message-id:mime-version:x-mailer :thread-index:x-brightmail-tracker:x-brightmail-tracker:dlp-filter :x-mtr:x-cfilter-loop:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:x-google-group-id:list-post:list-help:list-archive:sender :list-subscribe:list-unsubscribe:content-type:content-language; bh=c0pgfO/lXuiAmww4i0fZ/v4PWQt7TaB0YJ6RVkyrWts=; b=Wv+uMXfJheQvflDbK4GNH5lmi/o8shodUZtmVlqTGqCtjUD/T5NH63t1YyWfKwet7a eotGDjSrljOxl+ClwerQCDQD47/YZ3KBsHQ3+sbyZ/GoHix6zuQFa8afpVA3Jw9jROWK kj2h2/WAlejSXPYOjJiZ1p2naLWxxLd/ke7W89zSfDplvRmOIHSLa0AkZS3sjAIJtAbj /NwLvHxrh0nO3TA8u9HwmjrGURJpRdhIjk89/voKUhVOh9vBbA+LWcN3BmCM7cZrCHqO U0yxtRmNnM70rwqShoVBNyUD9jhjOxvzbTS2qqQuyIt7K8XrNekdHf4O3NVT3sm2zehV vF8w== X-Received: by 10.50.53.166 with SMTP id c6mr177128igp.12.1360913085271; Thu, 14 Feb 2013 23:24:45 -0800 (PST) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.94.130 with SMTP id dc2ls320933igb.4.canary; Thu, 14 Feb 2013 23:24:44 -0800 (PST) X-Received: by 10.68.132.73 with SMTP id os9mr205889pbb.4.1360913084796; Thu, 14 Feb 2013 23:24:44 -0800 (PST) X-Received: by 10.68.132.73 with SMTP id os9mr205888pbb.4.1360913084786; Thu, 14 Feb 2013 23:24:44 -0800 (PST) Received: from mailout4.samsung.com (mailout4.samsung.com. [203.254.224.34]) by gmr-mx.google.com with ESMTP id wc12si629487pbc.1.2013.02.14.23.24.44; Thu, 14 Feb 2013 23:24:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.34 as permitted sender) client-ip=203.254.224.34; Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MI900JVA38Q1R80@mailout4.samsung.com> for rtc-linux@googlegroups.com; Fri, 15 Feb 2013 16:24:43 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.49]) by epcpsbgr4.samsung.com (EPCPMTA) with SMTP id 53.C4.05791.BB2ED115; Fri, 15 Feb 2013 16:24:43 +0900 (KST) X-AuditID: cbfee690-b7f066d00000169f-46-511de2bb7df7 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 82.98.03880.BB2ED115; Fri, 15 Feb 2013 16:24:43 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MI90082C397QE00@mmp2.samsung.com> for rtc-linux@googlegroups.com; Fri, 15 Feb 2013 16:24:43 +0900 (KST) From: Jingoo Han To: 'Andrew Morton' Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' , rtc-linux@googlegroups.com, 'Jingoo Han' Subject: [rtc-linux] [PATCH V3 01/11] rtc: use dev_warn()/dev_dbg()/pr_err() instead of printk() Date: Fri, 15 Feb 2013 16:24:43 +0900 Message-id: <002b01ce0b4d$865ca950$9315fbf0$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4LTYY6VzXwCUtKTcq8t8M0FTt2HQ== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprBIsWRmVeSWpSXmKPExsVy+t8zQ93dj2QDDbZN0bXY39nB6MDosWfi SbYAxigum5TUnMyy1CJ9uwSujN/T1jIVXBeuWLP3M1sDY6NAFyMnh4SAicTXI49YIWwxiQv3 1rN1MXJxCAksY5SYePguI0xR49r3zBCJ6YwSJ+4+YIJwZjJJbLm7ixmkik1ATeLLl8PsXYwc HCIC+hJtLRogNcwCvYwSZ3p3s4PUCAuESbztBFnBycEioCqxa/93FpB6XgFbiVvLc0DCvAKC Ej8m32MBsZkFtCQ2b2tihbDlJTavecsMUi4hoC7x6K8uSFhEQE/i2ZXp7BAlIhL7XrxjBFkr IdDPLtHWOocdYpWAxLfJh1ggemUlNh1ghvhLUuLgihssExjFZiHZPAvJ5llINs9CsmIBI8sq RtHUguSC4qT0IhO94sTc4tK8dL3k/NxNjJBYmbCD8d4B60OMyUDrJzJLiSbnA2MtryTe0NjY xMzE1MTc0tTclDRhJXFe+UsygUIC6YklqdmpqQWpRfFFpTmpxYcYmTg4pRoY++ctCzTQ+Lwv Ltj4yqfCnp1fdTfMNTw3dcmUT/f0PiqrnHM9kVL3VtK59lZJsl7GxJOrI/hbNC8941unbTv9 07xDihW6X2yzI3rnTthdnBl08lb7/WM8Dn+8Nbv6b5aG2Lw+8TBo+yJj2Uy1sMXrt7GcNNY+ kOmeZvH88YTXyp2bDyu0MwjdUGIpzkg01GIuKk4EAMsgE/SrAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrKIsWRmVeSWpSXmKPExsVy+t9jQd3dj2QDDaYf07DY39nB6MDosWfi SbYAxqgGRpuM1MSU1CKF1Lzk/JTMvHRbJe/geOd4UzMDQ11DSwtzJYW8xNxUWyUXnwBdt8wc oLFKCmWJOaVAoYDE4mIlfTtME0JD3HQtYBojdH1DguB6jAzQQMI6xozf09YyFVwXrliz9zNb A2OjQBcjJ4eEgIlE49r3zBC2mMSFe+vZuhi5OIQEpjNKnLj7gAnCmckkseXuLrAqNgE1iS9f DrN3MXJwiAjoS7S1aIDUMAv0Mkqc6d3NDlIjLBAm8bYTZBInB4uAqsSu/d9ZQOp5BWwlbi3P AQnzCghK/Jh8jwXEZhbQkti8rYkVwpaX2LzmLTNIuYSAusSjv7ogYREBPYlnV6azQ5SISOx7 8Y5xAqPALCSTZiGZNAvJpFlIWhYwsqxiFE0tSC4oTkrPNdIrTswtLs1L10vOz93ECI7EZ9I7 GFc1WBxiFOBgVOLhFZCQDRRiTSwrrsw9xCjBwawkwit3CyjEm5JYWZValB9fVJqTWnyIMRno z4nMUqLJ+cAkkVcSb2hsYmZkaWRmYWRibk6asJI4L+OpJwFCAumJJanZqakFqUUwW5g4OKUa GKe2yP3Yq636O/pWOYuQwJWW/Ddznz5U144s9sgoef/u/JZj+gVnWUW+b49bu079dtRR2USO 6gsz7C8fDw1Vczb0br64Krp7m8ylLInn8WZLpb/kv3d0dK3N+57TpPHzy4VuT77zDKdPLrZ9 8iSs7axfTOSbB3GvJQTnsNq6rdgVK3ha5Z5MshJLcUaioRZzUXEiAJscfMEIAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.34 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-type: text/plain; charset=ISO-8859-1 Content-language: ko Fixed the checkpatch warning as below: WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... Signed-off-by: Jingoo Han --- Changes since v1: - Repalce pr_warn(), pr_debug() with dev_warn(), dev_dbg() No Changes since v2: drivers/rtc/class.c | 4 +++- drivers/rtc/rtc-dev.c | 11 ++++++----- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/class.c b/drivers/rtc/class.c index 26388f1..9b742d3 100644 --- a/drivers/rtc/class.c +++ b/drivers/rtc/class.c @@ -11,6 +11,8 @@ * published by the Free Software Foundation. */ +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt + #include #include #include @@ -261,7 +263,7 @@ static int __init rtc_init(void) { rtc_class = class_create(THIS_MODULE, "rtc"); if (IS_ERR(rtc_class)) { - printk(KERN_ERR "%s: couldn't create class\n", __FILE__); + pr_err("couldn't create class\n"); return PTR_ERR(rtc_class); } rtc_class->suspend = rtc_suspend; diff --git a/drivers/rtc/rtc-dev.c b/drivers/rtc/rtc-dev.c index 9a86b4b..d049393 100644 --- a/drivers/rtc/rtc-dev.c +++ b/drivers/rtc/rtc-dev.c @@ -11,6 +11,8 @@ * published by the Free Software Foundation. */ +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt + #include #include #include @@ -462,7 +464,7 @@ void rtc_dev_prepare(struct rtc_device *rtc) return; if (rtc->id >= RTC_DEV_MAX) { - pr_debug("%s: too many RTC devices\n", rtc->name); + dev_dbg(&rtc->dev, "%s: too many RTC devices\n", rtc->name); return; } @@ -480,10 +482,10 @@ void rtc_dev_prepare(struct rtc_device *rtc) void rtc_dev_add_device(struct rtc_device *rtc) { if (cdev_add(&rtc->char_dev, rtc->dev.devt, 1)) - printk(KERN_WARNING "%s: failed to add char device %d:%d\n", + dev_warn(&rtc->dev, "%s: failed to add char device %d:%d\n", rtc->name, MAJOR(rtc_devt), rtc->id); else - pr_debug("%s: dev (%d:%d)\n", rtc->name, + dev_dbg(&rtc->dev, "%s: dev (%d:%d)\n", rtc->name, MAJOR(rtc_devt), rtc->id); } @@ -499,8 +501,7 @@ void __init rtc_dev_init(void) err = alloc_chrdev_region(&rtc_devt, 0, RTC_DEV_MAX, "rtc"); if (err < 0) - printk(KERN_ERR "%s: failed to allocate char dev region\n", - __FILE__); + pr_err("failed to allocate char dev region\n"); } void __exit rtc_dev_exit(void)